| commit | a18f9e501455e8a113be34e7a26b316f90530367 | [log] [tgz] |
|---|---|---|
| author | Jason Chiu <chiujason@google.com> | Mon Mar 25 17:08:09 2024 +0800 |
| committer | Jason Chiu <chiujason@google.com> | Thu Mar 28 02:44:09 2024 +0000 |
| tree | 302755962f58fdcb182db61a5a661157e403bc4e | |
| parent | 67bfb4141fbb8b11d78581e767e595ff1cf8968a [diff] |
[Safer intents] Input method To avoid implicit intents, make intents launch explicitly. Test: build Bug: 323061508 Change-Id: I8d9e8e2b70c3ef913087b72800cd40e0c3df8164
diff --git a/src/com/android/settings/inputmethod/KeyboardSettingsPreferenceController.java b/src/com/android/settings/inputmethod/KeyboardSettingsPreferenceController.java index ae6a24a..06a132d 100644 --- a/src/com/android/settings/inputmethod/KeyboardSettingsPreferenceController.java +++ b/src/com/android/settings/inputmethod/KeyboardSettingsPreferenceController.java
@@ -53,6 +53,7 @@ for (HardKeyboardDeviceInfo hardKeyboardDeviceInfo : newHardKeyboards) { if (mCachedDevice.getAddress().equals(hardKeyboardDeviceInfo.mBluetoothAddress)) { Intent intent = new Intent(Settings.ACTION_HARD_KEYBOARD_SETTINGS); + intent.setPackage(mContext.getPackageName()); intent.putExtra( Settings.EXTRA_ENTRYPOINT, SettingsEnums.CONNECTED_DEVICES_SETTINGS); intent.putExtra(
diff --git a/src/com/android/settings/inputmethod/PhysicalKeyboardPreferenceController.java b/src/com/android/settings/inputmethod/PhysicalKeyboardPreferenceController.java index b88928c..e4ad17a 100644 --- a/src/com/android/settings/inputmethod/PhysicalKeyboardPreferenceController.java +++ b/src/com/android/settings/inputmethod/PhysicalKeyboardPreferenceController.java
@@ -67,6 +67,7 @@ return false; } Intent intent = new Intent(Settings.ACTION_HARD_KEYBOARD_SETTINGS); + intent.setPackage(mContext.getPackageName()); intent.putExtra(Settings.EXTRA_ENTRYPOINT, SettingsEnums.KEYBOARD_SETTINGS); mContext.startActivity(intent); return true;
diff --git a/src/com/android/settings/inputmethod/UserDictionaryListPreferenceController.java b/src/com/android/settings/inputmethod/UserDictionaryListPreferenceController.java index 9343493..ddc0fea 100644 --- a/src/com/android/settings/inputmethod/UserDictionaryListPreferenceController.java +++ b/src/com/android/settings/inputmethod/UserDictionaryListPreferenceController.java
@@ -191,7 +191,8 @@ private Preference createUserDictionaryPreference(String locale) { final String KEY_LOCALE = "locale"; final Preference newPref = new Preference(mScreen.getContext()); - final Intent intent = new Intent(USER_DICTIONARY_SETTINGS_INTENT_ACTION); + final Intent intent = new Intent(USER_DICTIONARY_SETTINGS_INTENT_ACTION) + .setPackage(mContext.getPackageName()); if (locale == null) { newPref.setTitle(Locale.getDefault().getDisplayName()); newPref.setKey(Locale.getDefault().toString());