Settings for Polite Notifications
Adds settings page for polite notifications.
Test: atest PoliteNotificationsPreferenceControllerTest
Test: atest PoliteNotificationFilterControllerTest
Test: atest PoliteNotifVibrateUnlockedToggleControllerTest
Test: atest PoliteNotifWorkProfileToggleControllerTest
Bug: 270456865
Change-Id: I3ec497b068c15205df97bb26ee007beed8da9ee1
diff --git a/tests/robotests/Android.bp b/tests/robotests/Android.bp
index fbfd888..6b56d93 100644
--- a/tests/robotests/Android.bp
+++ b/tests/robotests/Android.bp
@@ -62,6 +62,7 @@
"aconfig_settings_flags_lib",
"platform-test-annotations",
"Settings-testutils2",
+ "notification_flags_lib",
],
libs: [
diff --git a/tests/robotests/src/com/android/settings/notification/PoliteNotifVibrateUnlockedToggleControllerTest.java b/tests/robotests/src/com/android/settings/notification/PoliteNotifVibrateUnlockedToggleControllerTest.java
new file mode 100644
index 0000000..f92ed25
--- /dev/null
+++ b/tests/robotests/src/com/android/settings/notification/PoliteNotifVibrateUnlockedToggleControllerTest.java
@@ -0,0 +1,123 @@
+/*
+ * Copyright (C) 2023 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.android.settings.notification;
+
+import static com.android.settings.accessibility.AccessibilityUtil.State.OFF;
+import static com.android.settings.accessibility.AccessibilityUtil.State.ON;
+import static com.google.common.truth.Truth.assertThat;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.when;
+
+import android.content.Context;
+import android.os.Vibrator;
+import android.platform.test.flag.junit.SetFlagsRule;
+import android.provider.Settings;
+
+import com.android.server.notification.Flags;
+import com.android.settings.core.BasePreferenceController;
+
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.robolectric.RobolectricTestRunner;
+import org.robolectric.RuntimeEnvironment;
+
+@RunWith(RobolectricTestRunner.class)
+public class PoliteNotifVibrateUnlockedToggleControllerTest {
+
+ @Rule
+ public final SetFlagsRule mSetFlagsRule = new SetFlagsRule();
+
+ private static final String PREFERENCE_KEY = "preference_key";
+
+ private PoliteNotifVibrateUnlockedToggleController mController;
+ private Context mContext;
+ @Mock
+ private Vibrator mVibrator;
+
+ @Before
+ public void setUp() {
+ MockitoAnnotations.initMocks(this);
+ mContext = spy(RuntimeEnvironment.application);
+ mController = new PoliteNotifVibrateUnlockedToggleController(mContext, PREFERENCE_KEY);
+ when(mContext.getSystemService(Vibrator.class)).thenReturn(mVibrator);
+ }
+
+ @Test
+ public void isAvailable_flagEnabled_vibrationSupported_shouldReturnTrue() {
+ // TODO: b/291907312 - remove feature flags
+ mSetFlagsRule.enableFlags(Flags.FLAG_POLITE_NOTIFICATIONS);
+ when(mVibrator.hasVibrator()).thenReturn(true);
+ assertThat(mController.isAvailable()).isTrue();
+ assertThat(mController.getAvailabilityStatus()).isEqualTo(
+ BasePreferenceController.AVAILABLE);
+ }
+
+ @Test
+ public void isAvailable_flagEnabled_vibrationNotSupported_shouldReturnFalse() {
+ // TODO: b/291907312 - remove feature flags
+ mSetFlagsRule.enableFlags(Flags.FLAG_POLITE_NOTIFICATIONS);
+ when(mVibrator.hasVibrator()).thenReturn(false);
+ assertThat(mController.isAvailable()).isFalse();
+ assertThat(mController.getAvailabilityStatus()).isEqualTo(
+ BasePreferenceController.UNSUPPORTED_ON_DEVICE);
+ }
+
+ @Test
+ public void isAvailable_flagDisabled_shouldReturnFalse() {
+ // TODO: b/291907312 - remove feature flags
+ mSetFlagsRule.disableFlags(Flags.FLAG_POLITE_NOTIFICATIONS);
+ assertThat(mController.isAvailable()).isFalse();
+ assertThat(mController.getAvailabilityStatus()).isEqualTo(
+ BasePreferenceController.CONDITIONALLY_UNAVAILABLE);
+ }
+
+ @Test
+ public void isChecked_vibrateEnabled_shouldReturnTrue() {
+ Settings.System.putInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_VIBRATE_UNLOCKED, ON);
+ assertThat(mController.isChecked()).isTrue();
+ }
+
+ @Test
+ public void isChecked_vibrateDisabled_shouldReturnFalse() {
+ Settings.System.putInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_VIBRATE_UNLOCKED, OFF);
+ assertThat(mController.isChecked()).isFalse();
+ }
+
+ @Test
+ public void setChecked_setTrue_shouldEnableVibrateSetting() {
+ Settings.System.putInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_VIBRATE_UNLOCKED, OFF);
+ mController.setChecked(true);
+ assertThat(Settings.System.getInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_VIBRATE_UNLOCKED, OFF)).isEqualTo(ON);
+ }
+
+ @Test
+ public void setChecked_setFalse_shouldDisableVibrateSetting() {
+ Settings.System.putInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_VIBRATE_UNLOCKED, ON);
+ mController.setChecked(false);
+ assertThat(Settings.System.getInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_VIBRATE_UNLOCKED, ON)).isEqualTo(OFF);
+ }
+}
diff --git a/tests/robotests/src/com/android/settings/notification/PoliteNotifWorkProfileToggleControllerTest.java b/tests/robotests/src/com/android/settings/notification/PoliteNotifWorkProfileToggleControllerTest.java
new file mode 100644
index 0000000..5cda1ea
--- /dev/null
+++ b/tests/robotests/src/com/android/settings/notification/PoliteNotifWorkProfileToggleControllerTest.java
@@ -0,0 +1,136 @@
+/*
+ * Copyright (C) 2023 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.android.settings.notification;
+
+import static com.android.settings.accessibility.AccessibilityUtil.State.OFF;
+import static com.android.settings.accessibility.AccessibilityUtil.State.ON;
+import static com.google.common.truth.Truth.assertThat;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.when;
+
+import android.content.Context;
+import android.os.UserHandle;
+import android.platform.test.flag.junit.SetFlagsRule;
+import android.provider.Settings;
+
+import com.android.server.notification.Flags;
+import com.android.settings.core.BasePreferenceController;
+import com.android.settings.testutils.shadow.ShadowSystemSettings;
+
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.robolectric.RobolectricTestRunner;
+import org.robolectric.RuntimeEnvironment;
+import org.robolectric.annotation.Config;
+
+@RunWith(RobolectricTestRunner.class)
+public class PoliteNotifWorkProfileToggleControllerTest {
+ @Rule
+ public final SetFlagsRule mSetFlagsRule = new SetFlagsRule();
+
+ private static final String PREFERENCE_KEY = "preference_key";
+
+ private Context mContext;
+ PoliteNotifWorkProfileToggleController mController;
+ @Mock
+ private AudioHelper mAudioHelper;
+
+ @Before
+ public void setUp() {
+ MockitoAnnotations.initMocks(this);
+ mContext = RuntimeEnvironment.application;
+ when(mAudioHelper.getManagedProfileId(any())).thenReturn(UserHandle.MIN_SECONDARY_USER_ID);
+ mController = new PoliteNotifWorkProfileToggleController(mContext, PREFERENCE_KEY,
+ mAudioHelper);
+ }
+
+ @Test
+ public void isAvailable_flagEnabled_workProfileExists_shouldReturnTrue() {
+ // TODO: b/291907312 - remove feature flags
+ mSetFlagsRule.enableFlags(Flags.FLAG_POLITE_NOTIFICATIONS);
+ assertThat(mController.isAvailable()).isTrue();
+ assertThat(mController.getAvailabilityStatus()).isEqualTo(
+ BasePreferenceController.AVAILABLE);
+ }
+
+ @Test
+ public void isAvailable_flagEnabled_workProfileMissing_shouldReturnFalse() {
+ // TODO: b/291907312 - remove feature flags
+ mSetFlagsRule.enableFlags(Flags.FLAG_POLITE_NOTIFICATIONS);
+ when(mAudioHelper.getManagedProfileId(any())).thenReturn(UserHandle.USER_NULL);
+ mController = new PoliteNotifWorkProfileToggleController(mContext, PREFERENCE_KEY,
+ mAudioHelper);
+ assertThat(mController.isAvailable()).isFalse();
+ assertThat(mController.getAvailabilityStatus()).isEqualTo(
+ BasePreferenceController.DISABLED_FOR_USER);
+ }
+
+ @Test
+ public void isAvailable_flagDisabled_shouldReturnFalse() {
+ // TODO: b/291907312 - remove feature flags
+ mSetFlagsRule.disableFlags(Flags.FLAG_POLITE_NOTIFICATIONS);
+ assertThat(mController.isAvailable()).isFalse();
+ assertThat(mController.getAvailabilityStatus()).isEqualTo(
+ BasePreferenceController.CONDITIONALLY_UNAVAILABLE);
+ }
+
+ @Test
+ @Config(shadows = ShadowSystemSettings.class)
+ public void isChecked_enabledForWorkProfile_shouldReturnTrue() {
+ Settings.System.putIntForUser(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ENABLED, ON,
+ UserHandle.MIN_SECONDARY_USER_ID);
+ assertThat(mController.isChecked()).isTrue();
+ }
+
+ @Test
+ @Config(shadows = ShadowSystemSettings.class)
+ public void isChecked_disabledForWorkProfile_shouldReturnFalse() {
+ Settings.System.putIntForUser(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ENABLED, OFF,
+ UserHandle.MIN_SECONDARY_USER_ID);
+ assertThat(mController.isChecked()).isFalse();
+ }
+
+ @Test
+ @Config(shadows = ShadowSystemSettings.class)
+ public void setChecked_setTrue_shouldEnablePoliteNotifForWorkProfile() {
+ Settings.System.putIntForUser(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ENABLED, OFF,
+ UserHandle.MIN_SECONDARY_USER_ID);
+ mController.setChecked(true);
+ assertThat(Settings.System.getIntForUser(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ENABLED, ON,
+ UserHandle.MIN_SECONDARY_USER_ID)).isEqualTo(ON);
+ }
+
+ @Test
+ @Config(shadows = ShadowSystemSettings.class)
+ public void setChecked_setFalse_shouldDisablePoliteNotifForWorkProfile() {
+ Settings.System.putIntForUser(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ENABLED, ON,
+ UserHandle.MIN_SECONDARY_USER_ID);
+ mController.setChecked(false);
+ assertThat(Settings.System.getIntForUser(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ENABLED, ON,
+ UserHandle.MIN_SECONDARY_USER_ID)).isEqualTo(OFF);
+ }
+}
diff --git a/tests/robotests/src/com/android/settings/notification/PoliteNotificationFilterControllerTest.java b/tests/robotests/src/com/android/settings/notification/PoliteNotificationFilterControllerTest.java
new file mode 100644
index 0000000..646e927
--- /dev/null
+++ b/tests/robotests/src/com/android/settings/notification/PoliteNotificationFilterControllerTest.java
@@ -0,0 +1,165 @@
+/*
+ * Copyright (C) 2023 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.android.settings.notification;
+
+import static com.android.settings.accessibility.AccessibilityUtil.State.OFF;
+import static com.android.settings.accessibility.AccessibilityUtil.State.ON;
+import static com.google.common.truth.Truth.assertThat;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import android.content.Context;
+import android.platform.test.flag.junit.SetFlagsRule;
+import android.provider.Settings;
+
+import androidx.preference.ListPreference;
+import androidx.preference.Preference;
+import androidx.preference.PreferenceScreen;
+
+import com.android.server.notification.Flags;
+import com.android.settings.R;
+import com.android.settings.core.BasePreferenceController;
+
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.robolectric.RobolectricTestRunner;
+import org.robolectric.RuntimeEnvironment;
+
+@RunWith(RobolectricTestRunner.class)
+public class PoliteNotificationFilterControllerTest {
+ @Rule
+ public final SetFlagsRule mSetFlagsRule = new SetFlagsRule();
+
+ private static final String PREFERENCE_KEY = "preference_key";
+ private static final int POLITE_NOTIFICATIONS_ALL = 0;
+ private static final int POLITE_NOTIFICATIONS_CONVERSATIONS = 1;
+ private static final int POLITE_NOTIFICATIONS_DISABLED = 2;
+
+ @Mock
+ private PreferenceScreen mScreen;
+
+ private PoliteNotificationFilterController mController;
+ private Preference mPreference;
+ private Context mContext;
+
+ @Before
+ public void setUp() {
+ MockitoAnnotations.initMocks(this);
+ mContext = spy(RuntimeEnvironment.application);
+
+ mController = new PoliteNotificationFilterController(mContext, PREFERENCE_KEY);
+ mPreference = new Preference(mContext);
+ mPreference.setKey(mController.getPreferenceKey());
+ when(mScreen.findPreference(mController.getPreferenceKey())).thenReturn(mPreference);
+ }
+
+ @Test
+ public void isAvailable_flagEnabled_shouldReturnTrue() {
+ // TODO: b/291907312 - remove feature flags
+ mSetFlagsRule.enableFlags(Flags.FLAG_POLITE_NOTIFICATIONS);
+ assertThat(mController.isAvailable()).isTrue();
+ assertThat(mController.getAvailabilityStatus()).isEqualTo(
+ BasePreferenceController.AVAILABLE);
+ }
+
+ @Test
+ public void isAvailable_flagDisabled_shouldReturnFalse() {
+ // TODO: b/291907312 - remove feature flags
+ mSetFlagsRule.disableFlags(Flags.FLAG_POLITE_NOTIFICATIONS);
+ assertThat(mController.isAvailable()).isFalse();
+ assertThat(mController.getAvailabilityStatus()).isEqualTo(
+ BasePreferenceController.CONDITIONALLY_UNAVAILABLE);
+ }
+
+ @Test
+ public void updateState_politeNotificationDisabled() {
+ final ListPreference preference = mock(ListPreference.class);
+ Settings.System.putInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ENABLED, OFF);
+ mController.updateState(preference);
+
+ verify(preference).setValue(Integer.toString(POLITE_NOTIFICATIONS_DISABLED));
+ assertThat(mController.getSummary().toString()).isEqualTo(
+ mContext.getString(R.string.notification_polite_disabled_summary));
+ }
+
+ @Test
+ public void updateState_politeNotificationEnabled_applyAllApps() {
+ final ListPreference preference = mock(ListPreference.class);
+ Settings.System.putInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ENABLED, ON);
+ Settings.System.putInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ALL, ON);
+ mController.updateState(preference);
+
+ verify(preference).setValue(Integer.toString(POLITE_NOTIFICATIONS_ALL));
+ assertThat(mController.getSummary().toString()).isEqualTo(
+ mContext.getString(R.string.notification_polite_all_apps_summary));
+ }
+
+ @Test
+ public void updateState_politeNotificationEnabled_applyOnlyConversations() {
+ final ListPreference preference = mock(ListPreference.class);
+ Settings.System.putInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ENABLED, ON);
+ Settings.System.putInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ALL, OFF);
+ mController.updateState(preference);
+
+ verify(preference).setValue(Integer.toString(POLITE_NOTIFICATIONS_CONVERSATIONS));
+ assertThat(mController.getSummary().toString()).isEqualTo(
+ mContext.getString(R.string.notification_polite_conversations_summary));
+ }
+
+ @Test
+ public void onPreferenceChanged_firstItemSelected_shouldEnableForAll() {
+ mController.displayPreference(mScreen);
+ mController.onPreferenceChange(mPreference, "0");
+
+ assertThat(Settings.System.getInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ENABLED, OFF)).isEqualTo(ON);
+ assertThat(Settings.System.getInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ALL, OFF)).isEqualTo(ON);
+ }
+
+ @Test
+ public void onPreferenceChanged_secondItemSelected_shouldEnableForConversationsOnly() {
+ mController.displayPreference(mScreen);
+ mController.onPreferenceChange(mPreference, "1");
+
+ assertThat(Settings.System.getInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ENABLED, OFF)).isEqualTo(ON);
+ assertThat(Settings.System.getInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ALL, OFF)).isEqualTo(OFF);
+ }
+
+ @Test
+ public void onPreferenceChanged_thirdItemSelected_shouldDisable() {
+ mController.displayPreference(mScreen);
+ mController.onPreferenceChange(mPreference, "2");
+
+ assertThat(Settings.System.getInt(mContext.getContentResolver(),
+ Settings.System.NOTIFICATION_COOLDOWN_ENABLED, OFF)).isEqualTo(OFF);
+ }
+
+}
diff --git a/tests/robotests/src/com/android/settings/notification/PoliteNotificationsPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/notification/PoliteNotificationsPreferenceControllerTest.java
new file mode 100644
index 0000000..f6c5e16
--- /dev/null
+++ b/tests/robotests/src/com/android/settings/notification/PoliteNotificationsPreferenceControllerTest.java
@@ -0,0 +1,69 @@
+/*
+ * Copyright (C) 2023 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.android.settings.notification;
+
+import static com.google.common.truth.Truth.assertThat;
+
+import android.platform.test.flag.junit.SetFlagsRule;
+
+import com.android.server.notification.Flags;
+import com.android.settings.core.BasePreferenceController;
+
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.MockitoAnnotations;
+import org.robolectric.RobolectricTestRunner;
+import org.robolectric.RuntimeEnvironment;
+
+@RunWith(RobolectricTestRunner.class)
+public class PoliteNotificationsPreferenceControllerTest {
+
+ @Rule
+ public final SetFlagsRule mSetFlagsRule = new SetFlagsRule();
+
+ private static final String PREFERENCE_KEY = "preference_key";
+
+ private PoliteNotificationsPreferenceController mController;
+
+ @Before
+ public void setUp() {
+ MockitoAnnotations.initMocks(this);
+ mController = new PoliteNotificationsPreferenceController(RuntimeEnvironment.application,
+ PREFERENCE_KEY);
+ }
+
+ @Test
+ public void isAvailable_flagEnabled_shouldReturnTrue() {
+ // TODO: b/291907312 - remove feature flags
+ mSetFlagsRule.enableFlags(Flags.FLAG_POLITE_NOTIFICATIONS);
+ assertThat(mController.isAvailable()).isTrue();
+ assertThat(mController.getAvailabilityStatus()).isEqualTo(
+ BasePreferenceController.AVAILABLE);
+ }
+
+ @Test
+ public void isAvailable_flagDisabled_shouldReturnFalse() {
+ // TODO: b/291907312 - remove feature flags
+ mSetFlagsRule.disableFlags(Flags.FLAG_POLITE_NOTIFICATIONS);
+ assertThat(mController.isAvailable()).isFalse();
+ assertThat(mController.getAvailabilityStatus()).isEqualTo(
+ BasePreferenceController.CONDITIONALLY_UNAVAILABLE);
+ }
+
+}