Suppress WiFi Assistant card until future platform updates.
This replaces the previous behavior of an increasing timeout. When the
user dismisses the WiFi Assistant card, either by opting out or
successfully configuring the assistant, the card is suppressed until
the next major platform upgrade (assuming the assistant is not enabled
at the time of the upgrade).
Bug: 16902858
Change-Id: I5373a7a743f21777b7b75a620b5a4e9004e57466
diff --git a/src/com/android/settings/wifi/WifiSettings.java b/src/com/android/settings/wifi/WifiSettings.java
index 5366d66..1503f22 100644
--- a/src/com/android/settings/wifi/WifiSettings.java
+++ b/src/com/android/settings/wifi/WifiSettings.java
@@ -41,10 +41,10 @@
import android.net.wifi.WifiInfo;
import android.net.wifi.WifiManager;
import android.net.wifi.WpsInfo;
+import android.os.Build;
import android.os.Bundle;
import android.os.Handler;
import android.os.Message;
-import android.os.Parcelable;
import android.preference.Preference;
import android.preference.PreferenceScreen;
import android.util.Log;
@@ -101,12 +101,7 @@
private static final int MENU_ID_MODIFY = Menu.FIRST + 8;
private static final int MENU_ID_WRITE_NFC = Menu.FIRST + 9;
- private static final String KEY_ASSISTANT_DISMISS_TIME = "wifi_assistant_dismiss_time";
- private static final String KEY_ASSISTANT_START_TIME = "wifi_assistant_start_time";
-
- private static final long MILI_SECONDS_30_DAYS = 30L * 24L * 60L * 60L * 1000L;
- private static final long MILI_SECONDS_90_DAYS = MILI_SECONDS_30_DAYS * 3L;
- private static final long MILI_SECONDS_180_DAYS = MILI_SECONDS_90_DAYS * 2L;
+ private static final String KEY_ASSISTANT_DISMISS_PLATFORM = "wifi_assistant_dismiss_platform";
public static final int WIFI_DIALOG_ID = 1;
/* package */ static final int WPS_PBC_DIALOG_ID = 2;
@@ -336,7 +331,7 @@
public void onActivityResult(int requestCode, int resultCode, Intent resultData) {
if (requestCode == REQUEST_ENABLE_WIFI_ASSISTANT) {
if (resultCode == Activity.RESULT_OK) {
- setWifiAssistantTimeout();
+ disableWifiAssistantCardUntilPlatformUpgrade();
getListView().removeHeaderView(mWifiAssistantCard);
mWifiAssistantApp = null;
}
@@ -720,10 +715,11 @@
}
SharedPreferences sharedPreferences = getPreferenceScreen().getSharedPreferences();
- long lastTimeoutEndTime = sharedPreferences.getLong(KEY_ASSISTANT_START_TIME, 0);
- long dismissTime = sharedPreferences.getLong(KEY_ASSISTANT_DISMISS_TIME, 0);
+ int lastDismissPlatform = sharedPreferences.getInt(KEY_ASSISTANT_DISMISS_PLATFORM, 0);
- if ((System.currentTimeMillis() - lastTimeoutEndTime) <= dismissTime) {
+ if (Build.VERSION.SDK_INT <= lastDismissPlatform) {
+ // User has dismissed the Wi-Fi assistant card on this SDK release. Suppress the card
+ // until the next major platform upgrade.
return;
}
@@ -761,7 +757,7 @@
noThanks.setOnClickListener(new OnClickListener() {
@Override
public void onClick(View v) {
- setWifiAssistantTimeout();
+ disableWifiAssistantCardUntilPlatformUpgrade();
getListView().removeHeaderView(mWifiAssistantCard);
mWifiAssistantApp = null;
}
@@ -770,23 +766,10 @@
}
}
- private void setWifiAssistantTimeout() {
+ private void disableWifiAssistantCardUntilPlatformUpgrade() {
SharedPreferences sharedPreferences = getPreferenceScreen().getSharedPreferences();
SharedPreferences.Editor editor = sharedPreferences.edit();
- long dismissTime = sharedPreferences.getLong(KEY_ASSISTANT_DISMISS_TIME, 0);
-
- if (dismissTime == 0) {
- dismissTime = MILI_SECONDS_30_DAYS;
- } else if (dismissTime == MILI_SECONDS_30_DAYS) {
- dismissTime = MILI_SECONDS_90_DAYS;
- } else if (dismissTime == MILI_SECONDS_90_DAYS) {
- dismissTime = MILI_SECONDS_180_DAYS;
- } else if (dismissTime == MILI_SECONDS_180_DAYS) {
- dismissTime = java.lang.Long.MAX_VALUE;
- }
-
- editor.putLong(KEY_ASSISTANT_DISMISS_TIME, dismissTime);
- editor.putLong(KEY_ASSISTANT_START_TIME, System.currentTimeMillis());
+ editor.putLong(KEY_ASSISTANT_DISMISS_PLATFORM, Build.VERSION.SDK_INT);
editor.apply();
}