Always use Spp to generate SettingsPage in Settings
Bug: 244122804
Test: Manually with Settings
Change-Id: I3625d34abcdfd3f7264e20e94043769f1f9ed699
diff --git a/src/com/android/settings/spa/app/AllAppList.kt b/src/com/android/settings/spa/app/AllAppList.kt
index 08b06a6..d357299 100644
--- a/src/com/android/settings/spa/app/AllAppList.kt
+++ b/src/com/android/settings/spa/app/AllAppList.kt
@@ -27,8 +27,8 @@
import com.android.settings.R
import com.android.settings.spa.app.appinfo.AppInfoSettingsProvider
import com.android.settingslib.spa.framework.common.SettingsEntryBuilder
-import com.android.settingslib.spa.framework.common.SettingsPage
import com.android.settingslib.spa.framework.common.SettingsPageProvider
+import com.android.settingslib.spa.framework.common.createSettingsPage
import com.android.settingslib.spa.framework.compose.navigator
import com.android.settingslib.spa.framework.compose.rememberContext
import com.android.settingslib.spa.framework.util.filterItem
@@ -48,6 +48,7 @@
object AllAppListPageProvider : SettingsPageProvider {
override val name = "AllAppList"
+ private val owner = createSettingsPage()
@Composable
override fun Page(arguments: Bundle?) {
@@ -55,7 +56,7 @@
}
fun buildInjectEntry() = SettingsEntryBuilder
- .createInject(owner = SettingsPage.create(name))
+ .createInject(owner)
.setSearchDataFn { null }
.setUiLayoutFn {
Preference(object : PreferenceModel {
diff --git a/src/com/android/settings/spa/app/backgroundinstall/BackgroundInstalledAppsPageProvider.kt b/src/com/android/settings/spa/app/backgroundinstall/BackgroundInstalledAppsPageProvider.kt
index a6b10dd..6e0643b 100644
--- a/src/com/android/settings/spa/app/backgroundinstall/BackgroundInstalledAppsPageProvider.kt
+++ b/src/com/android/settings/spa/app/backgroundinstall/BackgroundInstalledAppsPageProvider.kt
@@ -40,8 +40,8 @@
import com.android.settings.spa.app.appinfo.AppInfoSettingsProvider
import com.android.settings.spa.app.startUninstallActivity
import com.android.settingslib.spa.framework.common.SettingsEntryBuilder
-import com.android.settingslib.spa.framework.common.SettingsPage
import com.android.settingslib.spa.framework.common.SettingsPageProvider
+import com.android.settingslib.spa.framework.common.createSettingsPage
import com.android.settingslib.spa.framework.compose.navigator
import com.android.settingslib.spa.framework.compose.rememberContext
import com.android.settingslib.spa.framework.theme.SettingsDimension
@@ -74,6 +74,7 @@
object BackgroundInstalledAppsPageProvider : SettingsPageProvider {
override val name = "BackgroundInstalledAppsPage"
+ private val owner = createSettingsPage()
private var backgroundInstallService = IBackgroundInstallControlService.Stub.asInterface(
ServiceManager.getService(Context.BACKGROUND_INSTALL_CONTROL_SERVICE))
private var featureIsDisabled = featureIsDisabled()
@@ -95,7 +96,7 @@
}
fun buildInjectEntry() = SettingsEntryBuilder
- .createInject(owner = SettingsPage.create(name))
+ .createInject(owner)
.setSearchDataFn { null }
.setUiLayoutFn { EntryItem() }
diff --git a/src/com/android/settings/spa/app/specialaccess/SpecialAppAccess.kt b/src/com/android/settings/spa/app/specialaccess/SpecialAppAccess.kt
index 5b9205a..264376c 100644
--- a/src/com/android/settings/spa/app/specialaccess/SpecialAppAccess.kt
+++ b/src/com/android/settings/spa/app/specialaccess/SpecialAppAccess.kt
@@ -22,8 +22,8 @@
import com.android.settings.R
import com.android.settingslib.spa.framework.common.SettingsEntry
import com.android.settingslib.spa.framework.common.SettingsEntryBuilder
-import com.android.settingslib.spa.framework.common.SettingsPage
import com.android.settingslib.spa.framework.common.SettingsPageProvider
+import com.android.settingslib.spa.framework.common.createSettingsPage
import com.android.settingslib.spa.framework.compose.navigator
import com.android.settingslib.spa.widget.preference.Preference
import com.android.settingslib.spa.widget.preference.PreferenceModel
@@ -31,6 +31,7 @@
object SpecialAppAccessPageProvider : SettingsPageProvider {
override val name = "SpecialAppAccess"
+ private val owner = createSettingsPage()
@Composable
override fun Page(arguments: Bundle?) {
@@ -51,10 +52,9 @@
)
}
- fun buildInjectEntry() = SettingsEntryBuilder.createInject(owner = SettingsPage.create(name))
+ fun buildInjectEntry() = SettingsEntryBuilder.createInject(owner)
override fun buildEntry(arguments: Bundle?): List<SettingsEntry> {
- val owner = SettingsPage.create(name, parameter = parameter, arguments = arguments)
return listOf(
AllFilesAccessAppListProvider,
DisplayOverOtherAppsAppListProvider,