commit 8040f4c59f5f1dbc5dc5182b33ce1cdc6b2388ab
author Arc Wang <arcwang@google.com> Fri Mar 22 05:36:59 2019 +0000
committer Arc Wang <arcwang@google.com> Fri Mar 22 05:36:59 2019 +0000
tree 8f09ec6b0317bdb4a687903da0be140726b2e2cd
parent 890f3a4340b2cbbe1e82337005383f7a33ddd948

Revert "Add divider line in Preference for scan QR code button and share hotspot button"

This reverts commit 890f3a4340b2cbbe1e82337005383f7a33ddd948.

Reason for revert: I find a UI defect in this fix.

Change-Id: Icdbb1d2b5319636b8c4c54bcdc0fc3562585a15a

res/layout/preference.xml

diff --git a/res/layout/preference.xml b/res/layout/preference.xml
index db96139..195671b 100644
--- a/res/layout/preference.xml
+++ b/res/layout/preference.xml
@@ -54,10 +54,6 @@
 
     </RelativeLayout>
 
-    <include
-        layout="@layout/preference_two_target_divider"
-        android:visibility="gone"/>
-
     <LinearLayout
         android:id="@android:id/widget_frame"
         android:layout_width="wrap_content"

src/com/android/settings/wifi/AddWifiNetworkPreference.java

diff --git a/src/com/android/settings/wifi/AddWifiNetworkPreference.java b/src/com/android/settings/wifi/AddWifiNetworkPreference.java
index e49f2ab..cd2e4a8 100644
--- a/src/com/android/settings/wifi/AddWifiNetworkPreference.java
+++ b/src/com/android/settings/wifi/AddWifiNetworkPreference.java
@@ -20,6 +20,7 @@
 import android.content.res.Resources;
 import android.graphics.drawable.Drawable;
 import android.util.Log;
+import android.view.View;
 import android.widget.ImageButton;
 
 import androidx.annotation.DrawableRes;
@@ -62,6 +63,10 @@
                 getContext().startActivity(
                     WifiDppUtils.getEnrolleeQrCodeScannerIntent(/* ssid */ null));
             });
+
+            final View divider = (View) holder.findViewById(
+                    com.android.settingslib.R.id.two_target_divider);
+            divider.setVisibility(View.INVISIBLE);
         }
     }
 

src/com/android/settings/wifi/tether/WifiTetherSsidPreference.java

diff --git a/src/com/android/settings/wifi/tether/WifiTetherSsidPreference.java b/src/com/android/settings/wifi/tether/WifiTetherSsidPreference.java
index e2566d0..64014d9 100644
--- a/src/com/android/settings/wifi/tether/WifiTetherSsidPreference.java
+++ b/src/com/android/settings/wifi/tether/WifiTetherSsidPreference.java
@@ -39,7 +39,6 @@
 
     private ImageButton mImageButton;
     private Drawable mButtonIcon;
-    private View mDivider;
     private View.OnClickListener mClickListener;
     private boolean mVisible;
 
@@ -69,8 +68,6 @@
     }
 
     private void initialize() {
-        // TODO(b/129019971): use methods of divider line in parent object
-        setLayoutResource(R.layout.preference);
         setWidgetLayoutResource(R.layout.wifi_button_preference_widget);
     }
 
@@ -85,17 +82,13 @@
                     getContext().getString(R.string.wifi_dpp_share_hotspot));
             setButtonIcon(R.drawable.ic_qrcode_24dp);
             mImageButton.setImageDrawable(mButtonIcon);
-
-            mDivider = holder.findViewById(R.id.two_target_divider);
         }
 
         if (mVisible) {
             mImageButton.setOnClickListener(mClickListener);
             mImageButton.setVisibility(View.VISIBLE);
-            mDivider.setVisibility(View.VISIBLE);
         } else {
             mImageButton.setVisibility(View.GONE);
-            mDivider.setVisibility(View.GONE);
         }
     }