commit 7ce7c40dac0fa8d27b28b82084d3c3fe7f2f524f
author Fabrice Di Meglio <fdimeglio@google.com> Mon Feb 10 17:11:10 2014 -0800
committer Fabrice Di Meglio <fdimeglio@google.com> Tue Feb 11 13:31:39 2014 -0800
tree 07cf1905aa6eac31e3441dd3ba8f05734c9fbe5e
parent ef2b359b48c10d94fa70d73d517018d1fb6e1867

Fix bug #12957228 Java crash in com.android.settings: java.lang.IllegalStateException:
...Can not perform this action after onSaveInstanceState

- prevent a click on the Drawer's Headers when the App is paused / finished
- register / unregister the DrawerListener when needed

Change-Id: Ia270ef27b23c66d55565bbb73d4f6a6531b742d2

src/com/android/settings/SettingsActivity.java

diff --git a/src/com/android/settings/SettingsActivity.java b/src/com/android/settings/SettingsActivity.java
index af0d8bb..c8e4d3f 100644
--- a/src/com/android/settings/SettingsActivity.java
+++ b/src/com/android/settings/SettingsActivity.java
@@ -382,6 +382,8 @@
         @Override
         public void onDrawerClosed(View drawerView) {
             mDrawerToggle.onDrawerClosed(drawerView);
+            // Cannot process clicks when the App is finishing
+            if (isFinishing()) return;
             onHeaderClick(mCurrentHeader);
         }
 
@@ -512,7 +514,6 @@
             mActionBar.setHomeButtonEnabled(true);
 
             mDrawerLayout = (DrawerLayout) findViewById(R.id.drawer_layout);
-            mDrawerLayout.setDrawerListener(new DrawerListener());
 
             mDrawer = (ListView) findViewById(R.id.headers_drawer);
             mDrawer.setAdapter(mHeaderAdapter);
@@ -705,12 +706,16 @@
         invalidateHeaders();
 
         registerReceiver(mBatteryInfoReceiver, new IntentFilter(Intent.ACTION_BATTERY_CHANGED));
+
+        mDrawerLayout.setDrawerListener(new DrawerListener());
     }
 
     @Override
     public void onPause() {
         super.onPause();
 
+        mDrawerLayout.setDrawerListener(null);
+
         unregisterReceiver(mBatteryInfoReceiver);
 
         mHeaderAdapter.pause();