commit 7a8d2f448685b974b77525722021b50d69b5778a
author Wesley.CW Wang <wesleycwwang@google.com> Tue May 11 13:10:39 2021 +0800
committer Wesley.CW Wang <wesleycwwang@google.com> Tue May 11 13:21:38 2021 +0800
tree d7f5dc85a3840b342f29c6c309111d112471997a
parent 7a678f29b25e868b839be3253a1d98597452b524

Fix color check error

Bug: 187772407
Test: make SettingsRoboTests; repo upload
Change-Id: Ia1c89864043d201e8c7a180c9087a56e6f4ca235

color-check-baseline.xml

diff --git a/color-check-baseline.xml b/color-check-baseline.xml
index 0c61a47..9fde1b8 100644
--- a/color-check-baseline.xml
+++ b/color-check-baseline.xml
@@ -4221,4 +4221,36 @@
             column="5"/>
     </issue>
 
+    <issue
+        id="HardCodedColor"
+        severity="Error"
+        message="Avoid using hardcoded color"
+        category="Correctness"
+        priority="4"
+        summary="Using hardcoded color"
+        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
+        errorLine1="        android:fillColor=&quot;@color/battery_good_color_light&quot;"
+        errorLine2="        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="res/drawable/ic_battery_status_good_24dp.xml"
+            line="22"
+            column="9"/>
+    </issue>
+
+    <issue
+        id="HardCodedColor"
+        severity="Error"
+        message="Avoid using hardcoded color"
+        category="Correctness"
+        priority="4"
+        summary="Using hardcoded color"
+        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
+        errorLine1="        android:fillColor=&quot;@color/battery_good_color_light&quot;"
+        errorLine2="        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="res/drawable/ic_battery_status_good_24dp.xml"
+            line="25"
+            column="9"/>
+    </issue>
+
 </issues>