commit 6423c4cd51b36e06b77aa03fc5754810132b114b
author Alexey Kuzmin <alexeykuzmin@google.com> Wed Jan 23 18:23:45 2019 +0000
committer wilsonshih <wilsonshih@google.com> Tue Feb 26 12:51:49 2019 +0800
tree 03587b3e668e0a505cddcde6e12a7f80dc4605d5
parent 962cbf424c4d09a1741ace941e92ae8a6fbfa469

Update vibrator on/off status from accessibility settings menu

Fix ringing and touch vibration cannot be turned off from accessibility
settings menu.

Bug: 116172311
Fix: 125618621
Test: Open Settings=>Accessibility=>Vibration, change every sub-item and
verify the change can synced with main page, also check the settings can
synced with Sounds.
Test: m -j RunSettingsRoboTests

Change-Id: I7a10bcda17323bce612e199bdf067363b8f9a332

src/com/android/settings/accessibility/VibrationPreferenceFragment.java

diff --git a/src/com/android/settings/accessibility/VibrationPreferenceFragment.java b/src/com/android/settings/accessibility/VibrationPreferenceFragment.java
index 648acad..5261daa 100644
--- a/src/com/android/settings/accessibility/VibrationPreferenceFragment.java
+++ b/src/com/android/settings/accessibility/VibrationPreferenceFragment.java
@@ -106,6 +106,31 @@
         }
     }
 
+    private boolean hasVibrationEnabledSetting() {
+        return !TextUtils.isEmpty(getVibrationEnabledSetting());
+    }
+
+    private void updateSettings(VibrationIntensityCandidateInfo candidate) {
+        boolean vibrationEnabled = candidate.getIntensity() != Vibrator.VIBRATION_INTENSITY_OFF;
+        if (hasVibrationEnabledSetting()) {
+            // Update vibration enabled setting
+            boolean wasEnabled = Settings.System.getInt(getContext().getContentResolver(),
+                    getVibrationEnabledSetting(), 1) == 1;
+            if (vibrationEnabled != wasEnabled) {
+                Settings.System.putInt(getContext().getContentResolver(),
+                    getVibrationEnabledSetting(), vibrationEnabled ? 1 : 0);
+            }
+        }
+        // There are two conditions that need to change the intensity.
+        // First: Vibration is enabled and we are changing its strength.
+        // Second: There is no setting to enable this vibration, change the intensity directly.
+        if (vibrationEnabled || !hasVibrationEnabledSetting()) {
+            // Update vibration intensity setting
+            Settings.System.putInt(getContext().getContentResolver(),
+                    getVibrationIntensitySetting(), candidate.getIntensity());
+        }
+    }
+
     @Override
     public void onDetach() {
         super.onDetach();
@@ -185,11 +210,7 @@
             Log.e(TAG, "Tried to set unknown intensity (key=" + key + ")!");
             return false;
         }
-        if (candidate.getIntensity() != Vibrator.VIBRATION_INTENSITY_OFF ||
-                TextUtils.isEmpty(getVibrationEnabledSetting())) {
-            Settings.System.putInt(getContext().getContentResolver(),
-                    getVibrationIntensitySetting(), candidate.getIntensity());
-        }
+        updateSettings(candidate);
         onVibrationIntensitySelected(candidate.getIntensity());
         return true;
     }