commit 61cc95f7d1d9aada055db0b0f8f703b2948427ff
author Treehugger Robot <treehugger-gerrit@google.com> Thu Oct 13 15:19:20 2022 +0000
committer Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> Thu Oct 13 15:19:20 2022 +0000
tree 4e5fa99e5b111ad7eba83444dbdffe3736147aac
parent 8b2496eb9e8c7eecff09d07d1c6bdb7f5a7f5a29
parent c0904055f4efeacc026a0e62c473c7e8582461b9

Merge "Fix "show system apps" status lost when switching on/off dark theme" am: df8e9c630a am: c0904055f4

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2253577

Change-Id: If5a0b0e899b0eea3110319c7df89bb23f932e77e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

src/com/android/settings/datausage/UnrestrictedDataAccess.java

diff --git a/src/com/android/settings/datausage/UnrestrictedDataAccess.java b/src/com/android/settings/datausage/UnrestrictedDataAccess.java
index 319ab6f..05c1132 100644
--- a/src/com/android/settings/datausage/UnrestrictedDataAccess.java
+++ b/src/com/android/settings/datausage/UnrestrictedDataAccess.java
@@ -27,7 +27,6 @@
 import com.android.settings.search.BaseSearchIndexProvider;
 import com.android.settingslib.applications.AppIconCacheManager;
 import com.android.settingslib.applications.ApplicationsState;
-import com.android.settingslib.applications.ApplicationsState.AppFilter;
 import com.android.settingslib.search.SearchIndexable;
 
 @SearchIndexable
@@ -39,14 +38,15 @@
     private static final String EXTRA_SHOW_SYSTEM = "show_system";
 
     private boolean mShowSystem;
-    private AppFilter mFilter;
 
     @Override
     public void onCreate(Bundle icicle) {
         super.onCreate(icicle);
         mShowSystem = icicle != null && icicle.getBoolean(EXTRA_SHOW_SYSTEM);
-
-        use(UnrestrictedDataAccessPreferenceController.class).setParentFragment(this);
+        use(UnrestrictedDataAccessPreferenceController.class).setFilter(
+                mShowSystem ? ApplicationsState.FILTER_ALL_ENABLED
+                        : ApplicationsState.FILTER_DOWNLOADED_AND_LAUNCHER);
+        use(UnrestrictedDataAccessPreferenceController.class).setSession(getSettingsLifecycle());
     }
 
     @Override
@@ -58,17 +58,14 @@
 
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
-        switch (item.getItemId()) {
-            case MENU_SHOW_SYSTEM:
-                mShowSystem = !mShowSystem;
-                item.setTitle(mShowSystem ? R.string.menu_hide_system : R.string.menu_show_system);
-                mFilter = mShowSystem ? ApplicationsState.FILTER_ALL_ENABLED
-                        : ApplicationsState.FILTER_DOWNLOADED_AND_LAUNCHER;
-
-                use(UnrestrictedDataAccessPreferenceController.class).setFilter(mFilter);
-                use(UnrestrictedDataAccessPreferenceController.class).rebuild();
-
-                break;
+        if (item.getItemId() == MENU_SHOW_SYSTEM) {
+            mShowSystem = !mShowSystem;
+            item.setTitle(mShowSystem ? R.string.menu_hide_system : R.string.menu_show_system);
+            use(UnrestrictedDataAccessPreferenceController.class).setFilter(
+                    mShowSystem ? ApplicationsState.FILTER_ALL_ENABLED
+                            : ApplicationsState.FILTER_DOWNLOADED_AND_LAUNCHER);
+            use(UnrestrictedDataAccessPreferenceController.class).rebuild();
+            return true;
         }
         return super.onOptionsItemSelected(item);
     }
@@ -80,17 +77,9 @@
     }
 
     @Override
-    public void onViewCreated(View view, Bundle savedInstanceState) {
-        super.onViewCreated(view, savedInstanceState);
-    }
-
-    @Override
     public void onAttach(Context context) {
         super.onAttach(context);
-        mFilter = mShowSystem ? ApplicationsState.FILTER_ALL_ENABLED
-                : ApplicationsState.FILTER_DOWNLOADED_AND_LAUNCHER;
-        use(UnrestrictedDataAccessPreferenceController.class).setSession(getSettingsLifecycle());
-        use(UnrestrictedDataAccessPreferenceController.class).setFilter(mFilter);
+        use(UnrestrictedDataAccessPreferenceController.class).setParentFragment(this);
     }
 
     @Override