Merge "Fix of Settings application sort crash"
diff --git a/res/values/arrays.xml b/res/values/arrays.xml
index 14e1fc8..88c8323 100644
--- a/res/values/arrays.xml
+++ b/res/values/arrays.xml
@@ -298,12 +298,10 @@
<!-- Wi-Fi AP settings. The type of security a Wi-Fi AP supports. -->
<!-- Note that adding/removing/moving the items will need wifi settings code change. -->
- <string-array name="wifi_ap_security" translatable="false">
- <item>Open</item>
- <!-- Do not translate. -->
- <item>WPA PSK</item>
- <!-- Do not translate. -->
- <item>WPA2 PSK</item>
+ <string-array name="wifi_ap_security">
+ <item>@string/wifi_security_none</item>
+ <item>@string/wifi_security_wpa</item>
+ <item>@string/wifi_security_wpa2</item>
</string-array>
<!-- Match this with the constants in WifiDialog. --> <skip />
diff --git a/src/com/android/settings/BatteryInfo.java b/src/com/android/settings/BatteryInfo.java
index ccad236..3f88277 100644
--- a/src/com/android/settings/BatteryInfo.java
+++ b/src/com/android/settings/BatteryInfo.java
@@ -63,11 +63,12 @@
/**
* Format a number of tenths-units as a decimal string without using a
- * conversion to float. E.g. 347 -> "34.7"
+ * conversion to float. E.g. 347 -> "34.7", -99 -> "-9.9"
*/
private final String tenthsToFixedString(int x) {
int tens = x / 10;
- return Integer.toString(tens) + "." + (x - 10 * tens);
+ // use Math.abs to avoid "-9.-9" about -99
+ return Integer.toString(tens) + "." + Math.abs(x - 10 * tens);
}
/**
diff --git a/src/com/android/settings/deviceinfo/MiscFilesHandler.java b/src/com/android/settings/deviceinfo/MiscFilesHandler.java
index 1e0cc46..93e352b 100644
--- a/src/com/android/settings/deviceinfo/MiscFilesHandler.java
+++ b/src/com/android/settings/deviceinfo/MiscFilesHandler.java
@@ -144,8 +144,8 @@
// Returns true if all deletions were successful.
// If a deletion fails, the method stops attempting to delete and returns false.
private boolean deleteDir(File dir) {
- if (dir.isDirectory()) {
- String[] children = dir.list();
+ String[] children = dir.list();
+ if (children != null) {
for (int i=0; i < children.length; i++) {
boolean success = deleteDir(new File(dir, children[i]));
if (!success) {
@@ -283,4 +283,4 @@
return view;
}
}
-}
\ No newline at end of file
+}
diff --git a/src/com/android/settings/wifi/WifiConfigInfo.java b/src/com/android/settings/wifi/WifiConfigInfo.java
index 2ed4f02..9b680a8 100644
--- a/src/com/android/settings/wifi/WifiConfigInfo.java
+++ b/src/com/android/settings/wifi/WifiConfigInfo.java
@@ -31,15 +31,9 @@
*/
public class WifiConfigInfo extends Activity {
- private static final String TAG = "WifiConfigInfo";
-
private TextView mConfigList;
private WifiManager mWifiManager;
- //============================
- // Activity lifecycle
- //============================
-
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
@@ -52,12 +46,16 @@
@Override
protected void onResume() {
super.onResume();
- final List<WifiConfiguration> wifiConfigs = mWifiManager.getConfiguredNetworks();
- StringBuffer configList = new StringBuffer();
- for (int i = wifiConfigs.size() - 1; i >= 0; i--) {
- configList.append(wifiConfigs.get(i));
+ if (mWifiManager.isWifiEnabled()) {
+ final List<WifiConfiguration> wifiConfigs = mWifiManager.getConfiguredNetworks();
+ StringBuffer configList = new StringBuffer();
+ for (int i = wifiConfigs.size() - 1; i >= 0; i--) {
+ configList.append(wifiConfigs.get(i));
+ }
+ mConfigList.setText(configList);
+ } else {
+ mConfigList.setText(R.string.wifi_state_disabled);
}
- mConfigList.setText(configList);
}
}