Merge "Handle multi-user in notif log"
diff --git a/AndroidManifest.xml b/AndroidManifest.xml
index d0a2c05..e236177 100644
--- a/AndroidManifest.xml
+++ b/AndroidManifest.xml
@@ -2103,12 +2103,6 @@
<action android:name="android.settings.CAST_SETTINGS" />
<category android:name="android.intent.category.DEFAULT" />
</intent-filter>
- <intent-filter>
- <action android:name="com.android.settings.action.SETTINGS"/>
- </intent-filter>
- <meta-data android:name="com.android.settings.order" android:value="-6"/>
- <meta-data android:name="com.android.settings.category"
- android:value="com.android.settings.category.ia.device" />
<meta-data android:name="com.android.settings.FRAGMENT_CLASS"
android:value="com.android.settings.wfd.WifiDisplaySettings" />
</activity>
@@ -2376,6 +2370,8 @@
<meta-data android:name="com.android.settings.order" android:value="-45"/>
<meta-data android:name="com.android.settings.category"
android:value="com.android.settings.category.ia.system" />
+ <meta-data android:name="com.android.settings.summary_uri"
+ android:value="content://com.android.settings.dashboard.SummaryProvider/user" />
<meta-data android:name="com.android.settings.FRAGMENT_CLASS"
android:value="com.android.settings.users.UserSettings" />
<meta-data android:name="com.android.settings.PRIMARY_PROFILE_CONTROLLED"
@@ -2522,14 +2518,6 @@
<action android:name="android.intent.action.MAIN" />
<category android:name="com.android.settings.SHORTCUT" />
</intent-filter>
- <intent-filter>
- <action android:name="com.android.settings.action.SETTINGS"/>
- </intent-filter>
- <meta-data android:name="com.android.settings.order" android:value="-440"/>
- <meta-data android:name="com.android.settings.category"
- android:value="com.android.settings.category.ia.apps"/>
- <meta-data android:name="com.android.settings.summary"
- android:resource="@string/summary_empty"/>
<meta-data android:name="com.android.settings.FRAGMENT_CLASS"
android:value="com.android.settings.notification.ConfigureNotificationSettings" />
<meta-data android:name="com.android.settings.PRIMARY_PROFILE_CONTROLLED"
@@ -2895,9 +2883,8 @@
</activity-alias>
<provider
- android:name=".backup.BackupSettingsContentProvider"
- android:authorities="com.android.settings.backup.BackupSettingsContentProvider"
- android:exported="true">
+ android:name=".dashboard.SummaryProvider"
+ android:authorities="com.android.settings.dashboard.SummaryProvider">
</provider>
<activity android:name=".backup.UserBackupSettingsActivity"
@@ -2916,7 +2903,7 @@
<meta-data android:name="com.android.settings.category"
android:value="com.android.settings.category.ia.system" />
<meta-data android:name="com.android.settings.summary_uri"
- android:value="content://com.android.settings.backup.BackupSettingsContentProvider/summary" />
+ android:value="content://com.android.settings.dashboard.SummaryProvider/backup" />
<meta-data android:name="com.android.settings.order" android:value="-60"/>
</activity>
diff --git a/res/layout-land/nfc_payment_empty.xml b/res/layout-land/nfc_payment_empty.xml
new file mode 100644
index 0000000..842792c
--- /dev/null
+++ b/res/layout-land/nfc_payment_empty.xml
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright (C) 2019 The Android Open Source Project
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:layout_gravity="center"
+ android:gravity="center"
+ android:orientation="horizontal">
+ <ImageView
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:gravity="center_vertical|right"
+ android:src="@drawable/tapandpay_emptystate"/>
+ <TextView
+ android:layout_width="264dp"
+ android:layout_height="wrap_content"
+ android:gravity="center"
+ android:paddingStart="36dp"
+ android:textAppearance="?android:attr/textAppearanceLarge"
+ android:textColor="?android:attr/textColorSecondary"
+ android:text="@string/nfc_payment_no_apps"/>
+</LinearLayout>
diff --git a/res/layout/data_usage_bytes_editor.xml b/res/layout/data_usage_bytes_editor.xml
index 2878c3e..a72352d 100644
--- a/res/layout/data_usage_bytes_editor.xml
+++ b/res/layout/data_usage_bytes_editor.xml
@@ -28,6 +28,7 @@
android:layout_height="wrap_content"
android:layout_weight="1"
android:minWidth="48dip"
+ android:minHeight="48dp"
android:layout_gravity="center_vertical"
android:focusable="true"
android:focusableInTouchMode="true"
@@ -36,7 +37,7 @@
<Spinner
android:id="@+id/size_spinner"
android:layout_width="wrap_content"
- android:layout_height="wrap_content"
+ android:layout_height="match_parent"
android:layout_gravity="center_vertical"
android:entries="@array/bytes_picker_sizes" />
diff --git a/res/layout/device_admin_add.xml b/res/layout/device_admin_add.xml
index 29d7b53..7fdcd8d 100644
--- a/res/layout/device_admin_add.xml
+++ b/res/layout/device_admin_add.xml
@@ -86,13 +86,16 @@
android:orientation="horizontal"
android:gravity="center_vertical">
- <ImageView android:id="@+id/add_msg_expander"
+ <ImageView
+ android:id="@+id/add_msg_expander"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
+ android:importantForAccessibility="no"
android:gravity="center_vertical"
android:contentDescription="@null" />
- <TextView android:id="@+id/add_msg"
+ <TextView
+ android:id="@+id/add_msg"
android:layout_width="fill_parent"
android:layout_height="wrap_content"
android:gravity="center_vertical"
diff --git a/res/layout/notif_importance_preference.xml b/res/layout/notif_importance_preference.xml
index 44c135b..edc2bb1 100644
--- a/res/layout/notif_importance_preference.xml
+++ b/res/layout/notif_importance_preference.xml
@@ -67,7 +67,7 @@
android:visibility="gone" />
</com.android.settings.notification.NotificationButtonRelativeLayout>
- <RelativeLayout
+ <com.android.settings.notification.NotificationButtonRelativeLayout
android:id="@+id/silence"
android:layout_width="match_parent"
android:layout_height="wrap_content"
@@ -109,6 +109,6 @@
android:layout_below="@id/silence_icon"
android:textAppearance="@style/TextAppearance.NotificationImportanceDetail"
android:visibility="gone" />
- </RelativeLayout>
+ </com.android.settings.notification.NotificationButtonRelativeLayout>
</LinearLayout>
\ No newline at end of file
diff --git a/res/layout/trusted_credential_list_container.xml b/res/layout/trusted_credential_list_container.xml
index aca0bc8..42dbfd9 100644
--- a/res/layout/trusted_credential_list_container.xml
+++ b/res/layout/trusted_credential_list_container.xml
@@ -16,6 +16,8 @@
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="match_parent"
+ android:clipToPadding="true"
+ android:clipChildren="true"
android:orientation="vertical">
<LinearLayout
android:id="@+id/header_view"
diff --git a/res/values/arrays.xml b/res/values/arrays.xml
index 45b9274..c9460dd 100644
--- a/res/values/arrays.xml
+++ b/res/values/arrays.xml
@@ -1252,6 +1252,17 @@
<item>LTE/TDSCDMA/GSM/WCDMA</item>
<item>TDSCDMA/CDMA/EVDO/GSM/WCDMA </item>
<item>LTE/TDSCDMA/CDMA/EVDO/GSM/WCDMA</item>
+ <item>NR only</item>
+ <item>NR/LTE</item>
+ <item>NR/LTE/CDME/EvDo</item>
+ <item>NR/LTE/GSM/WCDMA</item>
+ <item>NR/LTE/CDMA/EvDo/GSM/WCDMA</item>
+ <item>NR/LTE/WCDMA</item>
+ <item>NR/LTE/TDSCDMA</item>
+ <item>NR/LTE/TDSCDMA/GSM</item>
+ <item>NR/LTE/TDSCDMA/WCDMA</item>
+ <item>NR/LTE/TDSCDMA/GSM/WCDMA</item>
+ <item>NR/LTE/TDSCDMA/CDMA/EvDo/GSM/WCDMA</item>
</string-array>
<!-- The preferred network modes RIL constants, in order of the modes above,
e.g. the choice "GSM/WCDMA preferred" has the corresponding value "0" -->
@@ -1279,6 +1290,17 @@
<item>"20"</item>
<item>"21"</item>
<item>"22"</item>
+ <item>"23"</item>
+ <item>"24"</item>
+ <item>"25"</item>
+ <item>"26"</item>
+ <item>"27"</item>
+ <item>"28"</item>
+ <item>"29"</item>
+ <item>"30"</item>
+ <item>"31"</item>
+ <item>"32"</item>
+ <item>"33"</item>
</string-array>
<!-- Choices for CDMA subscription-->
diff --git a/res/values/strings.xml b/res/values/strings.xml
index c083852..0c7825f 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -2370,8 +2370,10 @@
<string name="wifi_advanced_titlebar">Advanced Wi\u2011Fi</string>
<!-- Wi-Fi settings screen, advanced, title of the item to show the Wi-Fi device's SSID. [CHAR LIMIT=20] -->
<string name="wifi_advanced_ssid_title">SSID</string>
- <!-- Wi-Fi settings screen, advanced, title of the item to show the Wi-Fi device's MAC address. -->
- <string name="wifi_advanced_mac_address_title">MAC address</string>
+ <!-- Wi-Fi settings screen, advanced, title of the item to show the factory's Wi-Fi MAC address. [CHAR LIMIT=30] -->
+ <string name="wifi_advanced_factory_mac_address_title">Factory MAC address</string>
+ <!-- Wi-Fi settings screen, advanced, title of the item to show the randomized Wi-Fi MAC address. [CHAR LIMIT=30] -->
+ <string name="wifi_advanced_randomized_mac_address_title">Randomized MAC address</string>
<!-- Title of the screen to adjust IP settings -->
<!-- Wi-Fi settings screen, advanced, title of the item to show the Wi-Fi device's current IP address. -->
<string name="wifi_advanced_ip_address_title">IP address</string>
@@ -3137,6 +3139,8 @@
<string name="storage_settings_summary" product="default">Unmount SD card, view available storage</string>
<!-- About phone screen, title for IMEI for multi-sim devices -->
<string name="imei_multi_sim">IMEI (sim slot %1$d)</string>
+ <!-- About phone screen, summary of the MAC address [CHAR LIMIT=80] -->
+ <string name="view_saved_network">To view, choose saved network</string>
<!-- Do not translate. About phone, status item title -->
<string name="status_imei">IMEI</string>
<!-- Do not translate. About phone, status item title -->
@@ -3195,6 +3199,8 @@
<string name="status_operator">Network</string>
<!-- About phone, status item title. The MAC address of the Wi-Fi network adapter. -->
<string name="status_wifi_mac_address">Wi\u2011Fi MAC address</string>
+ <!-- About phone, status item title. The Factory MAC address of the Wi-Fi network adapter. [CHAR LIMIT=30] -->
+ <string name="status_factory_wifi_mac_address">Factory Wi\u2011Fi MAC address</string>
<!-- About phone, status item title. The bluetooth adapter's hardware address-->
<string name="status_bt_address">Bluetooth address</string>
<!-- About phone, status item title. The hardware serial number. [CHAR LIMIT=30]-->
@@ -4042,14 +4048,6 @@
<!-- About phone settings screen, Safety Legal dialog title until the link is fully loaded -->
<string name="settings_safetylegal_activity_loading">Loading\u2026</string>
- <!-- ConfirmDeviceCredential settings-->
- <!-- Button text shown on BiometricPrompt (system dialog that asks for biometric authentication) giving the user the option to use an alternate form of authentication (Pin) [CHAR LIMIT=30] -->
- <string name="confirm_device_credential_pin">Use PIN</string>
- <!-- Button text shown on BiometricPrompt (system dialog that asks for biometric authentication) giving the user the option to use an alternate form of authentication (Pattern) [CHAR LIMIT=30] -->
- <string name="confirm_device_credential_pattern">Use pattern</string>
- <!-- Button text shown on BiometricPrompt (system dialog that asks for biometric authentication) giving the user the option to use an alternate form of authentication (Pass) [CHAR LIMIT=30] -->
- <string name="confirm_device_credential_password">Use password</string>
-
<!-- Lock Pattern settings -->
<!-- Header on first screen of choose password/PIN flow [CHAR LIMIT=40] -->
<string name="lockpassword_choose_your_screen_lock_header">Set screen lock</string>
@@ -10856,6 +10854,8 @@
<string name="preferred_network_mode_lte_gsm_wcdma_summary">Preferred network mode: GSM/WCDMA/LTE</string>
<!-- CDMA+LTE/EVDO [CHAR LIMIT=NONE] -->
<string name="preferred_network_mode_lte_cdma_evdo_summary">Preferred network mode: CDMA+LTE/EVDO</string>
+ <!-- LTE/CDMA/EvDo/GSM/WCDMA [CHAR LIMIT=NONE] -->
+ <string name="preferred_network_mode_lte_cdma_evdo_gsm_wcdma_summary">Preferred network mode: LTE/CDMA/EvDo/GSM/WCDMA</string>
<!-- Global [CHAR LIMIT=NONE] -->
<string name="preferred_network_mode_global_summary">Preferred network mode: Global</string>
<!-- LTE / WCDMA [CHAR LIMIT=NONE] -->
@@ -10884,7 +10884,37 @@
<string name="preferred_network_mode_tdscdma_cdma_evdo_gsm_wcdma_summary">Preferred network mode: TDSCDMA/CDMA/EvDo/GSM/WCDMA</string>
<!-- LTE/TDSCDMA/CDMA/EvDo/GSM/WCDMA [CHAR LIMIT=NONE] -->
<string name="preferred_network_mode_lte_tdscdma_cdma_evdo_gsm_wcdma_summary">Preferred network mode: LTE/TDSCDMA/CDMA/EvDo/GSM/WCDMA</string>
+ <!-- NR only [CHAR LIMIT=NONE] -->
+ <string name="preferred_network_mode_nr_only_summary">Preferred network mode: NR only</string>
+ <!-- NR / LTE [CHAR LIMIT=NONE] -->
+ <string name="preferred_network_mode_nr_lte_summary">Preferred network mode: NR / LTE</string>
+ <!-- NR/LTE/CDME/EvDo [CHAR LIMIT=NONE] -->
+ <string name="preferred_network_mode_nr_lte_cdma_evdo_summary">Preferred network mode: NR/LTE/CDME/EvDo</string>
+ <!-- NR/LTE/GSM/WCDMA [CHAR LIMIT=NONE] -->
+ <string name="preferred_network_mode_nr_lte_gsm_wcdma_summary">Preferred network mode: NR/LTE/GSM/WCDMA</string>
+ <!-- NR/LTE/TDSCDMA/CDMA/EvDo/GSM/WCDMA [CHAR LIMIT=NONE] -->
+ <string name="preferred_network_mode_nr_lte_cdma_evdo_gsm_wcdma_summary">Preferred network mode: NR/LTE/CDMA/EvDo/GSM/WCDMA</string>
+ <!-- NR/LTE/WCDMA [CHAR LIMIT=NONE] -->
+ <string name="preferred_network_mode_nr_lte_wcdma_summary">Preferred network mode: NR/LTE/WCDMA</string>
+ <!-- NR/LTE/TDSCDMA [CHAR LIMIT=NONE] -->
+ <string name="preferred_network_mode_nr_lte_tdscdma_summary">Preferred network mode: NR/LTE/TDSCDMA</string>
+ <!-- NR/LTE/TDSCDMA/GSM [CHAR LIMIT=NONE] -->
+ <string name="preferred_network_mode_nr_lte_tdscdma_gsm_summary">Preferred network mode: NR/LTE/TDSCDMA/GSM</string>
+ <!-- NR/LTE/TDSCDMA/WCDMA [CHAR LIMIT=NONE] -->
+ <string name="preferred_network_mode_nr_lte_tdscdma_wcdma_summary">Preferred network mode: NR/LTE/TDSCDMA/WCDMA</string>
+ <!-- NR/LTE/TDSCDMA/GSM/WCDMA [CHAR LIMIT=NONE] -->
+ <string name="preferred_network_mode_nr_lte_tdscdma_gsm_wcdma_summary">Preferred network mode: NR/LTE/TDSCDMA/GSM/WCDMA</string>
+ <!-- NR/LTE/TDSCDMA/CDMA/EvDo/GSM/WCDMA [CHAR LIMIT=NONE] -->
+ <string name="preferred_network_mode_nr_lte_tdscdma_cdma_evdo_gsm_wcdma_summary">Preferred network mode: NR/LTE/TDSCDMA/CDMA/EvDo/GSM/WCDMA</string>
+ <!-- Text for Network mode recommended [CHAR LIMIT=NONE] -->
+ <string name="network_recommended">\u0020(recommended)</string>
+ <!-- Text for Network 5g [CHAR LIMIT=NONE] -->
+ <string name="network_5G" translatable="false">5G</string>
+ <!-- Text for Network lte [CHAR LIMIT=NONE] -->
+ <string name="network_lte_pure" translatable="false">LTE</string>
+ <!-- Text for Network 4g [CHAR LIMIT=NONE] -->
+ <string name="network_4G_pure" translatable="false">4G</string>
<!-- Text for Network lte [CHAR LIMIT=NONE] -->
<string name="network_lte">LTE (recommended)</string>
<!-- Text for Network 4g [CHAR LIMIT=NONE] -->
diff --git a/res/xml/app_and_notification.xml b/res/xml/app_and_notification.xml
index eccb0d1..f75bd86 100644
--- a/res/xml/app_and_notification.xml
+++ b/res/xml/app_and_notification.xml
@@ -46,6 +46,13 @@
android:layout="@layout/preference_category_no_label"
android:order="-997"/>
+ <Preference
+ android:key="configure_notification_settings"
+ android:title="@string/configure_notification_settings"
+ android:order="-440"
+ android:fragment="com.android.settings.notification.ConfigureNotificationSettings"
+ settings:controller="com.android.settings.notification.ConfigureNotificationPreferenceController"/>
+
<!-- Notifications (appears before manage_perms), default apps (appears after) -->
<PreferenceCategory
android:key="dashboard_tile_placeholder"
diff --git a/res/xml/connected_devices_advanced.xml b/res/xml/connected_devices_advanced.xml
index ab8967d..7c50bcc 100644
--- a/res/xml/connected_devices_advanced.xml
+++ b/res/xml/connected_devices_advanced.xml
@@ -36,14 +36,6 @@
settings:controller="com.android.settings.nfc.NfcPreferenceController"
android:order="-7"/>
- <com.android.settingslib.RestrictedPreference
- android:fragment="com.android.settings.nfc.AndroidBeam"
- android:key="android_beam_settings"
- android:title="@string/android_beam_settings_title"
- settings:controller="com.android.settings.nfc.AndroidBeamPreferenceController"
- android:icon="@drawable/ic_android"
- android:order="-6"/>
-
<SwitchPreference
android:key="nfc_secure_settings"
android:title="@string/nfc_secure_settings_title"
@@ -52,6 +44,23 @@
android:summary="@string/nfc_secure_toggle_summary"
android:order="-7"/>
+ <Preference
+ android:fragment="com.android.settings.wfd.WifiDisplaySettings"
+ android:key="wifi_display_settings"
+ android:title="@string/wifi_display_settings_title"
+ android:icon="@drawable/ic_cast_24dp"
+ android:order="-6"
+ settings:searchable="false"
+ settings:controller="com.android.settings.wfd.WifiDisplayPreferenceController"/>
+
+ <com.android.settingslib.RestrictedPreference
+ android:fragment="com.android.settings.nfc.AndroidBeam"
+ android:key="android_beam_settings"
+ android:title="@string/android_beam_settings_title"
+ settings:controller="com.android.settings.nfc.AndroidBeamPreferenceController"
+ android:icon="@drawable/ic_android"
+ android:order="-5"/>
+
<com.android.settingslib.RestrictedPreference
android:key="connected_device_printing"
android:title="@string/print_settings"
diff --git a/res/xml/firmware_version.xml b/res/xml/firmware_version.xml
index f55ee11..443ae35 100644
--- a/res/xml/firmware_version.xml
+++ b/res/xml/firmware_version.xml
@@ -27,6 +27,7 @@
android:key="os_firmware_version"
android:title="@string/firmware_version"
android:summary="@string/summary_placeholder"
+ android:selectable="false"
settings:enableCopying="true"
settings:controller="com.android.settings.deviceinfo.firmwareversion.FirmwareVersionDetailPreferenceController"/>
@@ -42,6 +43,7 @@
android:key="module_version"
android:title="@string/module_version"
android:summary="@string/summary_placeholder"
+ android:selectable="false"
settings:enableCopying="true"
settings:controller="com.android.settings.deviceinfo.firmwareversion.MainlineModuleVersionPreferenceController"/>
@@ -50,6 +52,7 @@
android:key="base_band"
android:title="@string/baseband_version"
android:summary="@string/summary_placeholder"
+ android:selectable="false"
settings:enableCopying="true"
settings:controller="com.android.settings.deviceinfo.firmwareversion.BasebandVersionPreferenceController"/>
@@ -58,6 +61,7 @@
android:key="kernel_version"
android:title="@string/kernel_version"
android:summary="@string/summary_placeholder"
+ android:selectable="false"
settings:enableCopying="true"
settings:controller="com.android.settings.deviceinfo.firmwareversion.KernelVersionPreferenceController"/>
@@ -66,7 +70,8 @@
android:key="os_build_number"
android:title="@string/build_number"
android:summary="@string/summary_placeholder"
+ android:selectable="false"
settings:enableCopying="true"
settings:controller="com.android.settings.deviceinfo.firmwareversion.SimpleBuildNumberPreferenceController"/>
-</PreferenceScreen>
\ No newline at end of file
+</PreferenceScreen>
diff --git a/res/xml/hardware_info.xml b/res/xml/hardware_info.xml
index 2fd58ff..4ed914d 100644
--- a/res/xml/hardware_info.xml
+++ b/res/xml/hardware_info.xml
@@ -27,6 +27,7 @@
android:key="hardware_info_device_model"
android:title="@string/model_info"
android:summary="@string/summary_placeholder"
+ android:selectable="false"
settings:controller="com.android.settings.deviceinfo.hardwareinfo.DeviceModelPreferenceController"
settings:enableCopying="true"/>
@@ -35,6 +36,7 @@
android:key="hardware_info_device_serial"
android:title="@string/status_serial_number"
android:summary="@string/summary_placeholder"
+ android:selectable="false"
settings:controller="com.android.settings.deviceinfo.hardwareinfo.SerialNumberPreferenceController"
settings:enableCopying="true"/>
@@ -43,7 +45,8 @@
android:key="hardware_info_device_revision"
android:title="@string/hardware_revision"
android:summary="@string/summary_placeholder"
+ android:selectable="false"
settings:controller="com.android.settings.deviceinfo.hardwareinfo.HardwareRevisionPreferenceController"
settings:enableCopying="true"/>
-</PreferenceScreen>
\ No newline at end of file
+</PreferenceScreen>
diff --git a/res/xml/my_device_info.xml b/res/xml/my_device_info.xml
index 6ebb1a5..ccd52ea 100644
--- a/res/xml/my_device_info.xml
+++ b/res/xml/my_device_info.xml
@@ -139,9 +139,18 @@
<!-- Wi-Fi MAC address -->
<Preference
- android:key="wifi_mac_address"
+ android:key="saved_accesspoints_wifi_mac_address"
android:order="45"
android:title="@string/status_wifi_mac_address"
+ android:summary="@string/view_saved_network"
+ android:fragment="com.android.settings.wifi.savedaccesspoints.SavedAccessPointsWifiSettings"
+ settings:enableCopying="false"/>
+
+ <!-- Factory Wi-Fi MAC address -->
+ <Preference
+ android:key="wifi_mac_address"
+ android:order="46"
+ android:title="@string/status_factory_wifi_mac_address"
android:summary="@string/summary_placeholder"
android:selectable="false"
settings:enableCopying="true"/>
@@ -149,7 +158,7 @@
<!-- Bluetooth address -->
<Preference
android:key="bt_address"
- android:order="46"
+ android:order="47"
android:title="@string/status_bt_address"
android:summary="@string/summary_placeholder"
android:selectable="false"
@@ -158,7 +167,7 @@
<!-- Device up time -->
<Preference
android:key="up_time"
- android:order="47"
+ android:order="48"
android:title="@string/status_up_time"
android:summary="@string/summary_placeholder"
android:selectable="false"/>
diff --git a/res/xml/wifi_configure_settings.xml b/res/xml/wifi_configure_settings.xml
index c7e16ef..1859a1e 100644
--- a/res/xml/wifi_configure_settings.xml
+++ b/res/xml/wifi_configure_settings.xml
@@ -69,12 +69,4 @@
android:title="@string/wifi_menu_p2p"
android:fragment="com.android.settings.wifi.p2p.WifiP2pSettings" />
- <Preference
- android:key="mac_address"
- android:title="@string/wifi_advanced_mac_address_title" />
-
- <Preference
- android:key="current_ip_address"
- android:title="@string/wifi_advanced_ip_address_title" />
-
</PreferenceScreen>
diff --git a/res/xml/wifi_network_details_fragment.xml b/res/xml/wifi_network_details_fragment.xml
index d45f9bc..7ec1f0e 100644
--- a/res/xml/wifi_network_details_fragment.xml
+++ b/res/xml/wifi_network_details_fragment.xml
@@ -87,7 +87,7 @@
settings:enableCopying="true"/>
<Preference
android:key="mac_address"
- android:title="@string/wifi_advanced_mac_address_title"
+ android:title="@string/wifi_advanced_randomized_mac_address_title"
android:selectable="false"
settings:enableCopying="true"/>
<Preference
diff --git a/src/com/android/settings/RadioInfo.java b/src/com/android/settings/RadioInfo.java
index ffb035a..054e6cf 100644
--- a/src/com/android/settings/RadioInfo.java
+++ b/src/com/android/settings/RadioInfo.java
@@ -101,28 +101,40 @@
private static final String TAG = "RadioInfo";
private static final String[] mPreferredNetworkLabels = {
- "WCDMA preferred",
+ "GSM/WCDMA preferred",
"GSM only",
"WCDMA only",
- "GSM auto (PRL)",
- "CDMA auto (PRL)",
+ "GSM/WCDMA auto (PRL)",
+ "CDMA/EvDo auto (PRL)",
"CDMA only",
"EvDo only",
- "Global auto (PRL)",
- "LTE/CDMA auto (PRL)",
- "LTE/UMTS auto (PRL)",
- "LTE/CDMA/UMTS auto (PRL)",
+ "CDMA/EvDo/GSM/WCDMA (PRL)",
+ "CDMA + LTE/EvDo (PRL)",
+ "GSM/WCDMA/LTE (PRL)",
+ "LTE/CDMA/EvDo/GSM/WCDMA (PRL)",
"LTE only",
"LTE/WCDMA",
- "TD-SCDMA only",
- "TD-SCDMA/WCDMA",
- "LTE/TD-SCDMA",
- "TD-SCDMA/GSM",
- "TD-SCDMA/UMTS",
- "LTE/TD-SCDMA/WCDMA",
- "LTE/TD-SCDMA/UMTS",
- "TD-SCDMA/CDMA/UMTS",
- "Global/TD-SCDMA",
+ "TDSCDMA only",
+ "TDSCDMA/WCDMA",
+ "LTE/TDSCDMA",
+ "TDSCDMA/GSM",
+ "LTE/TDSCDMA/GSM",
+ "TDSCDMA/GSM/WCDMA",
+ "LTE/TDSCDMA/WCDMA",
+ "LTE/TDSCDMA/GSM/WCDMA",
+ "TDSCDMA/CDMA/EvDo/GSM/WCDMA ",
+ "LTE/TDSCDMA/CDMA/EvDo/GSM/WCDMA",
+ "NR only",
+ "NR/LTE",
+ "NR/LTE/CDME/EvDo",
+ "NR/LTE/GSM/WCDMA",
+ "NR/LTE/CDMA/EvDo/GSM/WCDMA",
+ "NR/LTE/WCDMA",
+ "NR/LTE/TDSCDMA",
+ "NR/LTE/TDSCDMA/GSM",
+ "NR/LTE/TDSCDMA/WCDMA",
+ "NR/LTE/TDSCDMA/GSM/WCDMA",
+ "NR/LTE/TDSCDMA/CDMA/EvDo/GSM/WCDMA",
"Unknown"
};
diff --git a/src/com/android/settings/SettingsActivity.java b/src/com/android/settings/SettingsActivity.java
index 071cbcb..9270a5a 100644
--- a/src/com/android/settings/SettingsActivity.java
+++ b/src/com/android/settings/SettingsActivity.java
@@ -52,7 +52,6 @@
import com.android.internal.util.ArrayUtils;
import com.android.settings.Settings.WifiSettingsActivity;
import com.android.settings.applications.manageapplications.ManageApplications;
-import com.android.settings.backup.UserBackupSettingsActivity;
import com.android.settings.core.OnActivityResultListener;
import com.android.settings.core.SettingsBaseActivity;
import com.android.settings.core.SubSettingLauncher;
@@ -644,10 +643,6 @@
|| somethingChanged;
somethingChanged = setTileEnabled(changedList, new ComponentName(packageName,
- UserBackupSettingsActivity.class.getName()), true, isAdmin)
- || somethingChanged;
-
- somethingChanged = setTileEnabled(changedList, new ComponentName(packageName,
Settings.WifiDisplaySettingsActivity.class.getName()),
WifiDisplaySettings.isAvailable(this), isAdmin)
|| somethingChanged;
diff --git a/src/com/android/settings/applications/specialaccess/deviceadmin/DeviceAdminAdd.java b/src/com/android/settings/applications/specialaccess/deviceadmin/DeviceAdminAdd.java
index 8b06975..3e534b3 100644
--- a/src/com/android/settings/applications/specialaccess/deviceadmin/DeviceAdminAdd.java
+++ b/src/com/android/settings/applications/specialaccess/deviceadmin/DeviceAdminAdd.java
@@ -347,7 +347,6 @@
}
};
mAddMsgExpander.setOnClickListener(onClickListener);
- mAddMsg.setOnClickListener(onClickListener);
// Determine whether the message can be collapsed - getLineCount() gives the correct
// number of lines only after a layout pass.
@@ -360,7 +359,6 @@
boolean hideMsgExpander = mAddMsg.getLineCount() <= maxLines;
mAddMsgExpander.setVisibility(hideMsgExpander ? View.GONE : View.VISIBLE);
if (hideMsgExpander) {
- mAddMsg.setOnClickListener(null);
((View)mAddMsgExpander.getParent()).invalidate();
}
mAddMsg.getViewTreeObserver().removeOnGlobalLayoutListener(this);
diff --git a/src/com/android/settings/backup/BackupSettingsContentProvider.java b/src/com/android/settings/backup/BackupSettingsContentProvider.java
deleted file mode 100644
index 5c888ab..0000000
--- a/src/com/android/settings/backup/BackupSettingsContentProvider.java
+++ /dev/null
@@ -1,78 +0,0 @@
-/*
- * Copyright (C) 2019 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.android.settings.backup;
-
-import android.content.ContentProvider;
-import android.content.ContentValues;
-import android.content.UriMatcher;
-import android.database.Cursor;
-import android.net.Uri;
-import android.os.Bundle;
-
-import static com.android.settingslib.drawer.TileUtils.META_DATA_PREFERENCE_SUMMARY;
-
-/** Provider stores and manages user interaction feedback for homepage contextual cards. */
-public class BackupSettingsContentProvider extends ContentProvider {
- private static final String AUTHORITY =
- "com.android.settings.backup.BackupSettingsContentProvider";
- private static final String SUMMARY = "summary";
- private static final UriMatcher URI_MATCHER = new UriMatcher(UriMatcher.NO_MATCH);
- static {
- URI_MATCHER.addURI(AUTHORITY, SUMMARY, 1);
- }
-
- @Override
- public Bundle call(String method, String uri, Bundle extras) {
- if (!SUMMARY.equals(method)) {
- return null;
- }
- Bundle bundle = new Bundle();
- bundle.putString(META_DATA_PREFERENCE_SUMMARY,
- new BackupSettingsHelper(getContext()).getSummary());
- return bundle;
- }
-
- @Override
- public boolean onCreate() {
- return true;
- }
-
- @Override
- public Cursor query(Uri uri, String[] projection, String selection, String[] selectionArgs, String sortOrder) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public String getType(Uri uri) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Uri insert(Uri uri, ContentValues values) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public int delete(Uri uri, String selection, String[] selectionArgs) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public int update(Uri uri, ContentValues values, String selection, String[] selectionArgs) {
- throw new UnsupportedOperationException();
- }
-}
diff --git a/src/com/android/settings/backup/BackupSettingsHelper.java b/src/com/android/settings/backup/BackupSettingsHelper.java
index 1d3455b..1483714 100644
--- a/src/com/android/settings/backup/BackupSettingsHelper.java
+++ b/src/com/android/settings/backup/BackupSettingsHelper.java
@@ -54,7 +54,7 @@
* If there is only one profile, show whether the backup is on or off.
* Otherwise, show nothing.
*/
- String getSummary() {
+ public String getSummary() {
UserManager userManager = (UserManager) mContext.getSystemService(Context.USER_SERVICE);
if (userManager.getUserProfiles().size() == 1) {
try {
diff --git a/src/com/android/settings/bluetooth/AdvancedBluetoothDetailsHeaderController.java b/src/com/android/settings/bluetooth/AdvancedBluetoothDetailsHeaderController.java
index 6817d0d..7e10043 100644
--- a/src/com/android/settings/bluetooth/AdvancedBluetoothDetailsHeaderController.java
+++ b/src/com/android/settings/bluetooth/AdvancedBluetoothDetailsHeaderController.java
@@ -60,6 +60,7 @@
public class AdvancedBluetoothDetailsHeaderController extends BasePreferenceController implements
LifecycleObserver, OnStart, OnStop, OnDestroy, CachedBluetoothDevice.Callback {
private static final String TAG = "AdvancedBtHeaderCtrl";
+ private static final int LOW_BATTERY_LEVEL = 20;
@VisibleForTesting
LayoutPreference mLayoutPreference;
@@ -182,9 +183,11 @@
new BatteryMeterView.BatteryMeterDrawable(context,
context.getColor(R.color.meter_background_color));
drawable.setBatteryLevel(level);
+ final int attr = level > LOW_BATTERY_LEVEL || charging
+ ? android.R.attr.colorControlNormal
+ : android.R.attr.colorError;
drawable.setColorFilter(new PorterDuffColorFilter(
- com.android.settings.Utils.getColorAttrDefaultColor(context,
- android.R.attr.colorControlNormal),
+ com.android.settings.Utils.getColorAttrDefaultColor(context, attr),
PorterDuff.Mode.SRC_IN));
drawable.setCharging(charging);
diff --git a/src/com/android/settings/connecteddevice/usb/UsbConnectionBroadcastReceiver.java b/src/com/android/settings/connecteddevice/usb/UsbConnectionBroadcastReceiver.java
index 695a714..e557847 100644
--- a/src/com/android/settings/connecteddevice/usb/UsbConnectionBroadcastReceiver.java
+++ b/src/com/android/settings/connecteddevice/usb/UsbConnectionBroadcastReceiver.java
@@ -57,26 +57,24 @@
if (UsbManager.ACTION_USB_STATE.equals(intent.getAction())) {
mConnected = intent.getExtras().getBoolean(UsbManager.USB_CONNECTED)
|| intent.getExtras().getBoolean(UsbManager.USB_HOST_CONNECTED);
- if (mConnected) {
- long functions = UsbManager.FUNCTION_NONE;
- if (intent.getExtras().getBoolean(UsbManager.USB_FUNCTION_MTP)
- && intent.getExtras().getBoolean(UsbManager.USB_DATA_UNLOCKED, false)) {
- functions |= UsbManager.FUNCTION_MTP;
- }
- if (intent.getExtras().getBoolean(UsbManager.USB_FUNCTION_PTP)
- && intent.getExtras().getBoolean(UsbManager.USB_DATA_UNLOCKED, false)) {
- functions |= UsbManager.FUNCTION_PTP;
- }
- if (intent.getExtras().getBoolean(UsbManager.USB_FUNCTION_MIDI)) {
- functions |= UsbManager.FUNCTION_MIDI;
- }
- if (intent.getExtras().getBoolean(UsbManager.USB_FUNCTION_RNDIS)) {
- functions |= UsbManager.FUNCTION_RNDIS;
- }
- mFunctions = functions;
- mDataRole = mUsbBackend.getDataRole();
- mPowerRole = mUsbBackend.getPowerRole();
+ long functions = UsbManager.FUNCTION_NONE;
+ if (intent.getExtras().getBoolean(UsbManager.USB_FUNCTION_MTP)
+ && intent.getExtras().getBoolean(UsbManager.USB_DATA_UNLOCKED, false)) {
+ functions |= UsbManager.FUNCTION_MTP;
}
+ if (intent.getExtras().getBoolean(UsbManager.USB_FUNCTION_PTP)
+ && intent.getExtras().getBoolean(UsbManager.USB_DATA_UNLOCKED, false)) {
+ functions |= UsbManager.FUNCTION_PTP;
+ }
+ if (intent.getExtras().getBoolean(UsbManager.USB_FUNCTION_MIDI)) {
+ functions |= UsbManager.FUNCTION_MIDI;
+ }
+ if (intent.getExtras().getBoolean(UsbManager.USB_FUNCTION_RNDIS)) {
+ functions |= UsbManager.FUNCTION_RNDIS;
+ }
+ mFunctions = functions;
+ mDataRole = mUsbBackend.getDataRole();
+ mPowerRole = mUsbBackend.getPowerRole();
} else if (UsbManager.ACTION_USB_PORT_CHANGED.equals(intent.getAction())) {
UsbPortStatus portStatus = intent.getExtras()
.getParcelable(UsbManager.EXTRA_PORT_STATUS);
diff --git a/src/com/android/settings/connecteddevice/usb/UsbDefaultFragment.java b/src/com/android/settings/connecteddevice/usb/UsbDefaultFragment.java
index d4f1283..12e978f 100644
--- a/src/com/android/settings/connecteddevice/usb/UsbDefaultFragment.java
+++ b/src/com/android/settings/connecteddevice/usb/UsbDefaultFragment.java
@@ -26,12 +26,14 @@
import android.os.Bundle;
import androidx.annotation.VisibleForTesting;
+import androidx.preference.PreferenceScreen;
import com.android.settings.R;
import com.android.settings.Utils;
import com.android.settings.widget.RadioButtonPickerFragment;
import com.android.settingslib.widget.CandidateInfo;
import com.android.settingslib.widget.FooterPreference;
+import com.android.settingslib.widget.RadioButtonPreference;
import com.google.android.collect.Lists;
@@ -49,12 +51,31 @@
OnStartTetheringCallback mOnStartTetheringCallback = new OnStartTetheringCallback();
@VisibleForTesting
long mPreviousFunctions;
+ @VisibleForTesting
+ long mCurrentFunctions;
+ @VisibleForTesting
+ boolean mIsStartTethering = false;
+
+ private UsbConnectionBroadcastReceiver mUsbReceiver;
+
+ @VisibleForTesting
+ UsbConnectionBroadcastReceiver.UsbConnectionListener mUsbConnectionListener =
+ (connected, functions, powerRole, dataRole) -> {
+ if (mIsStartTethering) {
+ mCurrentFunctions = functions;
+ refresh(functions);
+ }
+ };
@Override
public void onAttach(Context context) {
super.onAttach(context);
mUsbBackend = new UsbBackend(context);
mConnectivityManager = context.getSystemService(ConnectivityManager.class);
+ mUsbReceiver = new UsbConnectionBroadcastReceiver(context, mUsbConnectionListener,
+ mUsbBackend);
+ getSettingsLifecycle().addObserver(mUsbReceiver);
+ mCurrentFunctions = mUsbBackend.getDefaultUsbFunctions();
}
@Override
@@ -118,9 +139,12 @@
if (functions == UsbManager.FUNCTION_RNDIS) {
// We need to have entitlement check for usb tethering, so use API in
// ConnectivityManager.
+ mIsStartTethering = true;
mConnectivityManager.startTethering(TETHERING_USB, true /* showProvisioningUi */,
mOnStartTetheringCallback);
} else {
+ mIsStartTethering = false;
+ mCurrentFunctions = functions;
mUsbBackend.setDefaultUsbFunctions(functions);
}
@@ -128,6 +152,12 @@
return true;
}
+ @Override
+ public void onPause() {
+ super.onPause();
+ mUsbBackend.setDefaultUsbFunctions(mCurrentFunctions);
+ }
+
@VisibleForTesting
final class OnStartTetheringCallback extends
ConnectivityManager.OnStartTetheringCallback {
@@ -136,6 +166,7 @@
public void onTetheringStarted() {
super.onTetheringStarted();
// Set default usb functions again to make internal data persistent
+ mCurrentFunctions = UsbManager.FUNCTION_RNDIS;
mUsbBackend.setDefaultUsbFunctions(UsbManager.FUNCTION_RNDIS);
}
@@ -146,4 +177,19 @@
updateCandidates();
}
}
+
+ private void refresh(long functions) {
+ final PreferenceScreen screen = getPreferenceScreen();
+ for (long option : UsbDetailsFunctionsController.FUNCTIONS_MAP.keySet()) {
+ final RadioButtonPreference pref =
+ screen.findPreference(UsbBackend.usbFunctionsToString(option));
+ if (pref != null) {
+ final boolean isSupported = mUsbBackend.areFunctionsSupported(option);
+ pref.setEnabled(isSupported);
+ if (isSupported) {
+ pref.setChecked(functions == option);
+ }
+ }
+ }
+ }
}
\ No newline at end of file
diff --git a/src/com/android/settings/core/SettingsBaseActivity.java b/src/com/android/settings/core/SettingsBaseActivity.java
index 4ab1117..57697a6 100644
--- a/src/com/android/settings/core/SettingsBaseActivity.java
+++ b/src/com/android/settings/core/SettingsBaseActivity.java
@@ -111,7 +111,7 @@
filter.addDataScheme(DATA_SCHEME_PKG);
registerReceiver(mPackageReceiver, filter);
- new CategoriesUpdateTask().execute();
+ updateCategories();
}
@Override
@@ -154,7 +154,6 @@
}
}
-
private boolean isLockTaskModePinned() {
final ActivityManager activityManager =
getApplicationContext().getSystemService(ActivityManager.class);
@@ -226,7 +225,7 @@
private class PackageReceiver extends BroadcastReceiver {
@Override
public void onReceive(Context context, Intent intent) {
- new CategoriesUpdateTask().execute();
+ updateCategories();
}
}
}
diff --git a/src/com/android/settings/dashboard/DashboardFeatureProviderImpl.java b/src/com/android/settings/dashboard/DashboardFeatureProviderImpl.java
index e9b7f33..2cfcbe6 100644
--- a/src/com/android/settings/dashboard/DashboardFeatureProviderImpl.java
+++ b/src/com/android/settings/dashboard/DashboardFeatureProviderImpl.java
@@ -32,6 +32,7 @@
import android.content.pm.PackageManager;
import android.graphics.drawable.Drawable;
import android.graphics.drawable.Icon;
+import android.net.Uri;
import android.os.Bundle;
import android.os.UserHandle;
import android.provider.Settings;
@@ -118,10 +119,10 @@
bindTitle(pref, tile);
bindSummary(pref, tile);
bindIcon(pref, tile, forceRoundedIcon);
+
final Bundle metadata = tile.getMetaData();
String clsName = null;
String action = null;
-
if (metadata != null) {
clsName = metadata.getString(SettingsActivity.META_DATA_KEY_FRAGMENT_CLASS);
action = metadata.getString(META_DATA_KEY_INTENT_ACTION);
@@ -140,10 +141,9 @@
return true;
});
}
- final String skipOffsetPackageName = activity.getPackageName();
-
if (tile.hasOrder()) {
+ final String skipOffsetPackageName = activity.getPackageName();
final int order = tile.getOrder();
boolean shouldSkipBaseOrderOffset = TextUtils.equals(
skipOffsetPackageName, tile.getIntent().getComponent().getPackageName());
@@ -182,16 +182,20 @@
// to avoid preference height change.
preference.setTitle(R.string.summary_placeholder);
- ThreadUtils.postOnBackgroundThread(() -> {
- final Map<String, IContentProvider> providerMap = new ArrayMap<>();
- final String uri = tile.getMetaData().getString(META_DATA_PREFERENCE_TITLE_URI);
- final String titleFromUri = TileUtils.getTextFromUri(
- mContext, uri, providerMap, META_DATA_PREFERENCE_TITLE);
- ThreadUtils.postOnMainThread(() -> preference.setTitle(titleFromUri));
- });
+ final Uri uri = TileUtils.getCompleteUri(tile, META_DATA_PREFERENCE_TITLE_URI);
+ refreshTitle(uri, preference);
}
}
+ private void refreshTitle(Uri uri, Preference preference) {
+ ThreadUtils.postOnBackgroundThread(() -> {
+ final Map<String, IContentProvider> providerMap = new ArrayMap<>();
+ final String titleFromUri = TileUtils.getTextFromUri(
+ mContext, uri, providerMap, META_DATA_PREFERENCE_TITLE);
+ ThreadUtils.postOnMainThread(() -> preference.setTitle(titleFromUri));
+ });
+ }
+
private void bindSummary(Preference preference, Tile tile) {
final CharSequence summary = tile.getSummary(mContext);
if (summary != null) {
@@ -202,22 +206,26 @@
// to avoid preference height change.
preference.setSummary(R.string.summary_placeholder);
- ThreadUtils.postOnBackgroundThread(() -> {
- final Map<String, IContentProvider> providerMap = new ArrayMap<>();
- final String uri = tile.getMetaData().getString(META_DATA_PREFERENCE_SUMMARY_URI);
- final String summaryFromUri = TileUtils.getTextFromUri(
- mContext, uri, providerMap, META_DATA_PREFERENCE_SUMMARY);
- ThreadUtils.postOnMainThread(() -> preference.setSummary(summaryFromUri));
- });
+ final Uri uri = TileUtils.getCompleteUri(tile, META_DATA_PREFERENCE_SUMMARY_URI);
+ refreshSummary(uri, preference);
} else {
preference.setSummary(R.string.summary_placeholder);
}
}
+ private void refreshSummary(Uri uri, Preference preference) {
+ ThreadUtils.postOnBackgroundThread(() -> {
+ final Map<String, IContentProvider> providerMap = new ArrayMap<>();
+ final String summaryFromUri = TileUtils.getTextFromUri(
+ mContext, uri, providerMap, META_DATA_PREFERENCE_SUMMARY);
+ ThreadUtils.postOnMainThread(() -> preference.setSummary(summaryFromUri));
+ });
+ }
+
@VisibleForTesting
void bindIcon(Preference preference, Tile tile, boolean forceRoundedIcon) {
// Use preference context instead here when get icon from Tile, as we are using the context
- // to get the style to tint the icon. Using mContext here won't get the correct style.
+ // to get the style to tint the icon. Using mContext here won't get the correct style.
final Icon tileIcon = tile.getIcon(preference.getContext());
if (tileIcon != null) {
Drawable iconDrawable = tileIcon.loadDrawable(preference.getContext());
@@ -238,7 +246,7 @@
packageName = intent.getComponent().getPackageName();
}
final Map<String, IContentProvider> providerMap = new ArrayMap<>();
- final String uri = tile.getMetaData().getString(META_DATA_PREFERENCE_ICON_URI);
+ final Uri uri = TileUtils.getCompleteUri(tile, META_DATA_PREFERENCE_ICON_URI);
final Pair<String, Integer> iconInfo = TileUtils.getIconFromUri(
mContext, packageName, uri, providerMap);
if (iconInfo == null) {
diff --git a/src/com/android/settings/dashboard/DashboardFragment.java b/src/com/android/settings/dashboard/DashboardFragment.java
index 0e6476c..3575b72 100644
--- a/src/com/android/settings/dashboard/DashboardFragment.java
+++ b/src/com/android/settings/dashboard/DashboardFragment.java
@@ -37,12 +37,12 @@
import com.android.settings.core.PreferenceControllerListHelper;
import com.android.settings.core.SettingsBaseActivity;
import com.android.settings.overlay.FeatureFactory;
-import com.android.settingslib.search.Indexable;
import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.core.lifecycle.LifecycleObserver;
import com.android.settingslib.drawer.DashboardCategory;
import com.android.settingslib.drawer.Tile;
+import com.android.settingslib.search.Indexable;
import java.util.ArrayList;
import java.util.Arrays;
@@ -56,7 +56,7 @@
*/
public abstract class DashboardFragment extends SettingsPreferenceFragment
implements SettingsBaseActivity.CategoryListener, Indexable,
- SummaryLoader.SummaryConsumer, PreferenceGroup.OnExpandButtonClickListener,
+ PreferenceGroup.OnExpandButtonClickListener,
BasePreferenceController.UiBlockListener {
private static final String TAG = "DashboardFragment";
@@ -68,7 +68,6 @@
private DashboardFeatureProvider mDashboardFeatureProvider;
private DashboardTilePlaceholderPreferenceController mPlaceholderPreferenceController;
private boolean mListeningToCategoryChange;
- private SummaryLoader mSummaryLoader;
private List<String> mSuppressInjectedTileKeys;
@VisibleForTesting
UiBlockerController mBlockerController;
@@ -99,11 +98,11 @@
// And wire up with lifecycle.
final Lifecycle lifecycle = getSettingsLifecycle();
- uniqueControllerFromXml
- .stream()
- .filter(controller -> controller instanceof LifecycleObserver)
- .forEach(
- controller -> lifecycle.addObserver((LifecycleObserver) controller));
+ uniqueControllerFromXml.forEach(controller -> {
+ if (controller instanceof LifecycleObserver) {
+ lifecycle.addObserver((LifecycleObserver) controller);
+ }
+ });
mPlaceholderPreferenceController =
new DashboardTilePlaceholderPreferenceController(context);
@@ -116,19 +115,17 @@
@VisibleForTesting
void checkUiBlocker(List<AbstractPreferenceController> controllers) {
final List<String> keys = new ArrayList<>();
- controllers
- .stream()
- .filter(controller -> controller instanceof BasePreferenceController.UiBlocker)
- .forEach(controller -> {
- if (controller.isAvailable()) {
- ((BasePreferenceController) controller).setUiBlockListener(this);
- keys.add(controller.getPreferenceKey());
- }
- });
+ controllers.forEach(controller -> {
+ if (controller instanceof BasePreferenceController.UiBlocker
+ && controller.isAvailable()) {
+ ((BasePreferenceController) controller).setUiBlockListener(this);
+ keys.add(controller.getPreferenceKey());
+ }
+ });
if (!keys.isEmpty()) {
mBlockerController = new UiBlockerController(keys);
- mBlockerController.start(()->updatePreferenceVisibility(mPreferenceControllers));
+ mBlockerController.start(() -> updatePreferenceVisibility(mPreferenceControllers));
}
}
@@ -169,10 +166,6 @@
if (category == null) {
return;
}
- if (mSummaryLoader != null) {
- // SummaryLoader can be null when there is no dynamic tiles.
- mSummaryLoader.setListening(true);
- }
final Activity activity = getActivity();
if (activity instanceof SettingsBaseActivity) {
mListeningToCategoryChange = true;
@@ -181,19 +174,6 @@
}
@Override
- public void notifySummaryChanged(Tile tile) {
- final String key = mDashboardFeatureProvider.getDashboardKeyForTile(tile);
- final Preference pref = getPreferenceScreen().findPreference(key);
- if (pref == null) {
- Log.d(getLogTag(), String.format(
- "Can't find pref by key %s, skipping update summary %s",
- key, tile.getDescription()));
- return;
- }
- pref.setSummary(tile.getSummary(pref.getContext()));
- }
-
- @Override
public void onResume() {
super.onResume();
updatePreferenceStates();
@@ -220,10 +200,6 @@
@Override
public void onStop() {
super.onStop();
- if (mSummaryLoader != null) {
- // SummaryLoader can be null when there is no dynamic tiles.
- mSummaryLoader.setListening(false);
- }
if (mListeningToCategoryChange) {
final Activity activity = getActivity();
if (activity instanceof SettingsBaseActivity) {
@@ -413,13 +389,6 @@
// Create a list to track which tiles are to be removed.
final List<String> remove = new ArrayList<>(mDashboardTilePrefKeys);
- // There are dashboard tiles, so we need to install SummaryLoader.
- if (mSummaryLoader != null) {
- mSummaryLoader.release();
- }
- final Context context = getContext();
- mSummaryLoader = new SummaryLoader(getActivity(), getCategoryKey());
- mSummaryLoader.setSummaryConsumer(this);
// Install dashboard tiles.
final boolean forceRoundedIcons = shouldForceRoundedIcon();
for (Tile tile : tiles) {
@@ -456,7 +425,6 @@
screen.removePreference(preference);
}
}
- mSummaryLoader.setListening(true);
}
@Override
diff --git a/src/com/android/settings/dashboard/SummaryLoader.java b/src/com/android/settings/dashboard/SummaryLoader.java
deleted file mode 100644
index a1833f8..0000000
--- a/src/com/android/settings/dashboard/SummaryLoader.java
+++ /dev/null
@@ -1,297 +0,0 @@
-/*
- * Copyright (C) 2015 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package com.android.settings.dashboard;
-
-import android.app.Activity;
-import android.content.BroadcastReceiver;
-import android.content.ComponentName;
-import android.content.Context;
-import android.content.Intent;
-import android.content.IntentFilter;
-import android.os.Bundle;
-import android.os.Handler;
-import android.os.HandlerThread;
-import android.os.Looper;
-import android.os.Message;
-import android.os.Process;
-import android.text.TextUtils;
-import android.util.ArrayMap;
-import android.util.ArraySet;
-import android.util.Log;
-
-import androidx.annotation.VisibleForTesting;
-
-import com.android.settings.SettingsActivity;
-import com.android.settings.overlay.FeatureFactory;
-import com.android.settingslib.drawer.DashboardCategory;
-import com.android.settingslib.drawer.Tile;
-import com.android.settingslib.utils.ThreadUtils;
-
-import java.lang.reflect.Field;
-import java.util.List;
-
-public class SummaryLoader {
- private static final boolean DEBUG = false;
- private static final String TAG = "SummaryLoader";
-
- public static final String SUMMARY_PROVIDER_FACTORY = "SUMMARY_PROVIDER_FACTORY";
-
- private final Activity mActivity;
- private final ArrayMap<SummaryProvider, ComponentName> mSummaryProviderMap = new ArrayMap<>();
- private final ArrayMap<String, CharSequence> mSummaryTextMap = new ArrayMap<>();
- private final DashboardFeatureProvider mDashboardFeatureProvider;
- private final String mCategoryKey;
-
- private final Worker mWorker;
- private final HandlerThread mWorkerThread;
-
- private SummaryConsumer mSummaryConsumer;
- private boolean mListening;
- private boolean mWorkerListening;
- private ArraySet<BroadcastReceiver> mReceivers = new ArraySet<>();
-
- public SummaryLoader(Activity activity, String categoryKey) {
- mDashboardFeatureProvider = FeatureFactory.getFactory(activity)
- .getDashboardFeatureProvider(activity);
- mCategoryKey = categoryKey;
- mWorkerThread = new HandlerThread("SummaryLoader", Process.THREAD_PRIORITY_BACKGROUND);
- mWorkerThread.start();
- mWorker = new Worker(mWorkerThread.getLooper());
- mActivity = activity;
- }
-
- public void release() {
- mWorkerThread.quitSafely();
- // Make sure we aren't listening.
- setListeningW(false);
- }
-
- public void setSummaryConsumer(SummaryConsumer summaryConsumer) {
- mSummaryConsumer = summaryConsumer;
- }
-
- public void setSummary(SummaryProvider provider, final CharSequence summary) {
- final ComponentName component = mSummaryProviderMap.get(provider);
- ThreadUtils.postOnMainThread(() -> {
-
- final Tile tile = getTileFromCategory(
- mDashboardFeatureProvider.getTilesForCategory(mCategoryKey), component);
-
- if (tile == null) {
- if (DEBUG) {
- Log.d(TAG, "Can't find tile for " + component);
- }
- return;
- }
- if (DEBUG) {
- Log.d(TAG, "setSummary " + tile.getDescription() + " - " + summary);
- }
-
- updateSummaryIfNeeded(mActivity.getApplicationContext(), tile, summary);
- });
- }
-
- @VisibleForTesting
- void updateSummaryIfNeeded(Context context, Tile tile, CharSequence summary) {
- if (TextUtils.equals(tile.getSummary(context), summary)) {
- if (DEBUG) {
- Log.d(TAG, "Summary doesn't change, skipping summary update for "
- + tile.getDescription());
- }
- return;
- }
- mSummaryTextMap.put(mDashboardFeatureProvider.getDashboardKeyForTile(tile), summary);
- tile.overrideSummary(summary);
- if (mSummaryConsumer != null) {
- mSummaryConsumer.notifySummaryChanged(tile);
- } else {
- if (DEBUG) {
- Log.d(TAG, "SummaryConsumer is null, skipping summary update for "
- + tile.getDescription());
- }
- }
- }
-
- /**
- * Only call from the main thread.
- */
- public void setListening(boolean listening) {
- if (mListening == listening) {
- return;
- }
- mListening = listening;
- // Unregister listeners immediately.
- for (int i = 0; i < mReceivers.size(); i++) {
- mActivity.unregisterReceiver(mReceivers.valueAt(i));
- }
- mReceivers.clear();
-
- mWorker.removeMessages(Worker.MSG_SET_LISTENING);
- if (!listening) {
- // Stop listen
- mWorker.obtainMessage(Worker.MSG_SET_LISTENING, 0 /* listening */).sendToTarget();
- } else {
- // Start listen
- if (mSummaryProviderMap.isEmpty()) {
- // Category not initialized yet, init before starting to listen
- if (!mWorker.hasMessages(Worker.MSG_GET_CATEGORY_TILES_AND_SET_LISTENING)) {
- mWorker.sendEmptyMessage(Worker.MSG_GET_CATEGORY_TILES_AND_SET_LISTENING);
- }
- } else {
- // Category already initialized, start listening immediately
- mWorker.obtainMessage(Worker.MSG_SET_LISTENING, 1 /* listening */).sendToTarget();
- }
- }
- }
-
- private SummaryProvider getSummaryProvider(Tile tile) {
- if (!mActivity.getPackageName().equals(tile.getPackageName())) {
- // Not within Settings, can't load Summary directly.
- // TODO: Load summary indirectly.
- return null;
- }
- final Bundle metaData = tile.getMetaData();
- final Intent intent = tile.getIntent();
- if (metaData == null) {
- Log.d(TAG, "No metadata specified for " + intent.getComponent());
- return null;
- }
- final String clsName = metaData.getString(SettingsActivity.META_DATA_KEY_FRAGMENT_CLASS);
- if (clsName == null) {
- Log.d(TAG, "No fragment specified for " + intent.getComponent());
- return null;
- }
- try {
- Class<?> cls = Class.forName(clsName);
- Field field = cls.getField(SUMMARY_PROVIDER_FACTORY);
- SummaryProviderFactory factory = (SummaryProviderFactory) field.get(null);
- return factory.createSummaryProvider(mActivity, this);
- } catch (ClassNotFoundException e) {
- if (DEBUG) Log.d(TAG, "Couldn't find " + clsName, e);
- } catch (NoSuchFieldException e) {
- if (DEBUG) Log.d(TAG, "Couldn't find " + SUMMARY_PROVIDER_FACTORY, e);
- } catch (ClassCastException e) {
- if (DEBUG) Log.d(TAG, "Couldn't cast " + SUMMARY_PROVIDER_FACTORY, e);
- } catch (IllegalAccessException e) {
- if (DEBUG) Log.d(TAG, "Couldn't get " + SUMMARY_PROVIDER_FACTORY, e);
- }
- return null;
- }
-
- /**
- * Registers a receiver and automatically unregisters it when the activity is stopping.
- * This ensures that the receivers are unregistered immediately, since most summary loader
- * operations are asynchronous.
- */
- public void registerReceiver(final BroadcastReceiver receiver, final IntentFilter filter) {
- mActivity.runOnUiThread(() -> {
- if (!mListening) {
- return;
- }
- mReceivers.add(receiver);
- mActivity.registerReceiver(receiver, filter);
- });
- }
-
- private synchronized void setListeningW(boolean listening) {
- if (mWorkerListening == listening) {
- return;
- }
- mWorkerListening = listening;
- if (DEBUG) {
- Log.d(TAG, "Listening " + listening);
- }
- for (SummaryProvider p : mSummaryProviderMap.keySet()) {
- try {
- p.setListening(listening);
- } catch (Exception e) {
- Log.d(TAG, "Problem in setListening", e);
- }
- }
- }
-
- private synchronized void makeProviderW(Tile tile) {
- SummaryProvider provider = getSummaryProvider(tile);
- if (provider != null) {
- if (DEBUG) Log.d(TAG, "Creating " + tile);
- mSummaryProviderMap.put(provider, tile.getIntent().getComponent());
- }
- }
-
- private Tile getTileFromCategory(DashboardCategory category, ComponentName component) {
- if (category == null || category.getTilesCount() == 0) {
- return null;
- }
- final List<Tile> tiles = category.getTiles();
- final int tileCount = tiles.size();
- for (int j = 0; j < tileCount; j++) {
- final Tile tile = tiles.get(j);
- if (component.equals(tile.getIntent().getComponent())) {
- return tile;
- }
- }
- return null;
- }
-
-
- public interface SummaryProvider {
- void setListening(boolean listening);
- }
-
- public interface SummaryConsumer {
- void notifySummaryChanged(Tile tile);
- }
-
- public interface SummaryProviderFactory {
- SummaryProvider createSummaryProvider(Activity activity, SummaryLoader summaryLoader);
- }
-
- private class Worker extends Handler {
- private static final int MSG_GET_CATEGORY_TILES_AND_SET_LISTENING = 1;
- private static final int MSG_GET_PROVIDER = 2;
- private static final int MSG_SET_LISTENING = 3;
-
- public Worker(Looper looper) {
- super(looper);
- }
-
- @Override
- public void handleMessage(Message msg) {
- switch (msg.what) {
- case MSG_GET_CATEGORY_TILES_AND_SET_LISTENING:
- final DashboardCategory category =
- mDashboardFeatureProvider.getTilesForCategory(mCategoryKey);
- if (category == null || category.getTilesCount() == 0) {
- return;
- }
- final List<Tile> tiles = category.getTiles();
- for (Tile tile : tiles) {
- makeProviderW(tile);
- }
- setListeningW(true);
- break;
- case MSG_GET_PROVIDER:
- Tile tile = (Tile) msg.obj;
- makeProviderW(tile);
- break;
- case MSG_SET_LISTENING:
- boolean listening = msg.obj != null && msg.obj.equals(1);
- setListeningW(listening);
- break;
- }
- }
- }
-}
diff --git a/src/com/android/settings/dashboard/SummaryProvider.java b/src/com/android/settings/dashboard/SummaryProvider.java
new file mode 100644
index 0000000..6acc663
--- /dev/null
+++ b/src/com/android/settings/dashboard/SummaryProvider.java
@@ -0,0 +1,91 @@
+/*
+ * Copyright (C) 2019 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License
+ */
+
+package com.android.settings.dashboard;
+
+import static com.android.settingslib.drawer.TileUtils.META_DATA_PREFERENCE_SUMMARY;
+
+import android.content.ContentProvider;
+import android.content.ContentValues;
+import android.content.Context;
+import android.content.pm.UserInfo;
+import android.database.Cursor;
+import android.net.Uri;
+import android.os.Bundle;
+import android.os.UserHandle;
+import android.os.UserManager;
+
+import com.android.settings.R;
+import com.android.settings.backup.BackupSettingsHelper;
+
+/** Provide preference summary for injected items. */
+public class SummaryProvider extends ContentProvider {
+ private static final String BACKUP = "backup";
+ private static final String USER = "user";
+
+ @Override
+ public Bundle call(String method, String uri, Bundle extras) {
+ final Bundle bundle = new Bundle();
+ switch (method) {
+ case BACKUP:
+ bundle.putString(META_DATA_PREFERENCE_SUMMARY,
+ new BackupSettingsHelper(getContext()).getSummary());
+ break;
+ case USER:
+ final Context context = getContext();
+ final UserInfo info = context.getSystemService(UserManager.class).getUserInfo(
+ UserHandle.myUserId());
+ bundle.putString(META_DATA_PREFERENCE_SUMMARY,
+ context.getString(R.string.users_summary,
+ info.name));
+ break;
+ default:
+ throw new IllegalArgumentException("Unknown Uri format: " + uri);
+ }
+ return bundle;
+ }
+
+ @Override
+ public boolean onCreate() {
+ return true;
+ }
+
+ @Override
+ public Cursor query(Uri uri, String[] projection, String selection, String[] selectionArgs,
+ String sortOrder) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public String getType(Uri uri) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public Uri insert(Uri uri, ContentValues values) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public int delete(Uri uri, String selection, String[] selectionArgs) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public int update(Uri uri, ContentValues values, String selection, String[] selectionArgs) {
+ throw new UnsupportedOperationException();
+ }
+}
diff --git a/src/com/android/settings/network/telephony/EnabledNetworkModePreferenceController.java b/src/com/android/settings/network/telephony/EnabledNetworkModePreferenceController.java
index 7d53e22..3abb36a 100644
--- a/src/com/android/settings/network/telephony/EnabledNetworkModePreferenceController.java
+++ b/src/com/android/settings/network/telephony/EnabledNetworkModePreferenceController.java
@@ -26,9 +26,12 @@
import android.os.PersistableBundle;
import android.provider.Settings;
import android.telephony.CarrierConfigManager;
+import android.telephony.RadioAccessFamily;
import android.telephony.ServiceState;
import android.telephony.SubscriptionManager;
import android.telephony.TelephonyManager;
+import android.text.TextUtils;
+import android.util.Log;
import androidx.annotation.VisibleForTesting;
import androidx.lifecycle.Lifecycle;
@@ -42,6 +45,9 @@
import com.android.internal.telephony.PhoneConstants;
import com.android.settings.R;
+import java.util.ArrayList;
+import java.util.List;
+
/**
* Preference controller for "Enabled network mode"
*/
@@ -49,6 +55,7 @@
TelephonyBasePreferenceController implements
ListPreference.OnPreferenceChangeListener, LifecycleObserver {
+ private static final String LOG_TAG = "EnabledNetworkMode";
private CarrierConfigManager mCarrierConfigManager;
private ContentObserver mPreferredNetworkModeObserver;
private TelephonyManager mTelephonyManager;
@@ -56,6 +63,8 @@
@VisibleForTesting
boolean mShow4GForLTE;
private Preference mPreference;
+ @VisibleForTesting
+ boolean mDisplay5gList = false;
public EnabledNetworkModePreferenceController(Context context, String key) {
super(context, key);
@@ -149,6 +158,11 @@
? carrierConfig.getBoolean(
CarrierConfigManager.KEY_SHOW_4G_FOR_LTE_DATA_ICON_BOOL)
: false;
+
+ final long supportedRadioBitmask = mTelephonyManager.getSupportedRadioAccessFamily();
+ mDisplay5gList = checkSupportedRadioBitmask(
+ supportedRadioBitmask, mTelephonyManager.NETWORK_TYPE_BITMASK_NR);
+
lifecycle.addObserver(this);
}
@@ -249,6 +263,139 @@
preference.setEntryValues(
R.array.preferred_network_mode_values_world_mode);
}
+
+ if (mDisplay5gList) {
+ add5gListItem(preference);
+ }
+ }
+
+ @VisibleForTesting
+ boolean checkSupportedRadioBitmask(long supportedRadioBitmask, long targetBitmask) {
+ Log.d(LOG_TAG, "supportedRadioBitmask: " + supportedRadioBitmask);
+ if ((targetBitmask & supportedRadioBitmask) > 0) {
+ return true;
+ }
+ return false;
+ }
+
+ /***
+ * Preferred network list add 5G item.
+ *
+ * @string/enabled_networks_cdma_choices
+ * Before | After
+ * @string/network_lte , 8 |@string/network_5G + @string/network_recommended , 25
+ * @string/network_3G , 4 |@string/network_lte_pure, 8
+ * @string/network_1x , 5 |@string/network_3G , 4
+ * @string/network_global, 10|@string/network_1x , 5
+ * |@string/network_global , 27
+ *
+ * @string/enabled_networks_cdma_only_lte_choices
+ * Before | After
+ * @string/network_lte , 8 |@string/network_5G + @string/network_recommended , 25
+ * @string/network_global, 10|@string/network_lte_pure, 8
+ * |@string/network_global , 27
+ *
+ * @string/enabled_networks_tdscdma_choices
+ * Before | After
+ * @string/network_lte, 22|@string/network_5G + @string/network_recommended , 33
+ * @string/network_3G , 18|@string/network_lte_pure, 22
+ * @string/network_2G , 1 |@string/network_3G , 18
+ * |@string/network_2G , 1
+ *
+ * @string/enabled_networks_except_gsm_4g_choices
+ * Before | After
+ * @string/network_4G , 9 |@string/network_5G + @string/network_recommended , 26
+ * @string/network_3G , 0 |@string/network_4G_pure , 9
+ * |@string/network_3G , 0
+ *
+ * @string/enabled_networks_except_gsm_choices
+ * Before | After
+ * @string/network_lte, 9 |@string/network_5G + @string/network_recommended , 26
+ * @string/network_3G , 0 |@string/network_lte_pure, 9
+ * |@string/network_3G , 0
+ *
+ * @string/enabled_networks_4g_choices
+ * Before | After
+ * @string/network_4G , 9 |@string/network_5G + @string/network_recommended , 26
+ * @string/network_3G , 0 |@string/network_4G_pure , 9
+ * @string/network_2G , 1 |@string/network_3G , 0
+ * |@string/network_2G , 1
+ *
+ * @string/enabled_networks_choices
+ * Before | After
+ * @string/network_lte, 9 |@string/network_5G + @string/network_recommended , 26
+ * @string/network_3G , 0 |@string/network_lte_pure, 9
+ * @string/network_2G , 1 |@string/network_3G , 0
+ * |@string/network_2G , 1
+ *
+ * @string/preferred_network_mode_choices_world_mode
+ * Before | After
+ * "Global" , 10|@string/network_global , 27
+ * "LTE / CDMA" , 8 |"LTE / CDMA" , 8
+ * "LTE / GSM / UMTS" , 9 |"LTE / GSM / UMTS" , 9
+ */
+ @VisibleForTesting
+ void add5gListItem(ListPreference preference) {
+ final CharSequence[] oldEntries = preference.getEntries();
+ final CharSequence[] oldEntryValues = preference.getEntryValues();
+ List<CharSequence> newEntries = new ArrayList<>();
+ List<CharSequence> newEntryValues = new ArrayList<>();
+
+ CharSequence oldEntry;
+ CharSequence oldEntryValue;
+ CharSequence new5gEntry;
+ CharSequence new5gEntryValue;
+
+ for (int i = 0; i < oldEntries.length; i++) {
+ oldEntry = oldEntries[i];
+ oldEntryValue = oldEntryValues[i];
+ new5gEntry = "";
+ new5gEntryValue = "";
+
+ if (mContext.getString(R.string.network_lte).equals(oldEntry)) {
+ oldEntry = mContext.getString(R.string.network_lte_pure);
+ new5gEntry = mContext.getString(R.string.network_5G)
+ + mContext.getString(R.string.network_recommended);
+ new5gEntryValue = transformLteEntryValueTo5gEntryValue(oldEntryValue);
+ } else if (mContext.getString(R.string.network_4G).equals(oldEntry)) {
+ oldEntry = mContext.getString(R.string.network_4G_pure);
+ new5gEntry = mContext.getString(R.string.network_5G)
+ + mContext.getString(R.string.network_recommended);
+ new5gEntryValue = transformLteEntryValueTo5gEntryValue(oldEntryValue);
+ } else if (mContext.getString(R.string.network_global).equals(oldEntry)) {
+ //oldEntry: network_global
+ //oldEntryValue: TelephonyManager.NETWORK_MODE_NR_LTE_CDMA_EVDO_GSM_WCDMA
+ oldEntryValue = Integer.toString(
+ TelephonyManager.NETWORK_MODE_NR_LTE_CDMA_EVDO_GSM_WCDMA);
+ }
+
+ if (!TextUtils.isEmpty(new5gEntry)) {
+ newEntries.add(new5gEntry);
+ newEntryValues.add(new5gEntryValue);
+ }
+ newEntries.add(oldEntry);
+ newEntryValues.add(oldEntryValue);
+ }
+
+ preference.setEntries(newEntries.toArray(new CharSequence[newEntries.size()]));
+ preference.setEntryValues(newEntryValues.toArray(new CharSequence[newEntryValues.size()]));
+ }
+
+ /**
+ * LTE network mode transform to 5G network mode.
+ *
+ * @param networkMode this is LTE network mode.
+ * @return 5G network mode.
+ */
+ private CharSequence transformLteEntryValueTo5gEntryValue(CharSequence networkMode) {
+ int networkModeInt = Integer.valueOf(networkMode.toString());
+ return Integer.toString(addNrToNetworkType(networkModeInt));
+ }
+
+ private int addNrToNetworkType(int networkType) {
+ long networkTypeBitmasks = RadioAccessFamily.getRafFromNetworkType(networkType);
+ networkTypeBitmasks |= mTelephonyManager.NETWORK_TYPE_BITMASK_NR;
+ return RadioAccessFamily.getNetworkTypeFromRaf((int) networkTypeBitmasks);
}
private void updatePreferenceValueAndSummary(ListPreference preference, int networkMode) {
@@ -312,7 +459,8 @@
} else {
preference.setValue(
Integer.toString(TelephonyManager.NETWORK_MODE_LTE_CDMA_EVDO));
- preference.setSummary(R.string.network_lte);
+ preference.setSummary(
+ mDisplay5gList ? R.string.network_lte_pure : R.string.network_lte);
}
break;
case TelephonyManager.NETWORK_MODE_TDSCDMA_CDMA_EVDO_GSM_WCDMA:
@@ -347,7 +495,8 @@
preference.setValue(
Integer.toString(TelephonyManager
.NETWORK_MODE_LTE_TDSCDMA_CDMA_EVDO_GSM_WCDMA));
- preference.setSummary(R.string.network_lte);
+ preference.setSummary(
+ mDisplay5gList ? R.string.network_lte_pure : R.string.network_lte);
} else {
preference.setValue(
Integer.toString(TelephonyManager
@@ -357,11 +506,34 @@
|| MobileNetworkUtils.isWorldMode(mContext, mSubId)) {
preference.setSummary(R.string.network_global);
} else {
- preference.setSummary(mShow4GForLTE
- ? R.string.network_4G : R.string.network_lte);
+ if (mDisplay5gList) {
+ preference.setSummary(mShow4GForLTE
+ ? R.string.network_4G_pure : R.string.network_lte_pure);
+ } else {
+ preference.setSummary(mShow4GForLTE
+ ? R.string.network_4G : R.string.network_lte);
+ }
}
}
break;
+ case TelephonyManager.NETWORK_MODE_NR_LTE_CDMA_EVDO:
+ case TelephonyManager.NETWORK_MODE_NR_LTE_TDSCDMA_CDMA_EVDO_GSM_WCDMA:
+ preference.setValue(Integer.toString(networkMode));
+ preference.setSummary(mContext.getString(R.string.network_5G)
+ + mContext.getString(R.string.network_recommended));
+ break;
+ case TelephonyManager.NETWORK_MODE_NR_LTE_CDMA_EVDO_GSM_WCDMA:
+ preference.setValue(
+ Integer.toString(TelephonyManager.NETWORK_MODE_NR_LTE_CDMA_EVDO_GSM_WCDMA));
+ if (mTelephonyManager.getPhoneType() == PhoneConstants.PHONE_TYPE_CDMA
+ || mIsGlobalCdma
+ || MobileNetworkUtils.isWorldMode(mContext, mSubId)) {
+ preference.setSummary(R.string.network_global);
+ } else {
+ preference.setSummary(mContext.getString(R.string.network_5G)
+ + mContext.getString(R.string.network_recommended));
+ }
+ break;
default:
preference.setSummary(
mContext.getString(R.string.mobile_network_mode_error, networkMode));
diff --git a/src/com/android/settings/nfc/PaymentSettings.java b/src/com/android/settings/nfc/PaymentSettings.java
index 560ddbf..bbe5f29 100644
--- a/src/com/android/settings/nfc/PaymentSettings.java
+++ b/src/com/android/settings/nfc/PaymentSettings.java
@@ -30,6 +30,10 @@
import android.view.View;
import android.view.ViewGroup;
+import androidx.annotation.VisibleForTesting;
+import androidx.preference.Preference;
+import androidx.preference.PreferenceScreen;
+
import com.android.settings.R;
import com.android.settings.dashboard.DashboardFragment;
import com.android.settings.search.BaseSearchIndexProvider;
@@ -70,10 +74,11 @@
@Override
public void onViewCreated(View view, Bundle savedInstanceState) {
super.onViewCreated(view, savedInstanceState);
-
- View emptyView = getActivity().getLayoutInflater().inflate(
- R.layout.nfc_payment_empty, null, false);
- ((ViewGroup) view.findViewById(android.R.id.list_container)).addView(emptyView);
+ if (isShowEmptyImage(getPreferenceScreen())) {
+ View emptyView = getActivity().getLayoutInflater().inflate(
+ R.layout.nfc_payment_empty, null, false);
+ ((ViewGroup) view.findViewById(android.R.id.list_container)).addView(emptyView);
+ }
}
@Override
@@ -97,6 +102,17 @@
menuItem.setShowAsActionFlags(MenuItem.SHOW_AS_ACTION_NEVER);
}
+ @VisibleForTesting
+ boolean isShowEmptyImage(PreferenceScreen screen) {
+ for (int i = 0; i < screen.getPreferenceCount(); i++) {
+ final Preference preference = screen.getPreference(i);
+ if(preference.isVisible()) {
+ return false;
+ }
+ }
+ return true;
+ }
+
public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER =
new BaseSearchIndexProvider(R.xml.nfc_payment_settings) {
diff --git a/src/com/android/settings/notification/ConfigureNotificationPreferenceController.java b/src/com/android/settings/notification/ConfigureNotificationPreferenceController.java
new file mode 100644
index 0000000..3aa1008
--- /dev/null
+++ b/src/com/android/settings/notification/ConfigureNotificationPreferenceController.java
@@ -0,0 +1,48 @@
+/*
+ * Copyright (C) 2019 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License
+ */
+
+package com.android.settings.notification;
+
+import android.content.Context;
+
+import com.android.settings.R;
+import com.android.settings.core.BasePreferenceController;
+
+public class ConfigureNotificationPreferenceController extends BasePreferenceController {
+
+ private NotificationBackend mBackend;
+
+ public ConfigureNotificationPreferenceController(Context context, String key) {
+ super(context, key);
+ mBackend = new NotificationBackend();
+ }
+
+ @Override
+ public int getAvailabilityStatus() {
+ return AVAILABLE;
+ }
+
+ @Override
+ public CharSequence getSummary() {
+ final int blockedAppCount = mBackend.getBlockedAppCount();
+ if (blockedAppCount == 0) {
+ return mContext.getText(R.string.app_notification_listing_summary_zero);
+ }
+ return mContext.getResources().getQuantityString(
+ R.plurals.app_notification_listing_summary_others,
+ blockedAppCount, blockedAppCount);
+ }
+}
\ No newline at end of file
diff --git a/src/com/android/settings/notification/ConfigureNotificationSettings.java b/src/com/android/settings/notification/ConfigureNotificationSettings.java
index ff8e94a..abbd9a7 100644
--- a/src/com/android/settings/notification/ConfigureNotificationSettings.java
+++ b/src/com/android/settings/notification/ConfigureNotificationSettings.java
@@ -40,7 +40,6 @@
import com.android.settings.RingtonePreference;
import com.android.settings.core.OnActivityResultListener;
import com.android.settings.dashboard.DashboardFragment;
-import com.android.settings.dashboard.SummaryLoader;
import com.android.settings.search.BaseSearchIndexProvider;
import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.search.SearchIndexable;
@@ -163,54 +162,6 @@
}
/**
- * For summary
- */
- static class SummaryProvider implements SummaryLoader.SummaryProvider {
-
- private final Context mContext;
- private final SummaryLoader mSummaryLoader;
- private NotificationBackend mBackend;
-
- public SummaryProvider(Context context, SummaryLoader summaryLoader) {
- mContext = context;
- mSummaryLoader = summaryLoader;
- mBackend = new NotificationBackend();
- }
-
- @VisibleForTesting
- protected void setBackend(NotificationBackend backend) {
- mBackend = backend;
- }
-
- @Override
- public void setListening(boolean listening) {
- if (!listening) {
- return;
- }
- int blockedAppCount = mBackend.getBlockedAppCount();
- if (blockedAppCount == 0) {
- mSummaryLoader.setSummary(this,
- mContext.getText(R.string.app_notification_listing_summary_zero));
- } else {
- mSummaryLoader.setSummary(this,
- mContext.getResources().getQuantityString(
- R.plurals.app_notification_listing_summary_others,
- blockedAppCount, blockedAppCount));
- }
- }
- }
-
- public static final SummaryLoader.SummaryProviderFactory SUMMARY_PROVIDER_FACTORY =
- new SummaryLoader.SummaryProviderFactory() {
- @Override
- public SummaryLoader.SummaryProvider createSummaryProvider(Activity activity,
- SummaryLoader summaryLoader) {
- return new ConfigureNotificationSettings.SummaryProvider(
- activity, summaryLoader);
- }
- };
-
- /**
* For Search.
*/
public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER =
diff --git a/src/com/android/settings/password/BiometricFragment.java b/src/com/android/settings/password/BiometricFragment.java
index 66b665b..9898719 100644
--- a/src/com/android/settings/password/BiometricFragment.java
+++ b/src/com/android/settings/password/BiometricFragment.java
@@ -24,7 +24,6 @@
import android.hardware.biometrics.BiometricPrompt;
import android.hardware.biometrics.BiometricPrompt.AuthenticationCallback;
import android.hardware.biometrics.BiometricPrompt.AuthenticationResult;
-import android.hardware.biometrics.IBiometricConfirmDeviceCredentialCallback;
import android.os.Bundle;
import android.os.CancellationSignal;
import android.os.Handler;
@@ -91,20 +90,6 @@
}
};
- // TODO(b/123378871): Remove when moved.
- private final IBiometricConfirmDeviceCredentialCallback mCancelCallback
- = new IBiometricConfirmDeviceCredentialCallback.Stub() {
- @Override
- public void cancel() {
- final Activity activity = getActivity();
- if (activity != null) {
- activity.finish();
- } else {
- Log.e(TAG, "Activity null!");
- }
- }
- };
-
/**
* @param bundle Bundle passed from {@link BiometricPrompt.Builder#buildIntent()}
* @return
@@ -150,46 +135,19 @@
final BiometricPrompt.Builder builder = new BiometricPrompt.Builder(getContext())
.setTitle(mBundle.getString(BiometricPrompt.KEY_TITLE))
.setUseDefaultTitle() // use default title if title is null/empty
- .setFromConfirmDeviceCredential()
+ .setDeviceCredentialAllowed(true)
.setSubtitle(mBundle.getString(BiometricPrompt.KEY_SUBTITLE))
.setDescription(mBundle.getString(BiometricPrompt.KEY_DESCRIPTION))
.setConfirmationRequired(
mBundle.getBoolean(BiometricPrompt.KEY_REQUIRE_CONFIRMATION, true));
- final LockPatternUtils lockPatternUtils = FeatureFactory.getFactory(
- getContext())
- .getSecurityFeatureProvider()
- .getLockPatternUtils(getContext());
-
- switch (lockPatternUtils.getKeyguardStoredPasswordQuality(mUserId)) {
- case DevicePolicyManager.PASSWORD_QUALITY_SOMETHING:
- builder.setNegativeButton(getResources().getString(
- R.string.confirm_device_credential_pattern),
- mClientExecutor, mNegativeButtonListener);
- break;
- case DevicePolicyManager.PASSWORD_QUALITY_NUMERIC:
- case DevicePolicyManager.PASSWORD_QUALITY_NUMERIC_COMPLEX:
- builder.setNegativeButton(getResources().getString(
- R.string.confirm_device_credential_pin),
- mClientExecutor, mNegativeButtonListener);
- break;
- case DevicePolicyManager.PASSWORD_QUALITY_ALPHABETIC:
- case DevicePolicyManager.PASSWORD_QUALITY_ALPHANUMERIC:
- case DevicePolicyManager.PASSWORD_QUALITY_COMPLEX:
- case DevicePolicyManager.PASSWORD_QUALITY_MANAGED:
- builder.setNegativeButton(getResources().getString(
- R.string.confirm_device_credential_password),
- mClientExecutor, mNegativeButtonListener);
- break;
- }
-
mBiometricPrompt = builder.build();
mCancellationSignal = new CancellationSignal();
// TODO: CC doesn't use crypto for now
mAuthenticating = true;
mBiometricPrompt.authenticateUser(mCancellationSignal, mClientExecutor,
- mAuthenticationCallback, mUserId, mCancelCallback);
+ mAuthenticationCallback, mUserId);
}
@Override
diff --git a/src/com/android/settings/password/ChooseLockGeneric.java b/src/com/android/settings/password/ChooseLockGeneric.java
index 4e2e90d..f86292b 100644
--- a/src/com/android/settings/password/ChooseLockGeneric.java
+++ b/src/com/android/settings/password/ChooseLockGeneric.java
@@ -725,30 +725,6 @@
}
/**
- * Keeps track of the biometric removal status. When all biometrics (including managed
- * profiles) are removed, finishes the activity. Otherwise, it's possible the UI still
- * shows enrolled biometrics due to the async remove.
- */
- private class RemovalTracker {
- boolean mFingerprintDone;
- boolean mFaceDone;
-
- void onFingerprintDone() {
- mFingerprintDone = true;
- if (mFingerprintDone && mFaceDone) {
- finish();
- }
- }
-
- void onFaceDone() {
- mFaceDone = true;
- if (mFingerprintDone && mFaceDone) {
- finish();
- }
- }
- }
-
- /**
* Invokes an activity to change the user's pattern, password or PIN based on given quality
* and minimum quality specified by DevicePolicyManager. If quality is
* {@link DevicePolicyManager#PASSWORD_QUALITY_UNSPECIFIED}, password is cleared.
@@ -781,21 +757,15 @@
}
if (quality == DevicePolicyManager.PASSWORD_QUALITY_UNSPECIFIED) {
+ // Clearing of user biometrics when screen lock is cleared is done at
+ // LockSettingsService.removeBiometricsForUser().
mChooseLockSettingsHelper.utils().clearLock(mUserPassword, mUserId);
mChooseLockSettingsHelper.utils().setLockScreenDisabled(disabled, mUserId);
getActivity().setResult(Activity.RESULT_OK);
- removeAllBiometricsForUserAndFinish(mUserId);
- } else {
- removeAllBiometricsForUserAndFinish(mUserId);
+ finish();
}
}
- private void removeAllBiometricsForUserAndFinish(final int userId) {
- final RemovalTracker tracker = new RemovalTracker();
- removeAllFingerprintForUserAndFinish(userId, tracker);
- removeAllFaceForUserAndFinish(userId, tracker);
- }
-
private Intent getIntentForUnlockMethod(int quality) {
Intent intent = null;
if (quality >= DevicePolicyManager.PASSWORD_QUALITY_MANAGED) {
@@ -808,128 +778,6 @@
return intent;
}
- private void removeAllFingerprintForUserAndFinish(final int userId,
- RemovalTracker tracker) {
- if (mFingerprintManager != null && mFingerprintManager.isHardwareDetected()) {
- if (mFingerprintManager.hasEnrolledFingerprints(userId)) {
- mFingerprintManager.setActiveUser(userId);
- // For the purposes of M and N, groupId is the same as userId.
- final int groupId = userId;
- Fingerprint finger = new Fingerprint(null, groupId, 0, 0);
- mFingerprintManager.remove(finger, userId,
- new RemovalCallback() {
- @Override
- public void onRemovalError(Fingerprint fp, int errMsgId,
- CharSequence errString) {
- Log.e(TAG, String.format(
- "Can't remove fingerprint %d in group %d. Reason: %s",
- fp.getBiometricId(), fp.getGroupId(), errString));
- // TODO: need to proceed with the removal of managed profile
- // fingerprints and finish() gracefully.
- }
-
- @Override
- public void onRemovalSucceeded(Fingerprint fp, int remaining) {
- if (remaining == 0) {
- removeManagedProfileFingerprintsAndFinishIfNecessary(userId,
- tracker);
- }
- }
- });
- } else {
- // No fingerprints in this user, we may also want to delete managed profile
- // fingerprints
- removeManagedProfileFingerprintsAndFinishIfNecessary(userId, tracker);
- }
- } else {
- // The removal callback will call finish, once all fingerprints are removed.
- // We need to wait for that to occur, otherwise, the UI will still show that
- // fingerprints exist even though they are (about to) be removed depending on
- // the race condition.
- tracker.onFingerprintDone();
- }
- }
-
- private void removeManagedProfileFingerprintsAndFinishIfNecessary(final int parentUserId,
- RemovalTracker tracker) {
- if (mFingerprintManager != null && mFingerprintManager.isHardwareDetected()) {
- mFingerprintManager.setActiveUser(UserHandle.myUserId());
- }
- boolean hasChildProfile = false;
- if (!mUserManager.getUserInfo(parentUserId).isManagedProfile()) {
- // Current user is primary profile, remove work profile fingerprints if necessary
- final List<UserInfo> profiles = mUserManager.getProfiles(parentUserId);
- final int profilesSize = profiles.size();
- for (int i = 0; i < profilesSize; i++) {
- final UserInfo userInfo = profiles.get(i);
- if (userInfo.isManagedProfile() && !mLockPatternUtils
- .isSeparateProfileChallengeEnabled(userInfo.id)) {
- removeAllFingerprintForUserAndFinish(userInfo.id, tracker);
- hasChildProfile = true;
- break;
- }
- }
- }
- if (!hasChildProfile) {
- tracker.onFingerprintDone();
- }
- }
-
- // TODO: figure out how to eliminate duplicated code. It's a bit hard due to the async-ness
- private void removeAllFaceForUserAndFinish(final int userId, RemovalTracker tracker) {
- if (mFaceManager != null && mFaceManager.isHardwareDetected()) {
- if (mFaceManager.hasEnrolledTemplates(userId)) {
- mFaceManager.setActiveUser(userId);
- Face face = new Face(null, 0, 0);
- mFaceManager.remove(face, userId,
- new FaceManager.RemovalCallback() {
- @Override
- public void onRemovalError(Face face, int errMsgId, CharSequence err) {
- Log.e(TAG, String.format("Can't remove face %d. Reason: %s",
- face.getBiometricId(), err));
- }
- @Override
- public void onRemovalSucceeded(Face face, int remaining) {
- if (remaining == 0) {
- removeManagedProfileFacesAndFinishIfNecessary(userId, tracker);
- }
- }
- });
- } else {
- // No faces in this user, we may also want to delete managed profile faces
- removeManagedProfileFacesAndFinishIfNecessary(userId, tracker);
- }
- } else {
- tracker.onFaceDone();
- }
- }
-
- // TODO: figure out how to eliminate duplicated code. It's a bit hard due to the async-ness
- private void removeManagedProfileFacesAndFinishIfNecessary(final int parentUserId,
- RemovalTracker tracker) {
- if (mFaceManager != null && mFaceManager.isHardwareDetected()) {
- mFaceManager.setActiveUser(UserHandle.myUserId());
- }
- boolean hasChildProfile = false;
- if (!mUserManager.getUserInfo(parentUserId).isManagedProfile()) {
- // Current user is primary profile, remove work profile faces if necessary
- final List<UserInfo> profiles = mUserManager.getProfiles(parentUserId);
- final int profilesSize = profiles.size();
- for (int i = 0; i < profilesSize; i++) {
- final UserInfo userInfo = profiles.get(i);
- if (userInfo.isManagedProfile() && !mLockPatternUtils
- .isSeparateProfileChallengeEnabled(userInfo.id)) {
- removeAllFaceForUserAndFinish(userInfo.id, tracker);
- hasChildProfile = true;
- break;
- }
- }
- }
- if (!hasChildProfile) {
- tracker.onFaceDone();
- }
- }
-
@Override
public void onDestroy() {
super.onDestroy();
diff --git a/src/com/android/settings/password/ConfirmDeviceCredentialActivity.java b/src/com/android/settings/password/ConfirmDeviceCredentialActivity.java
index 8476f92..1da2a63 100644
--- a/src/com/android/settings/password/ConfirmDeviceCredentialActivity.java
+++ b/src/com/android/settings/password/ConfirmDeviceCredentialActivity.java
@@ -90,8 +90,6 @@
private TrustManager mTrustManager;
private ChooseLockSettingsHelper mChooseLockSettingsHelper;
private Handler mHandler = new Handler(Looper.getMainLooper());
- private boolean mIsFallback; // BiometricPrompt fallback
- private boolean mCCLaunched;
private String mTitle;
private String mDetails;
@@ -108,10 +106,6 @@
if (!mGoingToBackground) {
if (errorCode == BiometricPrompt.BIOMETRIC_ERROR_USER_CANCELED
|| errorCode == BiometricPrompt.BIOMETRIC_ERROR_CANCELED) {
- if (mIsFallback) {
- mBiometricManager.onConfirmDeviceCredentialError(
- errorCode, getStringForError(errorCode));
- }
finish();
} else {
// All other errors go to some version of CC
@@ -128,10 +122,6 @@
ConfirmDeviceCredentialUtils.checkForPendingIntent(
ConfirmDeviceCredentialActivity.this);
- if (mIsFallback) {
- mBiometricManager.onConfirmDeviceCredentialSuccess();
- }
-
setResult(Activity.RESULT_OK);
finish();
}
@@ -183,17 +173,11 @@
mChooseLockSettingsHelper = new ChooseLockSettingsHelper(this);
final LockPatternUtils lockPatternUtils = new LockPatternUtils(this);
- Bundle bpBundle =
- intent.getBundleExtra(KeyguardManager.EXTRA_BIOMETRIC_PROMPT_BUNDLE);
- if (bpBundle != null) {
- mIsFallback = true;
- mTitle = bpBundle.getString(BiometricPrompt.KEY_TITLE);
- mDetails = bpBundle.getString(BiometricPrompt.KEY_SUBTITLE);
- } else {
- bpBundle = new Bundle();
- bpBundle.putString(BiometricPrompt.KEY_TITLE, mTitle);
- bpBundle.putString(BiometricPrompt.KEY_DESCRIPTION, mDetails);
- }
+ final Bundle bpBundle = new Bundle();
+ mTitle = bpBundle.getString(BiometricPrompt.KEY_TITLE);
+ mDetails = bpBundle.getString(BiometricPrompt.KEY_SUBTITLE);
+ bpBundle.putString(BiometricPrompt.KEY_TITLE, mTitle);
+ bpBundle.putString(BiometricPrompt.KEY_DESCRIPTION, mDetails);
boolean launchedBiometric = false;
boolean launchedCDC = false;
@@ -257,12 +241,6 @@
}
}
- if (mIsFallback && !mCCLaunched) {
- mBiometricManager.onConfirmDeviceCredentialError(
- BiometricConstants.BIOMETRIC_ERROR_CANCELED,
- getString(com.android.internal.R.string.biometric_error_user_canceled));
- }
-
finish();
} else {
mGoingToBackground = false;
@@ -314,7 +292,6 @@
* Shows ConfirmDeviceCredentials for normal apps.
*/
private void showConfirmCredentials() {
- mCCLaunched = true;
boolean launched = false;
// The only difference between CREDENTIAL_MANAGED and CREDENTIAL_NORMAL is that for
// CREDENTIAL_MANAGED, we launch the real confirm credential activity with an explicit
diff --git a/src/com/android/settings/password/ConfirmDeviceCredentialBaseActivity.java b/src/com/android/settings/password/ConfirmDeviceCredentialBaseActivity.java
index 5407776..a30d2e1 100644
--- a/src/com/android/settings/password/ConfirmDeviceCredentialBaseActivity.java
+++ b/src/com/android/settings/password/ConfirmDeviceCredentialBaseActivity.java
@@ -17,15 +17,12 @@
package com.android.settings.password;
import android.app.KeyguardManager;
-import android.hardware.biometrics.BiometricConstants;
import android.hardware.biometrics.BiometricManager;
-import android.hardware.biometrics.IBiometricConfirmDeviceCredentialCallback;
import android.os.Bundle;
import android.os.UserManager;
import android.util.Log;
import android.view.MenuItem;
import android.view.WindowManager;
-import android.widget.LinearLayout;
import androidx.fragment.app.Fragment;
@@ -50,16 +47,6 @@
private boolean mFirstTimeVisible = true;
private boolean mIsKeyguardLocked = false;
private ConfirmCredentialTheme mConfirmCredentialTheme;
- private BiometricManager mBiometricManager;
-
- // TODO(b/123378871): Remove when moved.
- private final IBiometricConfirmDeviceCredentialCallback mCancelCallback
- = new IBiometricConfirmDeviceCredentialCallback.Stub() {
- @Override
- public void cancel() {
- finish();
- }
- };
private boolean isInternalActivity() {
return (this instanceof ConfirmLockPassword.InternalActivity)
@@ -90,9 +77,6 @@
}
super.onCreate(savedState);
- mBiometricManager = getSystemService(BiometricManager.class);
- mBiometricManager.registerCancellationCallback(mCancelCallback);
-
if (mConfirmCredentialTheme == ConfirmCredentialTheme.NORMAL) {
// Prevent the content parent from consuming the window insets because GlifLayout uses
// it to show the status bar background.
@@ -167,15 +151,10 @@
@Override
public void onStop() {
super.onStop();
- // TODO(b/123378871): Remove when moved.
- if (!isChangingConfigurations()) {
- mBiometricManager.onConfirmDeviceCredentialError(
- BiometricConstants.BIOMETRIC_ERROR_USER_CANCELED,
- getString(com.android.internal.R.string.biometric_error_user_canceled));
- if (getIntent().getBooleanExtra(
- ChooseLockSettingsHelper.EXTRA_KEY_FOREGROUND_ONLY, false)) {
- finish();
- }
+ final boolean foregroundOnly = getIntent().getBooleanExtra(
+ ChooseLockSettingsHelper.EXTRA_KEY_FOREGROUND_ONLY, false);
+ if (!isChangingConfigurations() && foregroundOnly) {
+ finish();
}
}
diff --git a/src/com/android/settings/password/ConfirmLockPassword.java b/src/com/android/settings/password/ConfirmLockPassword.java
index 12b2724..5c891cd 100644
--- a/src/com/android/settings/password/ConfirmLockPassword.java
+++ b/src/com/android/settings/password/ConfirmLockPassword.java
@@ -446,7 +446,6 @@
ConfirmDeviceCredentialUtils.reportSuccessfulAttempt(mLockPatternUtils,
mUserManager, mEffectiveUserId);
}
- mBiometricManager.onConfirmDeviceCredentialSuccess();
startDisappearAnimation(intent);
ConfirmDeviceCredentialUtils.checkForPendingIntent(getActivity());
} else {
diff --git a/src/com/android/settings/password/ConfirmLockPattern.java b/src/com/android/settings/password/ConfirmLockPattern.java
index f43ee7f..b1d8e60 100644
--- a/src/com/android/settings/password/ConfirmLockPattern.java
+++ b/src/com/android/settings/password/ConfirmLockPattern.java
@@ -490,7 +490,6 @@
ConfirmDeviceCredentialUtils.reportSuccessfulAttempt(mLockPatternUtils,
mUserManager, mEffectiveUserId);
}
- mBiometricManager.onConfirmDeviceCredentialSuccess();
startDisappearAnimation(intent);
ConfirmDeviceCredentialUtils.checkForPendingIntent(getActivity());
} else {
diff --git a/src/com/android/settings/slices/SlicePreference.java b/src/com/android/settings/slices/SlicePreference.java
index acf45ef..a2a7fe1 100644
--- a/src/com/android/settings/slices/SlicePreference.java
+++ b/src/com/android/settings/slices/SlicePreference.java
@@ -18,6 +18,7 @@
import android.content.Context;
import android.util.AttributeSet;
+import android.view.View;
import androidx.slice.Slice;
import androidx.slice.widget.SliceView;
@@ -48,6 +49,11 @@
}
public void onSliceUpdated(Slice slice) {
+ if (slice == null) {
+ mSliceView.setVisibility(View.GONE);
+ } else {
+ mSliceView.setVisibility(View.VISIBLE);
+ }
mSliceView.onChanged(slice);
notifyChanged();
}
diff --git a/src/com/android/settings/slices/SlicePreferenceController.java b/src/com/android/settings/slices/SlicePreferenceController.java
index 2432c99..8f3d0fb 100644
--- a/src/com/android/settings/slices/SlicePreferenceController.java
+++ b/src/com/android/settings/slices/SlicePreferenceController.java
@@ -18,6 +18,7 @@
import android.content.Context;
import android.net.Uri;
+import android.util.Log;
import androidx.annotation.VisibleForTesting;
import androidx.lifecycle.LiveData;
@@ -38,6 +39,7 @@
*/
public class SlicePreferenceController extends BasePreferenceController implements
LifecycleObserver, OnStart, OnStop, Observer<Slice> {
+ private static final String TAG = "SlicePreferenceController";
@VisibleForTesting
LiveData<Slice> mLiveData;
@VisibleForTesting
@@ -61,7 +63,10 @@
public void setSliceUri(Uri uri) {
mUri = uri;
- mLiveData = SliceLiveData.fromUri(mContext, mUri);
+ mLiveData = SliceLiveData.fromUri(mContext, mUri, (int type, Throwable source) -> {
+ Log.w(TAG, "Slice may be null. uri = " + uri + ", error = " + type);
+ onChanged(null);
+ });
//TODO(b/120803703): figure out why we need to remove observer first
mLiveData.removeObserver(this);
diff --git a/src/com/android/settings/users/UserSettings.java b/src/com/android/settings/users/UserSettings.java
index 2463295..5ad68fe 100644
--- a/src/com/android/settings/users/UserSettings.java
+++ b/src/com/android/settings/users/UserSettings.java
@@ -63,7 +63,6 @@
import com.android.settings.SettingsPreferenceFragment;
import com.android.settings.Utils;
import com.android.settings.core.SubSettingLauncher;
-import com.android.settings.dashboard.SummaryLoader;
import com.android.settings.password.ChooseLockGeneric;
import com.android.settings.search.BaseSearchIndexProvider;
import com.android.settings.widget.SwitchBar;
@@ -1195,30 +1194,6 @@
}
}
- private static class SummaryProvider implements SummaryLoader.SummaryProvider {
-
- private final Context mContext;
- private final SummaryLoader mSummaryLoader;
-
- public SummaryProvider(Context context, SummaryLoader summaryLoader) {
- mContext = context;
- mSummaryLoader = summaryLoader;
- }
-
- @Override
- public void setListening(boolean listening) {
- if (listening) {
- UserInfo info = mContext.getSystemService(UserManager.class).getUserInfo(
- UserHandle.myUserId());
- mSummaryLoader.setSummary(this, mContext.getString(R.string.users_summary,
- info.name));
- }
- }
- }
-
- public static final SummaryLoader.SummaryProviderFactory SUMMARY_PROVIDER_FACTORY =
- (activity, summaryLoader) -> new SummaryProvider(activity, summaryLoader);
-
public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER =
new BaseSearchIndexProvider(R.xml.user_settings) {
diff --git a/src/com/android/settings/wfd/WifiDisplayPreferenceController.java b/src/com/android/settings/wfd/WifiDisplayPreferenceController.java
new file mode 100644
index 0000000..3227387
--- /dev/null
+++ b/src/com/android/settings/wfd/WifiDisplayPreferenceController.java
@@ -0,0 +1,107 @@
+/*
+ * Copyright (C) 2019 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License
+ */
+
+package com.android.settings.wfd;
+
+import android.content.Context;
+import android.media.MediaRouter;
+import android.media.MediaRouter.RouteInfo;
+
+import androidx.preference.Preference;
+import androidx.preference.PreferenceScreen;
+
+import com.android.settings.R;
+import com.android.settings.core.BasePreferenceController;
+import com.android.settingslib.core.lifecycle.LifecycleObserver;
+import com.android.settingslib.core.lifecycle.events.OnStart;
+import com.android.settingslib.core.lifecycle.events.OnStop;
+
+public class WifiDisplayPreferenceController extends BasePreferenceController implements
+ LifecycleObserver, OnStart, OnStop {
+
+ private final MediaRouter mRouter;
+ private Preference mPreference;
+ private final MediaRouter.Callback mRouterCallback = new MediaRouter.SimpleCallback() {
+ @Override
+ public void onRouteSelected(MediaRouter router, int type, RouteInfo info) {
+ refreshSummary(mPreference);
+ }
+
+ @Override
+ public void onRouteUnselected(MediaRouter router, int type, RouteInfo info) {
+ refreshSummary(mPreference);
+ }
+
+ @Override
+ public void onRouteAdded(MediaRouter router, RouteInfo info) {
+ refreshSummary(mPreference);
+ }
+
+ @Override
+ public void onRouteRemoved(MediaRouter router, RouteInfo info) {
+ refreshSummary(mPreference);
+ }
+
+ @Override
+ public void onRouteChanged(MediaRouter router, RouteInfo info) {
+ refreshSummary(mPreference);
+ }
+ };
+
+ public WifiDisplayPreferenceController(Context context, String key) {
+ super(context, key);
+ mRouter = context.getSystemService(MediaRouter.class);
+ mRouter.setRouterGroupId(MediaRouter.MIRRORING_GROUP_ID);
+ }
+
+ @Override
+ public int getAvailabilityStatus() {
+ return WifiDisplaySettings.isAvailable(mContext) ? AVAILABLE_UNSEARCHABLE
+ : UNSUPPORTED_ON_DEVICE;
+ }
+
+ @Override
+ public void displayPreference(PreferenceScreen screen) {
+ super.displayPreference(screen);
+ mPreference = screen.findPreference(getPreferenceKey());
+ }
+
+ @Override
+ public CharSequence getSummary() {
+ CharSequence summary = mContext.getString(R.string.disconnected);
+
+ final int routeCount = mRouter.getRouteCount();
+ for (int i = 0; i < routeCount; i++) {
+ final MediaRouter.RouteInfo route = mRouter.getRouteAt(i);
+ if (route.matchesTypes(MediaRouter.ROUTE_TYPE_REMOTE_DISPLAY)
+ && route.isSelected() && !route.isConnecting()) {
+ summary = mContext.getString(R.string.wifi_display_status_connected);
+ break;
+ }
+ }
+ return summary;
+ }
+
+ @Override
+ public void onStart() {
+ mRouter.addCallback(MediaRouter.ROUTE_TYPE_REMOTE_DISPLAY, mRouterCallback);
+ }
+
+ @Override
+ public void onStop() {
+ mRouter.removeCallback(mRouterCallback);
+ }
+}
\ No newline at end of file
diff --git a/src/com/android/settings/wfd/WifiDisplaySettings.java b/src/com/android/settings/wfd/WifiDisplaySettings.java
index 0953ef7..4022809 100755
--- a/src/com/android/settings/wfd/WifiDisplaySettings.java
+++ b/src/com/android/settings/wfd/WifiDisplaySettings.java
@@ -37,7 +37,6 @@
import android.os.Bundle;
import android.os.Handler;
import android.os.Looper;
-import android.provider.SearchIndexableResource;
import android.provider.Settings;
import android.util.Slog;
import android.util.TypedValue;
@@ -64,15 +63,11 @@
import com.android.internal.app.MediaRouteDialogPresenter;
import com.android.settings.R;
import com.android.settings.SettingsPreferenceFragment;
-import com.android.settings.dashboard.SummaryLoader;
import com.android.settings.search.BaseSearchIndexProvider;
-import com.android.settingslib.search.Indexable;
import com.android.settingslib.TwoTargetPreference;
+import com.android.settingslib.search.Indexable;
import com.android.settingslib.search.SearchIndexable;
-import java.util.ArrayList;
-import java.util.List;
-
/**
* The Settings screen for WifiDisplay configuration and connection management.
*
@@ -767,74 +762,6 @@
}
}
- private static class SummaryProvider implements SummaryLoader.SummaryProvider {
-
- private final Context mContext;
- private final SummaryLoader mSummaryLoader;
- private final MediaRouter mRouter;
- private final MediaRouter.Callback mRouterCallback = new MediaRouter.SimpleCallback() {
- @Override
- public void onRouteSelected(MediaRouter router, int type, RouteInfo info) {
- updateSummary();
- }
-
- @Override
- public void onRouteUnselected(MediaRouter router, int type, RouteInfo info) {
- updateSummary();
- }
-
- @Override
- public void onRouteAdded(MediaRouter router, RouteInfo info) {
- updateSummary();
- }
-
- @Override
- public void onRouteRemoved(MediaRouter router, RouteInfo info) {
- updateSummary();
- }
-
- @Override
- public void onRouteChanged(MediaRouter router, RouteInfo info) {
- updateSummary();
- }
- };
-
- public SummaryProvider(Context context, SummaryLoader summaryLoader) {
- mContext = context;
- mSummaryLoader = summaryLoader;
- mRouter = (MediaRouter) context.getSystemService(Context.MEDIA_ROUTER_SERVICE);
- mRouter.setRouterGroupId(MediaRouter.MIRRORING_GROUP_ID);
- }
-
- @Override
- public void setListening(boolean listening) {
- if (listening) {
- mRouter.addCallback(MediaRouter.ROUTE_TYPE_REMOTE_DISPLAY, mRouterCallback);
- updateSummary();
- } else {
- mRouter.removeCallback(mRouterCallback);
- }
- }
-
- private void updateSummary() {
- String summary = mContext.getString(R.string.disconnected);
-
- final int routeCount = mRouter.getRouteCount();
- for (int i = 0; i < routeCount; i++) {
- final MediaRouter.RouteInfo route = mRouter.getRouteAt(i);
- if (route.matchesTypes(MediaRouter.ROUTE_TYPE_REMOTE_DISPLAY)
- && route.isSelected() && !route.isConnecting()) {
- summary = mContext.getString(R.string.wifi_display_status_connected);
- break;
- }
- }
- mSummaryLoader.setSummary(this, summary);
- }
- }
-
- public static final SummaryLoader.SummaryProviderFactory SUMMARY_PROVIDER_FACTORY
- = (activity, summaryLoader) -> new SummaryProvider(activity, summaryLoader);
-
public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER =
new BaseSearchIndexProvider(R.xml.wifi_display_settings);
}
diff --git a/src/com/android/settings/wifi/ConfigureWifiSettings.java b/src/com/android/settings/wifi/ConfigureWifiSettings.java
index 41c845b..3009ae7 100644
--- a/src/com/android/settings/wifi/ConfigureWifiSettings.java
+++ b/src/com/android/settings/wifi/ConfigureWifiSettings.java
@@ -20,8 +20,6 @@
import android.app.settings.SettingsEnums;
import android.content.Context;
import android.content.Intent;
-import android.net.ConnectivityManager;
-import android.net.NetworkInfo;
import android.net.wifi.WifiManager;
import com.android.settings.R;
@@ -39,7 +37,6 @@
private static final String TAG = "ConfigureWifiSettings";
- public static final String KEY_IP_ADDRESS = "current_ip_address";
public static final int WIFI_WAKEUP_REQUEST_CODE = 600;
private WifiWakeupPreferenceController mWifiWakeupPreferenceController;
@@ -73,8 +70,6 @@
protected List<AbstractPreferenceController> createPreferenceControllers(Context context) {
final WifiManager wifiManager = (WifiManager) getSystemService(WIFI_SERVICE);
final List<AbstractPreferenceController> controllers = new ArrayList<>();
- controllers.add(new WifiInfoPreferenceController(context, getSettingsLifecycle(),
- wifiManager));
controllers.add(new WifiP2pPreferenceController(context, getSettingsLifecycle(),
wifiManager));
return controllers;
@@ -107,24 +102,6 @@
public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER =
new BaseSearchIndexProvider(R.xml.wifi_configure_settings) {
-
- @Override
- public List<String> getNonIndexableKeys(Context context) {
- List<String> keys = super.getNonIndexableKeys(context);
-
- // If connected to WiFi, this IP address will be the same as the Status IP.
- // Or, if there is no connection they will say unavailable.
- ConnectivityManager cm = (ConnectivityManager)
- context.getSystemService(Context.CONNECTIVITY_SERVICE);
- NetworkInfo info = cm.getActiveNetworkInfo();
- if (info == null
- || info.getType() == ConnectivityManager.TYPE_WIFI) {
- keys.add(KEY_IP_ADDRESS);
- }
-
- return keys;
- }
-
protected boolean isPageSearchEnabled(Context context) {
return context.getResources()
.getBoolean(R.bool.config_show_wifi_settings);
diff --git a/src/com/android/settings/wifi/WifiInfoPreferenceController.java b/src/com/android/settings/wifi/WifiInfoPreferenceController.java
deleted file mode 100644
index 2a8c7b5..0000000
--- a/src/com/android/settings/wifi/WifiInfoPreferenceController.java
+++ /dev/null
@@ -1,132 +0,0 @@
-/*
- * Copyright (C) 2017 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.android.settings.wifi;
-
-import android.content.BroadcastReceiver;
-import android.content.Context;
-import android.content.Intent;
-import android.content.IntentFilter;
-import android.net.wifi.WifiInfo;
-import android.net.wifi.WifiManager;
-import android.provider.Settings;
-import android.text.TextUtils;
-
-import androidx.core.text.BidiFormatter;
-import androidx.preference.Preference;
-import androidx.preference.PreferenceScreen;
-
-import com.android.settings.R;
-import com.android.settings.Utils;
-import com.android.settings.core.PreferenceControllerMixin;
-import com.android.settingslib.core.AbstractPreferenceController;
-import com.android.settingslib.core.lifecycle.Lifecycle;
-import com.android.settingslib.core.lifecycle.LifecycleObserver;
-import com.android.settingslib.core.lifecycle.events.OnPause;
-import com.android.settingslib.core.lifecycle.events.OnResume;
-
-/**
- * {@link PreferenceControllerMixin} that updates MAC/IP address.
- */
-public class WifiInfoPreferenceController extends AbstractPreferenceController
- implements PreferenceControllerMixin, LifecycleObserver, OnResume, OnPause {
-
- private static final String KEY_CURRENT_IP_ADDRESS = "current_ip_address";
- private static final String KEY_MAC_ADDRESS = "mac_address";
-
- private final IntentFilter mFilter;
- private final WifiManager mWifiManager;
-
- private Preference mWifiMacAddressPref;
- private Preference mWifiIpAddressPref;
-
- public WifiInfoPreferenceController(Context context, Lifecycle lifecycle,
- WifiManager wifiManager) {
- super(context);
- mWifiManager = wifiManager;
- mFilter = new IntentFilter();
- mFilter.addAction(WifiManager.LINK_CONFIGURATION_CHANGED_ACTION);
- mFilter.addAction(WifiManager.NETWORK_STATE_CHANGED_ACTION);
-
- lifecycle.addObserver(this);
- }
-
- @Override
- public boolean isAvailable() {
- return true;
- }
-
- @Override
- public String getPreferenceKey() {
- // Returns null because this controller contains more than 1 preference.
- return null;
- }
-
- @Override
- public void displayPreference(PreferenceScreen screen) {
- super.displayPreference(screen);
- mWifiMacAddressPref = screen.findPreference(KEY_MAC_ADDRESS);
- mWifiMacAddressPref.setSelectable(false);
- mWifiIpAddressPref = screen.findPreference(KEY_CURRENT_IP_ADDRESS);
- mWifiIpAddressPref.setSelectable(false);
- }
-
- @Override
- public void onResume() {
- mContext.registerReceiver(mReceiver, mFilter);
- updateWifiInfo();
- }
-
- @Override
- public void onPause() {
- mContext.unregisterReceiver(mReceiver);
- }
-
- public void updateWifiInfo() {
- if (mWifiMacAddressPref != null) {
- final WifiInfo wifiInfo = mWifiManager.getConnectionInfo();
- final boolean macRandomizationSupported = mContext.getResources().getBoolean(
- com.android.internal.R.bool.config_wifi_connected_mac_randomization_supported);
- final String macAddress = wifiInfo == null ? null : wifiInfo.getMacAddress();
-
- if (macRandomizationSupported && WifiInfo.DEFAULT_MAC_ADDRESS.equals(macAddress)) {
- mWifiMacAddressPref.setSummary(R.string.wifi_status_mac_randomized);
- } else if (TextUtils.isEmpty(macAddress)
- || WifiInfo.DEFAULT_MAC_ADDRESS.equals(macAddress)) {
- mWifiMacAddressPref.setSummary(R.string.status_unavailable);
- } else {
- mWifiMacAddressPref.setSummary(macAddress);
- }
- }
- if (mWifiIpAddressPref != null) {
- final String ipAddress = Utils.getWifiIpAddresses(mContext);
- mWifiIpAddressPref.setSummary(ipAddress == null
- ? mContext.getString(R.string.status_unavailable)
- : BidiFormatter.getInstance().unicodeWrap(ipAddress));
- }
- }
-
- private final BroadcastReceiver mReceiver = new BroadcastReceiver() {
- @Override
- public void onReceive(Context context, Intent intent) {
- String action = intent.getAction();
- if (action.equals(WifiManager.LINK_CONFIGURATION_CHANGED_ACTION) ||
- action.equals(WifiManager.NETWORK_STATE_CHANGED_ACTION)) {
- updateWifiInfo();
- }
- }
- };
-}
diff --git a/src/com/android/settings/wifi/details/WifiDetailPreferenceController.java b/src/com/android/settings/wifi/details/WifiDetailPreferenceController.java
index a915766..3ed561b 100644
--- a/src/com/android/settings/wifi/details/WifiDetailPreferenceController.java
+++ b/src/com/android/settings/wifi/details/WifiDetailPreferenceController.java
@@ -687,6 +687,9 @@
} else {
mMacAddressPref.setSummary(macAddress);
}
+
+ // MAC Address Pref Title
+ refreshMacTitle();
}
private String getMacAddress() {
@@ -1141,4 +1144,24 @@
mTimer.cancel();
mTimer = null;
}
+
+ private void refreshMacTitle() {
+ if (mWifiConfig == null) {
+ return;
+ }
+
+ // For saved Passpoint network, framework doesn't have the field to keep the MAC choice
+ // persistently, so Passpoint network will always use the default value so far, which is
+ // randomized MAC address, so don't need to modify title.
+ if (mAccessPoint.isPasspoint() || mAccessPoint.isPasspointConfig()) {
+ return;
+ }
+
+ mMacAddressPref.setTitle(
+ (mWifiConfig.macRandomizationSetting
+ == WifiConfiguration.RANDOMIZATION_PERSISTENT)
+ ? R.string.wifi_advanced_randomized_mac_address_title
+ : R.string.wifi_advanced_factory_mac_address_title);
+
+ }
}
diff --git a/src/com/android/settings/wifi/p2p/P2pCategoryPreferenceController.java b/src/com/android/settings/wifi/p2p/P2pCategoryPreferenceController.java
index 032649c..ee46bdb 100644
--- a/src/com/android/settings/wifi/p2p/P2pCategoryPreferenceController.java
+++ b/src/com/android/settings/wifi/p2p/P2pCategoryPreferenceController.java
@@ -36,13 +36,13 @@
@Override
public boolean isAvailable() {
- return true;
+ return mCategory.getPreferenceCount() > 0;
}
@Override
public void displayPreference(PreferenceScreen screen) {
- super.displayPreference(screen);
mCategory = screen.findPreference(getPreferenceKey());
+ super.displayPreference(screen);
}
public void removeAllChildren() {
diff --git a/src/com/android/settings/wifi/savedaccesspoints/SavedAccessPointsPreferenceController.java b/src/com/android/settings/wifi/savedaccesspoints/SavedAccessPointsPreferenceController.java
index 82c6028..b8e36a4 100644
--- a/src/com/android/settings/wifi/savedaccesspoints/SavedAccessPointsPreferenceController.java
+++ b/src/com/android/settings/wifi/savedaccesspoints/SavedAccessPointsPreferenceController.java
@@ -27,7 +27,6 @@
import androidx.preference.PreferenceScreen;
import com.android.settings.core.BasePreferenceController;
-import com.android.settings.utils.PreferenceGroupChildrenCache;
import com.android.settings.R;
import com.android.settingslib.core.lifecycle.LifecycleObserver;
import com.android.settingslib.core.lifecycle.events.OnStart;
@@ -50,7 +49,6 @@
private static final String TAG = "SavedAPPrefCtrl";
private final WifiManager mWifiManager;
- private final PreferenceGroupChildrenCache mChildrenCache;
private final UserBadgeCache mUserBadgeCache;
private PreferenceGroup mPreferenceGroup;
@@ -61,7 +59,6 @@
super(context, preferenceKey);
mUserBadgeCache = new AccessPointPreference.UserBadgeCache(context.getPackageManager());
mWifiManager = context.getSystemService(WifiManager.class);
- mChildrenCache = new PreferenceGroupChildrenCache();
}
public SavedAccessPointsPreferenceController setHost(SavedAccessPointsWifiSettings host) {
@@ -91,8 +88,9 @@
@Override
public boolean onPreferenceClick(Preference preference) {
+ final Preference preferenceInGroup = mPreferenceGroup.findPreference(preference.getKey());
if (mHost != null) {
- mHost.showWifiPage((AccessPointPreference) preference);
+ mHost.showWifiPage((AccessPointPreference) preferenceInGroup);
}
return false;
}
@@ -118,7 +116,7 @@
final List<AccessPoint> accessPoints =
WifiSavedConfigUtils.getAllConfigs(mContext, mWifiManager);
Collections.sort(accessPoints, SavedNetworkComparator.INSTANCE);
- mChildrenCache.cacheRemoveAllPrefs(mPreferenceGroup);
+ mPreferenceGroup.removeAll();
final int accessPointsSize = accessPoints.size();
for (int i = 0; i < accessPointsSize; ++i) {
@@ -130,20 +128,15 @@
}
String key = ap.getKey();
- AccessPointPreference preference =
- (AccessPointPreference) mChildrenCache.getCachedPreference(key);
- if (preference == null) {
- preference = new AccessPointPreference(ap, prefContext, mUserBadgeCache, true);
- preference.setKey(key);
- preference.setIcon(null);
- preference.setOnPreferenceClickListener(this);
- mPreferenceGroup.addPreference(preference);
- }
+ AccessPointPreference preference = new AccessPointPreference(ap, prefContext,
+ mUserBadgeCache, true);
+ preference.setKey(key);
+ preference.setIcon(null);
+ preference.setOnPreferenceClickListener(this);
+ mPreferenceGroup.addPreference(preference);
preference.setOrder(i);
}
- mChildrenCache.removeCachedPrefs(mPreferenceGroup);
-
if (mPreferenceGroup.getPreferenceCount() < 1) {
Log.w(TAG, "Saved networks activity loaded, but there are no saved networks!");
mPreferenceGroup.setVisible(false);
diff --git a/tests/robotests/src/com/android/settings/accounts/AccountDetailDashboardFragmentTest.java b/tests/robotests/src/com/android/settings/accounts/AccountDetailDashboardFragmentTest.java
index dffa968..03c5de3 100644
--- a/tests/robotests/src/com/android/settings/accounts/AccountDetailDashboardFragmentTest.java
+++ b/tests/robotests/src/com/android/settings/accounts/AccountDetailDashboardFragmentTest.java
@@ -47,6 +47,7 @@
import com.android.settings.dashboard.DashboardFeatureProviderImpl;
import com.android.settings.testutils.shadow.ShadowAccountManager;
import com.android.settings.testutils.shadow.ShadowUserManager;
+import com.android.settingslib.drawer.ActivityTile;
import com.android.settingslib.drawer.CategoryKey;
import com.android.settingslib.drawer.Tile;
@@ -105,7 +106,7 @@
@Test
public void refreshDashboardTiles_HasAccountType_shouldDisplay() {
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT_DETAIL);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT_DETAIL);
mActivityInfo.metaData.putString(METADATA_CATEGORY, CategoryKey.CATEGORY_ACCOUNT_DETAIL);
mActivityInfo.metaData.putString(METADATA_ACCOUNT_TYPE, "com.abc");
@@ -114,7 +115,7 @@
@Test
public void refreshDashboardTiles_NoAccountType_shouldNotDisplay() {
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT_DETAIL);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT_DETAIL);
mActivityInfo.metaData.putString(METADATA_CATEGORY, CategoryKey.CATEGORY_ACCOUNT_DETAIL);
assertThat(mFragment.displayTile(tile)).isFalse();
@@ -122,7 +123,7 @@
@Test
public void refreshDashboardTiles_OtherAccountType_shouldNotDisplay() {
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT_DETAIL);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT_DETAIL);
mActivityInfo.metaData.putString(METADATA_CATEGORY, CategoryKey.CATEGORY_ACCOUNT_DETAIL);
mActivityInfo.metaData.putString(METADATA_ACCOUNT_TYPE, "com.other");
@@ -138,7 +139,7 @@
when(packageManager.resolveActivity(any(Intent.class), anyInt()))
.thenReturn(mock(ResolveInfo.class));
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT_DETAIL);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT_DETAIL);
mActivityInfo.metaData.putString(META_DATA_PREFERENCE_KEYHINT, "key");
mActivityInfo.metaData.putString(METADATA_CATEGORY, CategoryKey.CATEGORY_ACCOUNT);
mActivityInfo.metaData.putString(METADATA_ACCOUNT_TYPE, "com.abc");
@@ -166,7 +167,7 @@
public void displayTile_shouldAddUserHandleToTileIntent() {
mFragment.mUserHandle = new UserHandle(1);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT_DETAIL);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT_DETAIL);
mActivityInfo.metaData.putString(METADATA_CATEGORY, CategoryKey.CATEGORY_ACCOUNT);
mActivityInfo.metaData.putString(METADATA_ACCOUNT_TYPE, "com.abc");
diff --git a/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDefaultFragmentTest.java b/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDefaultFragmentTest.java
index d8663fc..4afe22a 100644
--- a/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDefaultFragmentTest.java
+++ b/tests/robotests/src/com/android/settings/connecteddevice/usb/UsbDefaultFragmentTest.java
@@ -16,12 +16,15 @@
package com.android.settings.connecteddevice.usb;
+import static android.hardware.usb.UsbPortStatus.DATA_ROLE_DEVICE;
+import static android.hardware.usb.UsbPortStatus.POWER_ROLE_SINK;
import static android.net.ConnectivityManager.TETHERING_USB;
import static com.google.common.truth.Truth.assertThat;
import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
@@ -29,6 +32,8 @@
import android.hardware.usb.UsbManager;
import android.net.ConnectivityManager;
+import androidx.preference.PreferenceScreen;
+
import com.android.settings.testutils.shadow.ShadowUtils;
import org.junit.Before;
@@ -52,7 +57,7 @@
@Before
public void setUp() {
MockitoAnnotations.initMocks(this);
- mFragment = new UsbDefaultFragment();
+ mFragment = new TestFragment();
mFragment.mUsbBackend = mUsbBackend;
mFragment.mConnectivityManager = mConnectivityManager;
}
@@ -156,4 +161,77 @@
verify(mUsbBackend).setDefaultUsbFunctions(UsbManager.FUNCTION_RNDIS);
}
+
+ @Test
+ public void onPause_receivedRndis_shouldSetRndis() {
+ mFragment.mIsStartTethering = true;
+ mFragment.mUsbConnectionListener.onUsbConnectionChanged(true /* connected */,
+ UsbManager.FUNCTION_RNDIS, POWER_ROLE_SINK, DATA_ROLE_DEVICE);
+
+ mFragment.onPause();
+
+ verify(mUsbBackend).setDefaultUsbFunctions(UsbManager.FUNCTION_RNDIS);
+ assertThat(mFragment.mCurrentFunctions).isEqualTo(UsbManager.FUNCTION_RNDIS);
+ }
+
+ @Test
+ public void onPause_receivedNone_shouldSetNone() {
+ mFragment.mIsStartTethering = true;
+ mFragment.mUsbConnectionListener.onUsbConnectionChanged(true /* connected */,
+ UsbManager.FUNCTION_NONE, POWER_ROLE_SINK, DATA_ROLE_DEVICE);
+
+ mFragment.onPause();
+
+ verify(mUsbBackend).setDefaultUsbFunctions(UsbManager.FUNCTION_NONE);
+ assertThat(mFragment.mCurrentFunctions).isEqualTo(UsbManager.FUNCTION_NONE);
+ }
+
+ @Test
+ public void onPause_receivedMtp_shouldSetMtp() {
+ mFragment.mIsStartTethering = true;
+ mFragment.mUsbConnectionListener.onUsbConnectionChanged(true /* connected */,
+ UsbManager.FUNCTION_MTP, POWER_ROLE_SINK, DATA_ROLE_DEVICE);
+
+ mFragment.onPause();
+
+ verify(mUsbBackend).setDefaultUsbFunctions(UsbManager.FUNCTION_MTP);
+ assertThat(mFragment.mCurrentFunctions).isEqualTo(UsbManager.FUNCTION_MTP);
+ }
+
+ @Test
+ public void onPause_receivedPtp_shouldSetPtp() {
+ mFragment.mIsStartTethering = true;
+ mFragment.mUsbConnectionListener.onUsbConnectionChanged(true /* connected */,
+ UsbManager.FUNCTION_PTP, POWER_ROLE_SINK, DATA_ROLE_DEVICE);
+
+ mFragment.onPause();
+
+ verify(mUsbBackend).setDefaultUsbFunctions(UsbManager.FUNCTION_PTP);
+ assertThat(mFragment.mCurrentFunctions).isEqualTo(UsbManager.FUNCTION_PTP);
+ }
+
+ @Test
+ public void onPause_receivedMidi_shouldSetMidi() {
+ mFragment.mIsStartTethering = true;
+ mFragment.mUsbConnectionListener.onUsbConnectionChanged(true /* connected */,
+ UsbManager.FUNCTION_MIDI, POWER_ROLE_SINK, DATA_ROLE_DEVICE);
+
+ mFragment.onPause();
+
+ verify(mUsbBackend).setDefaultUsbFunctions(UsbManager.FUNCTION_MIDI);
+ assertThat(mFragment.mCurrentFunctions).isEqualTo(UsbManager.FUNCTION_MIDI);
+ }
+
+ public static class TestFragment extends UsbDefaultFragment {
+ public final PreferenceScreen mScreen;
+
+ public TestFragment() {
+ mScreen = mock(PreferenceScreen.class);
+ }
+
+ @Override
+ public PreferenceScreen getPreferenceScreen() {
+ return mScreen;
+ }
+ }
}
diff --git a/tests/robotests/src/com/android/settings/dashboard/CategoryManagerTest.java b/tests/robotests/src/com/android/settings/dashboard/CategoryManagerTest.java
index 0de212d..1efaed9 100644
--- a/tests/robotests/src/com/android/settings/dashboard/CategoryManagerTest.java
+++ b/tests/robotests/src/com/android/settings/dashboard/CategoryManagerTest.java
@@ -27,6 +27,7 @@
import android.os.Bundle;
import android.util.Pair;
+import com.android.settingslib.drawer.ActivityTile;
import com.android.settingslib.drawer.CategoryKey;
import com.android.settingslib.drawer.DashboardCategory;
import com.android.settingslib.drawer.Tile;
@@ -68,8 +69,8 @@
@Test
public void backwardCompatCleanupForCategory_shouldNotChangeCategoryForNewKeys() {
- final Tile tile1 = new Tile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT);
- final Tile tile2 = new Tile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT);
+ final Tile tile1 = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT);
+ final Tile tile2 = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT);
final DashboardCategory category = new DashboardCategory(CategoryKey.CATEGORY_ACCOUNT);
category.addTile(tile1);
category.addTile(tile2);
@@ -85,9 +86,9 @@
@Test
public void backwardCompatCleanupForCategory_shouldNotChangeCategoryForMixedKeys() {
- final Tile tile1 = new Tile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT);
+ final Tile tile1 = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_ACCOUNT);
final String oldCategory = "com.android.settings.category.wireless";
- final Tile tile2 = new Tile(mActivityInfo, oldCategory);
+ final Tile tile2 = new ActivityTile(mActivityInfo, oldCategory);
final DashboardCategory category1 = new DashboardCategory(CategoryKey.CATEGORY_ACCOUNT);
category1.addTile(tile1);
final DashboardCategory category2 = new DashboardCategory(oldCategory);
@@ -108,7 +109,7 @@
@Test
public void backwardCompatCleanupForCategory_shouldChangeCategoryForOldKeys() {
final String oldCategory = "com.android.settings.category.wireless";
- final Tile tile1 = new Tile(mActivityInfo, oldCategory);
+ final Tile tile1 = new ActivityTile(mActivityInfo, oldCategory);
tile1.setCategory(oldCategory);
final DashboardCategory category1 = new DashboardCategory(oldCategory);
category1.addTile(tile1);
@@ -146,9 +147,9 @@
activityInfo3.metaData.putInt(META_DATA_KEY_ORDER, 200);
activityInfo3.packageName = testPackage;
activityInfo3.name = "class3";
- final Tile tile1 = new Tile(activityInfo1, category.key);
- final Tile tile2 = new Tile(activityInfo2, category.key);
- final Tile tile3 = new Tile(activityInfo3, category.key);
+ final Tile tile1 = new ActivityTile(activityInfo1, category.key);
+ final Tile tile2 = new ActivityTile(activityInfo2, category.key);
+ final Tile tile3 = new ActivityTile(activityInfo3, category.key);
category.addTile(tile1);
category.addTile(tile2);
@@ -186,9 +187,9 @@
activityInfo3.packageName = testPackage1;
activityInfo3.name = "class3";
- final Tile tile1 = new Tile(activityInfo1, category.key);
- final Tile tile2 = new Tile(activityInfo2, category.key);
- final Tile tile3 = new Tile(activityInfo3, category.key);
+ final Tile tile1 = new ActivityTile(activityInfo1, category.key);
+ final Tile tile2 = new ActivityTile(activityInfo2, category.key);
+ final Tile tile3 = new ActivityTile(activityInfo3, category.key);
category.addTile(tile1);
category.addTile(tile2);
category.addTile(tile3);
@@ -223,9 +224,9 @@
activityInfo3.name = "class3";
activityInfo3.metaData = new Bundle();
activityInfo3.metaData.putInt(META_DATA_KEY_ORDER, 50);
- final Tile tile1 = new Tile(activityInfo1, category.key);
- final Tile tile2 = new Tile(activityInfo2, category.key);
- final Tile tile3 = new Tile(activityInfo3, category.key);
+ final Tile tile1 = new ActivityTile(activityInfo1, category.key);
+ final Tile tile2 = new ActivityTile(activityInfo2, category.key);
+ final Tile tile3 = new ActivityTile(activityInfo3, category.key);
category.addTile(tile1);
category.addTile(tile2);
category.addTile(tile3);
@@ -268,10 +269,10 @@
activityInfo4.metaData = new Bundle();
activityInfo4.metaData.putInt(META_DATA_KEY_ORDER, -1);
- final Tile tile1 = new Tile(activityInfo1, category.key);
- final Tile tile2 = new Tile(activityInfo2, category.key);
- final Tile tile4 = new Tile(activityInfo4, category.key);
- final Tile tile3 = new Tile(activityInfo3, category.key);
+ final Tile tile1 = new ActivityTile(activityInfo1, category.key);
+ final Tile tile2 = new ActivityTile(activityInfo2, category.key);
+ final Tile tile4 = new ActivityTile(activityInfo4, category.key);
+ final Tile tile3 = new ActivityTile(activityInfo3, category.key);
category.addTile(tile1);
category.addTile(tile2);
category.addTile(tile3);
@@ -310,9 +311,9 @@
activityInfo3.name = "class3";
activityInfo3.metaData = new Bundle();
activityInfo3.metaData.putInt(META_DATA_KEY_ORDER, 1);
- final Tile tile1 = new Tile(activityInfo1, category.key);
- final Tile tile2 = new Tile(activityInfo2, category.key);
- final Tile tile3 = new Tile(activityInfo3, category.key);
+ final Tile tile1 = new ActivityTile(activityInfo1, category.key);
+ final Tile tile2 = new ActivityTile(activityInfo2, category.key);
+ final Tile tile3 = new ActivityTile(activityInfo3, category.key);
category.addTile(tile1);
category.addTile(tile2);
category.addTile(tile3);
@@ -347,9 +348,9 @@
activityInfo3.name = "class3";
activityInfo3.metaData = new Bundle();
activityInfo3.metaData.putInt(META_DATA_KEY_ORDER, 50);
- final Tile tile1 = new Tile(activityInfo1, category.key);
- final Tile tile2 = new Tile(activityInfo2, category.key);
- final Tile tile3 = new Tile(activityInfo3, category.key);
+ final Tile tile1 = new ActivityTile(activityInfo1, category.key);
+ final Tile tile2 = new ActivityTile(activityInfo2, category.key);
+ final Tile tile3 = new ActivityTile(activityInfo3, category.key);
category.addTile(tile1);
category.addTile(tile2);
category.addTile(tile3);
@@ -381,9 +382,9 @@
activityInfo3.metaData = new Bundle();
activityInfo3.metaData.putInt(META_DATA_KEY_ORDER, 50);
- final Tile tile1 = new Tile(activityInfo1, category.key);
- final Tile tile2 = new Tile(activityInfo2, category.key);
- final Tile tile3 = new Tile(activityInfo3, category.key);
+ final Tile tile1 = new ActivityTile(activityInfo1, category.key);
+ final Tile tile2 = new ActivityTile(activityInfo2, category.key);
+ final Tile tile3 = new ActivityTile(activityInfo3, category.key);
category.addTile(tile1);
category.addTile(tile2);
category.addTile(tile3);
diff --git a/tests/robotests/src/com/android/settings/dashboard/DashboardFeatureProviderImplTest.java b/tests/robotests/src/com/android/settings/dashboard/DashboardFeatureProviderImplTest.java
index 7084856..7dafd07 100644
--- a/tests/robotests/src/com/android/settings/dashboard/DashboardFeatureProviderImplTest.java
+++ b/tests/robotests/src/com/android/settings/dashboard/DashboardFeatureProviderImplTest.java
@@ -57,10 +57,10 @@
import com.android.settings.R;
import com.android.settings.SettingsActivity;
import com.android.settings.testutils.FakeFeatureFactory;
-import com.android.settings.testutils.shadow.ShadowThreadUtils;
import com.android.settings.testutils.shadow.ShadowTileUtils;
import com.android.settings.testutils.shadow.ShadowUserManager;
import com.android.settingslib.core.instrumentation.MetricsFeatureProvider;
+import com.android.settingslib.drawer.ActivityTile;
import com.android.settingslib.drawer.CategoryKey;
import com.android.settingslib.drawer.Tile;
import com.android.settingslib.drawer.TileUtils;
@@ -127,7 +127,7 @@
@Test
public void bindPreference_shouldBindAllData() {
final Preference preference = new Preference(RuntimeEnvironment.application);
- final Tile tile = spy(new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE));
+ final Tile tile = spy(new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE));
mActivityInfo.metaData.putInt(META_DATA_KEY_ORDER, 10);
doReturn(Icon.createWithBitmap(Bitmap.createBitmap(1, 1, Bitmap.Config.RGB_565)))
.when(tile).getIcon(any(Context.class));
@@ -148,7 +148,7 @@
public void bindPreference_noFragmentMetadata_shouldBindIntent() {
final Preference preference = new Preference(RuntimeEnvironment.application);
mActivityInfo.metaData.putInt(META_DATA_KEY_ORDER, 10);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
mImpl.bindPreferenceToTile(mActivity, mForceRoundedIcon, MetricsEvent.SETTINGS_GESTURES,
preference, tile, "123", Preference.DEFAULT_ORDER);
@@ -161,7 +161,7 @@
@Test
public void bindPreference_noFragmentMetadata_shouldBindToProfileSelector() {
final Preference preference = new Preference(RuntimeEnvironment.application);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
tile.userHandle = new ArrayList<>();
tile.userHandle.add(mock(UserHandle.class));
tile.userHandle.add(mock(UserHandle.class));
@@ -176,7 +176,7 @@
@Test
public void bindPreference_noFragmentMetadataSingleUser_shouldBindToDirectLaunchIntent() {
final Preference preference = new Preference(RuntimeEnvironment.application);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
tile.userHandle = new ArrayList<>();
tile.userHandle.add(mock(UserHandle.class));
@@ -199,7 +199,7 @@
public void bindPreference_toInternalSettingActivity_shouldBindToDirectLaunchIntentAndNotLog() {
final Preference preference = new Preference(RuntimeEnvironment.application);
mActivityInfo.packageName = RuntimeEnvironment.application.getPackageName();
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
tile.userHandle = new ArrayList<>();
tile.userHandle.add(mock(UserHandle.class));
@@ -226,7 +226,7 @@
@Test
public void bindPreference_withNullKeyNullPriority_shouldGenerateKeyAndPriority() {
final Preference preference = new Preference(RuntimeEnvironment.application);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
mImpl.bindPreferenceToTile(mActivity, mForceRoundedIcon, MetricsEvent.VIEW_UNKNOWN,
preference, tile, null /*key */, Preference.DEFAULT_ORDER);
@@ -239,7 +239,7 @@
final Preference preference = new Preference(RuntimeEnvironment.application);
mActivityInfo.metaData.remove(META_DATA_PREFERENCE_SUMMARY);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
mImpl.bindPreferenceToTile(mActivity, mForceRoundedIcon, MetricsEvent.VIEW_UNKNOWN,
preference, tile, null /*key */, Preference.DEFAULT_ORDER);
@@ -252,7 +252,7 @@
@Config(shadows = {ShadowTileUtils.class})
public void bindPreference_hasSummaryUri_shouldLoadSummaryFromContentProvider() {
final Preference preference = new Preference(RuntimeEnvironment.application);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
mActivityInfo.metaData.putString(TileUtils.META_DATA_PREFERENCE_SUMMARY_URI,
"content://com.android.settings/tile_summary");
@@ -266,7 +266,7 @@
@Config(shadows = {ShadowTileUtils.class})
public void bindPreference_hasTitleUri_shouldLoadFromContentProvider() {
final Preference preference = new Preference(RuntimeEnvironment.application);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
mActivityInfo.metaData.putString(TileUtils.META_DATA_PREFERENCE_TITLE_URI,
"content://com.android.settings/tile_title");
@@ -280,7 +280,7 @@
public void bindPreference_withNullKeyTileKey_shouldUseTileKey() {
final Preference preference = new Preference(RuntimeEnvironment.application);
mActivityInfo.metaData.putString(META_DATA_PREFERENCE_KEYHINT, "key");
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
mImpl.bindPreferenceToTile(mActivity, mForceRoundedIcon, MetricsEvent.VIEW_UNKNOWN,
preference, tile, null /* key */, Preference.DEFAULT_ORDER);
@@ -292,7 +292,7 @@
public void bindPreference_withIconUri_shouldLoadIconFromContentProvider() {
final Preference preference = new Preference(RuntimeEnvironment.application);
mActivityInfo.packageName = RuntimeEnvironment.application.getPackageName();
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
mActivityInfo.metaData.putString(META_DATA_PREFERENCE_KEYHINT, "key");
mActivityInfo.metaData.putString(TileUtils.META_DATA_PREFERENCE_ICON_URI,
"content://com.android.settings/tile_icon");
@@ -306,7 +306,7 @@
final int baseOrder = 100;
final Preference preference = new Preference(RuntimeEnvironment.application);
mActivityInfo.metaData.putInt(META_DATA_KEY_ORDER, 10);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
mImpl.bindPreferenceToTile(mActivity, mForceRoundedIcon, MetricsEvent.VIEW_UNKNOWN,
preference, tile, "123", baseOrder);
@@ -319,7 +319,7 @@
final Preference preference = new Preference(RuntimeEnvironment.application);
final int testOrder = -30;
mActivityInfo.metaData.putInt(META_DATA_KEY_ORDER, 10);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
mActivityInfo.metaData.putInt(META_DATA_KEY_ORDER, testOrder);
mImpl.bindPreferenceToTile(mActivity, mForceRoundedIcon, MetricsEvent.VIEW_UNKNOWN,
preference, tile, "123", Preference.DEFAULT_ORDER);
@@ -330,7 +330,7 @@
@Test
public void bindPreference_invalidOrderMetadata_shouldIgnore() {
final Preference preference = new Preference(RuntimeEnvironment.application);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
mActivityInfo.metaData.putString(META_DATA_KEY_ORDER, "hello");
mImpl.bindPreferenceToTile(mActivity, mForceRoundedIcon, MetricsEvent.VIEW_UNKNOWN,
@@ -343,7 +343,7 @@
public void bindPreference_withIntentActionMetadata_shouldSetLaunchAction() {
FragmentActivity activity = Robolectric.buildActivity(FragmentActivity.class).get();
final Preference preference = new Preference(RuntimeEnvironment.application);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
mActivityInfo.metaData.putString(META_DATA_PREFERENCE_KEYHINT, "key");
mActivityInfo.metaData.putString("com.android.settings.intent.action", "TestAction");
tile.userHandle = null;
@@ -366,7 +366,7 @@
mImpl, "mPackageManager", RuntimeEnvironment.application.getPackageManager());
FragmentActivity activity = Robolectric.buildActivity(FragmentActivity.class).get();
final Preference preference = new Preference(RuntimeEnvironment.application);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
mActivityInfo.metaData.putString(META_DATA_PREFERENCE_KEYHINT, "key");
mActivityInfo.metaData.putString("com.android.settings.intent.action", "TestAction");
tile.userHandle = null;
@@ -385,7 +385,7 @@
public void openTileIntent_profileSelectionDialog_shouldShow() {
ShadowUserManager.getShadow().addUser(10, "Someone", 0);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
final ArrayList<UserHandle> handles = new ArrayList<>();
handles.add(new UserHandle(0));
handles.add(new UserHandle(10));
@@ -402,7 +402,7 @@
ShadowUserManager.getShadow().addUser(10, "Someone", 0);
mActivityInfo.metaData.putString(META_DATA_KEY_PROFILE, PROFILE_ALL);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
final ArrayList<UserHandle> handles = new ArrayList<>();
handles.add(new UserHandle(0));
handles.add(new UserHandle(10));
@@ -419,7 +419,7 @@
ShadowUserManager.getShadow().addUser(10, "Someone", 0);
mActivityInfo.metaData.putString(META_DATA_KEY_PROFILE, PROFILE_PRIMARY);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
final ArrayList<UserHandle> handles = new ArrayList<>();
handles.add(new UserHandle(0));
handles.add(new UserHandle(10));
@@ -437,7 +437,7 @@
ShadowUserManager.getShadow().addUser(userId, "Someone", 0);
final UserHandle userHandle = new UserHandle(userId);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
tile.getIntent().putExtra(EXTRA_USER, userHandle);
final ArrayList<UserHandle> handles = new ArrayList<>();
handles.add(new UserHandle(0));
@@ -457,7 +457,7 @@
public void openTileIntent_profileSelectionDialog_invalidUserHandleShouldShow() {
ShadowUserManager.getShadow().addUser(10, "Someone", 0);
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
tile.getIntent().putExtra(EXTRA_USER, new UserHandle(30));
final ArrayList<UserHandle> handles = new ArrayList<>();
handles.add(new UserHandle(0));
diff --git a/tests/robotests/src/com/android/settings/dashboard/DashboardFragmentTest.java b/tests/robotests/src/com/android/settings/dashboard/DashboardFragmentTest.java
index 188f566..954a872 100644
--- a/tests/robotests/src/com/android/settings/dashboard/DashboardFragmentTest.java
+++ b/tests/robotests/src/com/android/settings/dashboard/DashboardFragmentTest.java
@@ -45,6 +45,7 @@
import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.core.instrumentation.MetricsFeatureProvider;
import com.android.settingslib.core.instrumentation.VisibilityLoggerMixin;
+import com.android.settingslib.drawer.ActivityTile;
import com.android.settingslib.drawer.DashboardCategory;
import com.android.settingslib.drawer.Tile;
@@ -86,7 +87,7 @@
mActivityInfo.metaData.putString(META_DATA_PREFERENCE_KEYHINT, "injected_tile_key");
mFakeFeatureFactory = FakeFeatureFactory.setupForTest();
mDashboardCategory = new DashboardCategory("key");
- mDashboardCategory.addTile(new Tile(mActivityInfo, mDashboardCategory.key));
+ mDashboardCategory.addTile(new ActivityTile(mActivityInfo, mDashboardCategory.key));
mTestFragment = new TestFragment(RuntimeEnvironment.application);
when(mFakeFeatureFactory.dashboardFeatureProvider
.getTilesForCategory(nullable(String.class)))
diff --git a/tests/robotests/src/com/android/settings/dashboard/SummaryLoaderTest.java b/tests/robotests/src/com/android/settings/dashboard/SummaryLoaderTest.java
deleted file mode 100644
index 236b18a..0000000
--- a/tests/robotests/src/com/android/settings/dashboard/SummaryLoaderTest.java
+++ /dev/null
@@ -1,87 +0,0 @@
-/*
- * Copyright (C) 2016 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.android.settings.dashboard;
-
-import static com.google.common.truth.Truth.assertThat;
-
-import static org.mockito.Mockito.verifyZeroInteractions;
-
-import android.app.Activity;
-import android.content.Context;
-import android.content.pm.ActivityInfo;
-
-import com.android.settings.testutils.FakeFeatureFactory;
-import com.android.settingslib.drawer.CategoryKey;
-import com.android.settingslib.drawer.Tile;
-
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.mockito.MockitoAnnotations;
-import org.robolectric.Robolectric;
-import org.robolectric.RobolectricTestRunner;
-import org.robolectric.RuntimeEnvironment;
-
-@RunWith(RobolectricTestRunner.class)
-public class SummaryLoaderTest {
-
- private static final String SUMMARY_1 = "summary1";
- private static final String SUMMARY_2 = "summary2";
-
- private Context mContext;
- private SummaryLoader mSummaryLoader;
- private boolean mCallbackInvoked;
- private Tile mTile;
- private FakeFeatureFactory mFeatureFactory;
-
- @Before
- public void SetUp() {
- MockitoAnnotations.initMocks(this);
- mContext = RuntimeEnvironment.application;
- mFeatureFactory = FakeFeatureFactory.setupForTest();
- final ActivityInfo activityInfo = new ActivityInfo();
- activityInfo.packageName = "pkg";
- activityInfo.name = "class";
- mTile = new Tile(activityInfo, CategoryKey.CATEGORY_HOMEPAGE);
- mTile.overrideSummary(SUMMARY_1);
- mCallbackInvoked = false;
-
- final Activity activity = Robolectric.buildActivity(Activity.class).get();
-
- mSummaryLoader = new SummaryLoader(activity, CategoryKey.CATEGORY_HOMEPAGE);
- mSummaryLoader.setSummaryConsumer(tile -> mCallbackInvoked = true);
- }
-
- @Test
- public void newInstance_shouldNotLoadCategory() {
- verifyZeroInteractions(mFeatureFactory.dashboardFeatureProvider);
- }
-
- @Test
- public void testUpdateSummaryIfNeeded_SummaryIdentical_NoCallback() {
- mSummaryLoader.updateSummaryIfNeeded(mContext, mTile, SUMMARY_1);
-
- assertThat(mCallbackInvoked).isFalse();
- }
-
- @Test
- public void testUpdateSummaryIfNeeded_SummaryChanged_HasCallback() {
- mSummaryLoader.updateSummaryIfNeeded(mContext, mTile, SUMMARY_2);
-
- assertThat(mCallbackInvoked).isTrue();
- }
-}
diff --git a/tests/robotests/src/com/android/settings/dashboard/profileselector/ProfileSelectDialogTest.java b/tests/robotests/src/com/android/settings/dashboard/profileselector/ProfileSelectDialogTest.java
index 2aee0dd..75a1c39 100644
--- a/tests/robotests/src/com/android/settings/dashboard/profileselector/ProfileSelectDialogTest.java
+++ b/tests/robotests/src/com/android/settings/dashboard/profileselector/ProfileSelectDialogTest.java
@@ -29,6 +29,7 @@
import android.os.UserHandle;
import android.os.UserManager;
+import com.android.settingslib.drawer.ActivityTile;
import com.android.settingslib.drawer.CategoryKey;
import com.android.settingslib.drawer.Tile;
@@ -66,7 +67,7 @@
@Test
public void updateUserHandlesIfNeeded_Normal() {
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
tile.userHandle.add(NORMAL_USER);
ProfileSelectDialog.updateUserHandlesIfNeeded(mContext, tile);
@@ -78,7 +79,7 @@
@Test
public void updateUserHandlesIfNeeded_Remove() {
- final Tile tile = new Tile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
+ final Tile tile = new ActivityTile(mActivityInfo, CategoryKey.CATEGORY_HOMEPAGE);
tile.userHandle.add(REMOVED_USER);
tile.userHandle.add(NORMAL_USER);
tile.userHandle.add(REMOVED_USER);
diff --git a/tests/robotests/src/com/android/settings/datausage/DataUsageSummaryTest.java b/tests/robotests/src/com/android/settings/datausage/DataUsageSummaryTest.java
index fea1d76..d8dde39 100644
--- a/tests/robotests/src/com/android/settings/datausage/DataUsageSummaryTest.java
+++ b/tests/robotests/src/com/android/settings/datausage/DataUsageSummaryTest.java
@@ -19,9 +19,7 @@
import static com.google.common.truth.Truth.assertThat;
import static org.mockito.ArgumentMatchers.anyInt;
-import static org.mockito.ArgumentMatchers.anyObject;
import static org.mockito.ArgumentMatchers.anyString;
-import static org.mockito.ArgumentMatchers.endsWith;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.never;
@@ -36,7 +34,6 @@
import androidx.fragment.app.FragmentActivity;
-import com.android.settings.dashboard.SummaryLoader;
import com.android.settings.testutils.shadow.ShadowDashboardFragment;
import com.android.settings.testutils.shadow.ShadowDataUsageUtils;
import com.android.settings.testutils.shadow.ShadowUserManager;
@@ -66,8 +63,6 @@
public class DataUsageSummaryTest {
@Mock
- private SummaryLoader mSummaryLoader;
- @Mock
private NetworkPolicyManager mNetworkPolicyManager;
@Mock
private NetworkStatsManager mNetworkStatsManager;
diff --git a/tests/robotests/src/com/android/settings/network/telephony/EnabledNetworkModePreferenceControllerTest.java b/tests/robotests/src/com/android/settings/network/telephony/EnabledNetworkModePreferenceControllerTest.java
index a4d708e..773041d 100644
--- a/tests/robotests/src/com/android/settings/network/telephony/EnabledNetworkModePreferenceControllerTest.java
+++ b/tests/robotests/src/com/android/settings/network/telephony/EnabledNetworkModePreferenceControllerTest.java
@@ -148,6 +148,26 @@
}
@Test
+ public void init_initDisplay5gList_returnTrue() {
+ long testBitmask = TelephonyManager.NETWORK_TYPE_BITMASK_NR
+ | TelephonyManager.NETWORK_TYPE_BITMASK_LTE;
+ doReturn(testBitmask).when(mTelephonyManager).getSupportedRadioAccessFamily();
+
+ mController.init(mLifecycle, SUB_ID);
+
+ assertThat(mController.mDisplay5gList).isTrue();
+ }
+
+ @Test
+ public void checkSupportedRadioBitmask_nrBitmask_returnTrue() {
+ long testBitmask = TelephonyManager.NETWORK_TYPE_BITMASK_NR
+ | TelephonyManager.NETWORK_TYPE_BITMASK_LTE;
+
+ assertThat(mController.checkSupportedRadioBitmask(testBitmask,
+ TelephonyManager.NETWORK_TYPE_BITMASK_NR)).isTrue();
+ }
+
+ @Test
public void updateState_updateByNetworkMode() {
Settings.Global.putInt(mContext.getContentResolver(),
Settings.Global.PREFERRED_NETWORK_MODE + SUB_ID,
@@ -172,6 +192,203 @@
String.valueOf(TelephonyManager.NETWORK_MODE_LTE_GSM_WCDMA));
}
+ /**
+ * @string/enabled_networks_cdma_choices
+ * Before | After
+ * @string/network_lte , 8 |@string/network_5G + @string/network_recommended , 25
+ * @string/network_3G , 4 |@string/network_lte_pure, 8
+ * @string/network_1x , 5 |@string/network_3G , 4
+ * @string/network_global, 10|@string/network_1x , 5
+ * |@string/network_global , 27
+ *
+ * @string/enabled_networks_cdma_only_lte_choices
+ * Before | After
+ * @string/network_lte , 8 |@string/network_5G + @string/network_recommended , 25
+ * @string/network_global, 10|@string/network_lte_pure, 8
+ * |@string/network_global , 27
+ */
+ @Test
+ public void add5gListItem_lteCdma_5gLteCdma() {
+ //case#1
+ mPreference.setEntries(R.array.enabled_networks_cdma_choices);
+ mPreference.setEntryValues(R.array.enabled_networks_cdma_values);
+ CharSequence[] testEntries = {mContext.getString(R.string.network_5G)
+ + mContext.getString(R.string.network_recommended)
+ , mContext.getString(R.string.network_lte_pure)
+ , mContext.getString(R.string.network_3G)
+ , mContext.getString(R.string.network_1x)
+ , mContext.getString(R.string.network_global)};
+ CharSequence[] testEntryValues = {"25", "8", "4", "5", "27"};
+
+ mController.add5gListItem(mPreference);
+
+ assertThat(mPreference.getEntries()).isEqualTo(testEntries);
+ assertThat(mPreference.getEntryValues()).isEqualTo(testEntryValues);
+
+ //case#2
+ mPreference.setEntries(R.array.enabled_networks_cdma_only_lte_choices);
+ mPreference.setEntryValues(R.array.enabled_networks_cdma_only_lte_values);
+ CharSequence[] testEntries1 = {mContext.getString(R.string.network_5G)
+ + mContext.getString(R.string.network_recommended)
+ , mContext.getString(R.string.network_lte_pure)
+ , mContext.getString(R.string.network_global)};
+ CharSequence[] testEntryValues1 = {"25", "8", "27"};
+
+ mController.add5gListItem(mPreference);
+
+ assertThat(mPreference.getEntries()).isEqualTo(testEntries1);
+ assertThat(mPreference.getEntryValues()).isEqualTo(testEntryValues1);
+ }
+
+ /**
+ * @string/enabled_networks_except_gsm_4g_choices
+ * Before | After
+ * @string/network_4G , 9 |@string/network_5G + @string/network_recommended , 26
+ * @string/network_3G , 0 |@string/network_4G_pure , 9
+ * |@string/network_3G , 0
+ *
+ * @string/enabled_networks_except_gsm_choices
+ * Before | After
+ * @string/network_lte, 9 |@string/network_5G + @string/network_recommended , 26
+ * @string/network_3G , 0 |@string/network_lte_pure, 9
+ * |@string/network_3G , 0
+ *
+ * @string/enabled_networks_4g_choices
+ * Before | After
+ * @string/network_4G , 9 |@string/network_5G + @string/network_recommended , 26
+ * @string/network_3G , 0 |@string/network_4G_pure , 9
+ * @string/network_2G , 1 |@string/network_3G , 0
+ * |@string/network_2G , 1
+ *
+ * @string/enabled_networks_choices
+ * Before | After
+ * @string/network_lte, 9 |@string/network_5G + @string/network_recommended , 26
+ * @string/network_3G , 0 |@string/network_lte_pure, 9
+ * @string/network_2G , 1 |@string/network_3G , 0
+ * |@string/network_2G , 1
+ */
+ @Test
+ public void add5gListItem_lteGsm_5gLteGsm() {
+ //csae#1
+ mPreference.setEntries(R.array.enabled_networks_except_gsm_4g_choices);
+ mPreference.setEntryValues(R.array.enabled_networks_except_gsm_values);
+ CharSequence[] testEntries = {mContext.getString(R.string.network_5G)
+ + mContext.getString(R.string.network_recommended)
+ , mContext.getString(R.string.network_4G_pure)
+ , mContext.getString(R.string.network_3G)};
+ CharSequence[] testEntryValues = {"26", "9", "0"};
+
+ mController.add5gListItem(mPreference);
+
+ assertThat(mPreference.getEntries()).isEqualTo(testEntries);
+ assertThat(mPreference.getEntryValues()).isEqualTo(testEntryValues);
+
+ //case#2
+ mPreference.setEntries(R.array.enabled_networks_except_gsm_choices);
+ mPreference.setEntryValues(R.array.enabled_networks_except_gsm_values);
+ CharSequence[] testEntries1 = {mContext.getString(R.string.network_5G)
+ + mContext.getString(R.string.network_recommended)
+ , mContext.getString(R.string.network_lte_pure)
+ , mContext.getString(R.string.network_3G)};
+ CharSequence[] testEntryValues1 = {"26", "9", "0"};
+
+ mController.add5gListItem(mPreference);
+
+ assertThat(mPreference.getEntries()).isEqualTo(testEntries1);
+ assertThat(mPreference.getEntryValues()).isEqualTo(testEntryValues1);
+
+ //case#3
+ mPreference.setEntries(R.array.enabled_networks_4g_choices);
+ mPreference.setEntryValues(R.array.enabled_networks_values);
+ CharSequence[] testEntries2 = {mContext.getString(R.string.network_5G)
+ + mContext.getString(R.string.network_recommended)
+ , mContext.getString(R.string.network_4G_pure)
+ , mContext.getString(R.string.network_3G)
+ , mContext.getString(R.string.network_2G)};
+ CharSequence[] testEntryValues2 = {"26", "9", "0", "1"};
+
+ mController.add5gListItem(mPreference);
+
+ assertThat(mPreference.getEntries()).isEqualTo(testEntries2);
+ assertThat(mPreference.getEntryValues()).isEqualTo(testEntryValues2);
+
+ //case#4
+ mPreference.setEntries(R.array.enabled_networks_choices);
+ mPreference.setEntryValues(R.array.enabled_networks_values);
+ CharSequence[] testEntries3 = {mContext.getString(R.string.network_5G)
+ + mContext.getString(R.string.network_recommended)
+ , mContext.getString(R.string.network_lte_pure)
+ , mContext.getString(R.string.network_3G)
+ , mContext.getString(R.string.network_2G)};
+ CharSequence[] testEntryValues3 = {"26", "9", "0", "1"};
+
+ mController.add5gListItem(mPreference);
+
+ assertThat(mPreference.getEntries()).isEqualTo(testEntries3);
+ assertThat(mPreference.getEntryValues()).isEqualTo(testEntryValues3);
+ }
+
+ /**
+ * @string/preferred_network_mode_choices_world_mode
+ * Before | After
+ * "Global" , 10|@string/network_global , 27
+ * "LTE / CDMA" , 8 |"LTE / CDMA" , 8
+ * "LTE / GSM / UMTS" , 9 |"LTE / GSM / UMTS" , 9
+ */
+ @Test
+ public void add5gListItem_worldPhone_Global() {
+ mPreference.setEntries(R.array.preferred_network_mode_choices_world_mode);
+ mPreference.setEntryValues(R.array.preferred_network_mode_values_world_mode);
+ CharSequence[] testEntries = {mContext.getString(R.string.network_global)
+ , "LTE / CDMA"
+ , "LTE / GSM / UMTS"};
+ CharSequence[] testEntryValues = {"27", "8", "9"};
+
+ mController.add5gListItem(mPreference);
+
+ assertThat(mPreference.getEntries()).isEqualTo(testEntries);
+ assertThat(mPreference.getEntryValues()).isEqualTo(testEntryValues);
+ }
+
+ /**
+ * @string/enabled_networks_tdscdma_choices
+ * Before | After
+ * @string/network_lte, 22|@string/network_5G + @string/network_recommended , 33
+ * @string/network_3G , 18|@string/network_lte_pure, 22
+ * @string/network_2G , 1 |@string/network_3G , 18
+ * |@string/network_2G , 1
+ */
+ @Test
+ public void add5gListItem_td_5gTd() {
+ mPreference.setEntries(R.array.enabled_networks_tdscdma_choices);
+ mPreference.setEntryValues(R.array.enabled_networks_tdscdma_values);
+ CharSequence[] testEntries = {mContext.getString(R.string.network_5G)
+ + mContext.getString(R.string.network_recommended)
+ , mContext.getString(R.string.network_lte_pure)
+ , mContext.getString(R.string.network_3G)
+ , mContext.getString(R.string.network_2G)};
+ CharSequence[] testEntryValues = {"33", "22", "18", "1"};
+
+ mController.add5gListItem(mPreference);
+
+ assertThat(mPreference.getEntries()).isEqualTo(testEntries);
+ assertThat(mPreference.getEntryValues()).isEqualTo(testEntryValues);
+ }
+
+ @Test
+ public void add5gListItem_noLte_no5g() {
+ mPreference.setEntries(R.array.enabled_networks_except_lte_choices);
+ mPreference.setEntryValues(R.array.enabled_networks_except_lte_values);
+ CharSequence[] testEntries = {mContext.getString(R.string.network_3G)
+ , mContext.getString(R.string.network_2G)};
+ CharSequence[] testEntryValues = {"0", "1"};
+
+ mController.add5gListItem(mPreference);
+
+ assertThat(mPreference.getEntries()).isEqualTo(testEntries);
+ assertThat(mPreference.getEntryValues()).isEqualTo(testEntryValues);
+ }
+
@Test
public void onPreferenceChange_updateSuccess() {
doReturn(true).when(mTelephonyManager).setPreferredNetworkType(SUB_ID,
diff --git a/tests/robotests/src/com/android/settings/nfc/PaymentSettingsTest.java b/tests/robotests/src/com/android/settings/nfc/PaymentSettingsTest.java
index 1293ee4..513da65 100644
--- a/tests/robotests/src/com/android/settings/nfc/PaymentSettingsTest.java
+++ b/tests/robotests/src/com/android/settings/nfc/PaymentSettingsTest.java
@@ -29,6 +29,10 @@
import android.os.UserHandle;
import android.os.UserManager;
+import androidx.preference.Preference;
+import androidx.preference.PreferenceManager;
+import androidx.preference.PreferenceScreen;
+
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -113,6 +117,34 @@
assertThat(niks).containsAllOf(FOREGROUND_KEY, PAYMENT_KEY, PAYMENT_SCREEN_KEY);
}
+ @Test
+ public void isShowEmptyImage_hasVisiblePreference_returnFalse() {
+ final PaymentSettings paymentSettings = new PaymentSettings();
+ final PreferenceManager preferenceManager = new PreferenceManager(mContext);
+ final PreferenceScreen screen = preferenceManager.createPreferenceScreen(mContext);
+ final Preference preference1 = new Preference(mContext);
+ screen.addPreference(preference1);
+ final Preference preference2 = new Preference(mContext);
+ screen.addPreference(preference2);
+
+ assertThat(paymentSettings.isShowEmptyImage(screen)).isFalse();
+ }
+
+ @Test
+ public void isShowEmptyImage_hasNoVisiblePreference_returnTrue() {
+ final PaymentSettings paymentSettings = new PaymentSettings();
+ final PreferenceManager preferenceManager = new PreferenceManager(mContext);
+ final PreferenceScreen screen = preferenceManager.createPreferenceScreen(mContext);
+ final Preference preference1 = new Preference(mContext);
+ preference1.setVisible(false);
+ screen.addPreference(preference1);
+ final Preference preference2 = new Preference(mContext);
+ screen.addPreference(preference2);
+ preference2.setVisible(false);
+
+ assertThat(paymentSettings.isShowEmptyImage(screen)).isTrue();
+ }
+
@Implements(PaymentBackend.class)
public static class ShadowPaymentBackend {
private ArrayList<PaymentBackend.PaymentAppInfo> mAppInfos;
diff --git a/tests/robotests/src/com/android/settings/notification/ConfigureNotificationPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/notification/ConfigureNotificationPreferenceControllerTest.java
new file mode 100644
index 0000000..83fe07a
--- /dev/null
+++ b/tests/robotests/src/com/android/settings/notification/ConfigureNotificationPreferenceControllerTest.java
@@ -0,0 +1,59 @@
+/*
+ * Copyright (C) 2019 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.android.settings.notification;
+
+import static com.google.common.truth.Truth.assertThat;
+
+import android.content.Context;
+
+import com.android.settings.testutils.shadow.ShadowNotificationBackend;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.robolectric.RobolectricTestRunner;
+import org.robolectric.RuntimeEnvironment;
+import org.robolectric.annotation.Config;
+
+@RunWith(RobolectricTestRunner.class)
+@Config(shadows = ShadowNotificationBackend.class)
+public class ConfigureNotificationPreferenceControllerTest {
+
+ private ConfigureNotificationPreferenceController mController;
+ private Context mContext;
+
+ @Before
+ public void setUp() {
+ mContext = RuntimeEnvironment.application;
+ mController = new ConfigureNotificationPreferenceController(mContext, "key");
+ }
+
+ @Test
+ public void getSummary_noBlockedApps() {
+ ShadowNotificationBackend.setBlockedAppCount(0);
+
+ assertThat(mController.getSummary().toString()).contains("On");
+ }
+
+ @Test
+ public void getSummary_someBlockedApps() {
+ ShadowNotificationBackend.setBlockedAppCount(5);
+
+ assertThat(mController.getSummary().toString()).contains("Off");
+ assertThat(mController.getSummary().toString()).contains("5");
+ }
+}
diff --git a/tests/robotests/src/com/android/settings/notification/ConfigureNotificationSettingsTest.java b/tests/robotests/src/com/android/settings/notification/ConfigureNotificationSettingsTest.java
deleted file mode 100644
index 523b496..0000000
--- a/tests/robotests/src/com/android/settings/notification/ConfigureNotificationSettingsTest.java
+++ /dev/null
@@ -1,85 +0,0 @@
-/*
- * Copyright (C) 2017 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.android.settings.notification;
-
-import static com.android.settings.notification.ConfigureNotificationSettings.SUMMARY_PROVIDER_FACTORY;
-
-import static com.google.common.truth.Truth.assertThat;
-
-import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.spy;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
-
-import android.app.Activity;
-
-import com.android.settings.dashboard.SummaryLoader;
-import com.android.settings.notification.ConfigureNotificationSettings.SummaryProvider;
-
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.mockito.ArgumentCaptor;
-import org.robolectric.Robolectric;
-import org.robolectric.RobolectricTestRunner;
-
-@RunWith(RobolectricTestRunner.class)
-public class ConfigureNotificationSettingsTest {
-
- private Activity mActivity;
-
- @Before
- public void setUp() {
- mActivity = spy(Robolectric.buildActivity(Activity.class).get());
- }
-
- @Test
- public void getSummary_noneBlocked() {
- SummaryLoader loader = mock(SummaryLoader.class);
- NotificationBackend backend = mock(NotificationBackend.class);
- when(backend.getBlockedAppCount()).thenReturn(0);
- SummaryProvider provider =
- (SummaryProvider) SUMMARY_PROVIDER_FACTORY.createSummaryProvider(mActivity, loader);
- provider.setBackend(backend);
-
- provider.setListening(true);
-
- ArgumentCaptor<CharSequence> captor = ArgumentCaptor.forClass(CharSequence.class);
- verify(loader).setSummary(any(), captor.capture());
-
- assertThat(captor.getValue().toString()).contains("On");
- }
-
- @Test
- public void getSummary_someBlocked() {
- SummaryLoader loader = mock(SummaryLoader.class);
- NotificationBackend backend = mock(NotificationBackend.class);
- when(backend.getBlockedAppCount()).thenReturn(5);
- SummaryProvider provider =
- (SummaryProvider) SUMMARY_PROVIDER_FACTORY.createSummaryProvider(mActivity, loader);
- provider.setBackend(backend);
-
- provider.setListening(true);
-
- ArgumentCaptor<CharSequence> captor = ArgumentCaptor.forClass(CharSequence.class);
- verify(loader).setSummary(any(), captor.capture());
-
- assertThat(captor.getValue().toString()).contains("Off");
- assertThat(captor.getValue().toString()).contains("5");
- }
-}
diff --git a/tests/robotests/src/com/android/settings/slices/SlicePreferenceTest.java b/tests/robotests/src/com/android/settings/slices/SlicePreferenceTest.java
new file mode 100644
index 0000000..1d3d710
--- /dev/null
+++ b/tests/robotests/src/com/android/settings/slices/SlicePreferenceTest.java
@@ -0,0 +1,73 @@
+/*
+ * Copyright (C) 2019 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.android.settings.slices;
+
+import static com.google.common.truth.Truth.assertThat;
+
+import static org.mockito.Mockito.spy;
+
+import android.content.Context;
+import android.net.Uri;
+import android.view.View;
+
+import androidx.slice.Slice;
+import androidx.slice.widget.SliceView;
+
+import com.android.settings.R;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.MockitoAnnotations;
+import org.robolectric.Robolectric;
+import org.robolectric.RobolectricTestRunner;
+import org.robolectric.RuntimeEnvironment;
+
+@RunWith(RobolectricTestRunner.class)
+public class SlicePreferenceTest {
+
+ private SlicePreference mSlicePreference;
+ private Context mContext;
+
+ @Before
+ public void setUp() {
+ MockitoAnnotations.initMocks(this);
+ mContext = spy(RuntimeEnvironment.application);
+
+ mSlicePreference = new SlicePreference(mContext, Robolectric.buildAttributeSet()
+ .setStyleAttribute("@style/SlicePreference")
+ .build());
+ }
+
+ @Test
+ public void onSliceUpdated_null_hideSliceView() {
+ final SliceView sliceView = mSlicePreference.findViewById(R.id.slice_view);
+
+ mSlicePreference.onSliceUpdated(null);
+
+ assertThat(sliceView.getVisibility()).isEqualTo(View.GONE);
+ }
+
+ @Test
+ public void onSliceUpdated_notNull_showSliceView() {
+ final SliceView sliceView = mSlicePreference.findViewById(R.id.slice_view);
+
+ mSlicePreference.onSliceUpdated(new Slice.Builder(Uri.parse("uri")).build());
+
+ assertThat(sliceView.getVisibility()).isEqualTo(View.VISIBLE);
+ }
+}
\ No newline at end of file
diff --git a/tests/robotests/src/com/android/settings/testutils/shadow/ShadowNotificationBackend.java b/tests/robotests/src/com/android/settings/testutils/shadow/ShadowNotificationBackend.java
new file mode 100644
index 0000000..4e6cbde
--- /dev/null
+++ b/tests/robotests/src/com/android/settings/testutils/shadow/ShadowNotificationBackend.java
@@ -0,0 +1,37 @@
+/*
+ * Copyright (C) 2019 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License
+ */
+
+package com.android.settings.testutils.shadow;
+
+import com.android.settings.notification.NotificationBackend;
+
+import org.robolectric.annotation.Implementation;
+import org.robolectric.annotation.Implements;
+
+@Implements(NotificationBackend.class)
+public class ShadowNotificationBackend {
+
+ private static int sBlockAppCount;
+
+ @Implementation
+ protected int getBlockedAppCount() {
+ return sBlockAppCount;
+ }
+
+ public static void setBlockedAppCount(int blockAppCount) {
+ sBlockAppCount = blockAppCount;
+ }
+}
diff --git a/tests/robotests/src/com/android/settings/testutils/shadow/ShadowTileUtils.java b/tests/robotests/src/com/android/settings/testutils/shadow/ShadowTileUtils.java
index 8736fe8..e46d72f 100644
--- a/tests/robotests/src/com/android/settings/testutils/shadow/ShadowTileUtils.java
+++ b/tests/robotests/src/com/android/settings/testutils/shadow/ShadowTileUtils.java
@@ -18,6 +18,7 @@
import android.content.Context;
import android.content.IContentProvider;
+import android.net.Uri;
import android.util.Pair;
import com.android.settings.R;
@@ -35,14 +36,14 @@
public static final String MOCK_SUMMARY = "summary";
@Implementation
- protected static String getTextFromUri(Context context, String uriString,
+ protected static String getTextFromUri(Context context, Uri uri,
Map<String, IContentProvider> providerMap, String key) {
return MOCK_SUMMARY;
}
@Implementation
protected static Pair<String, Integer> getIconFromUri(Context context, String packageName,
- String uriString, Map<String, IContentProvider> providerMap) {
+ Uri uri, Map<String, IContentProvider> providerMap) {
return Pair.create(RuntimeEnvironment.application.getPackageName(), R.drawable.ic_settings_accent);
}
}
diff --git a/tests/robotests/src/com/android/settings/users/UserSettingsTest.java b/tests/robotests/src/com/android/settings/users/UserSettingsTest.java
index 1a98238..5853308 100644
--- a/tests/robotests/src/com/android/settings/users/UserSettingsTest.java
+++ b/tests/robotests/src/com/android/settings/users/UserSettingsTest.java
@@ -32,7 +32,6 @@
import android.content.ComponentName;
import android.content.Context;
import android.content.SharedPreferences;
-import android.content.pm.UserInfo;
import android.graphics.drawable.Drawable;
import android.os.UserHandle;
import android.os.UserManager;
@@ -49,8 +48,6 @@
import androidx.preference.PreferenceManager;
import androidx.preference.PreferenceScreen;
-import com.android.settings.R;
-import com.android.settings.dashboard.SummaryLoader;
import com.android.settings.testutils.shadow.ShadowDevicePolicyManager;
import com.android.settings.testutils.shadow.ShadowUserManager;
import com.android.settingslib.RestrictedPreference;
@@ -86,14 +83,11 @@
private UserPreference mMePreference;
@Mock
private UserManager mUserManager;
- @Mock
- private SummaryLoader mSummaryLoader;
private FragmentActivity mActivity;
private Context mContext;
private UserSettings mFragment;
private UserCapabilities mUserCapabilities;
- private SummaryLoader.SummaryProvider mSummaryProvider;
@Before
public void setUp() {
@@ -123,9 +117,6 @@
final SharedPreferences prefs = mock(SharedPreferences .class);
when(mMockPreferenceManager.getSharedPreferences()).thenReturn(prefs);
when(mMockPreferenceManager.getContext()).thenReturn(mContext);
-
- mSummaryProvider =
- UserSettings.SUMMARY_PROVIDER_FACTORY.createSummaryProvider(mActivity, mSummaryLoader);
}
@After
@@ -135,19 +126,6 @@
}
@Test
- public void setListening_shouldSetSummaryWithUserName() {
- final String name = "John";
- final UserInfo userInfo = new UserInfo();
- userInfo.name = name;
- when(mUserManager.getUserInfo(anyInt())).thenReturn(userInfo);
-
- mSummaryProvider.setListening(true);
-
- verify(mSummaryLoader)
- .setSummary(mSummaryProvider, mActivity.getString(R.string.users_summary, name));
- }
-
- @Test
public void testAssignDefaultPhoto_ContextNull_ReturnFalseAndNotCrash() {
// Should not crash here
assertThat(UserSettings.assignDefaultPhoto(null, 0)).isFalse();
diff --git a/tests/robotests/src/com/android/settings/wfd/WifiDisplayPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/wfd/WifiDisplayPreferenceControllerTest.java
new file mode 100644
index 0000000..c90b19b
--- /dev/null
+++ b/tests/robotests/src/com/android/settings/wfd/WifiDisplayPreferenceControllerTest.java
@@ -0,0 +1,77 @@
+/*
+ * Copyright (C) 2019 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License
+ */
+
+package com.android.settings.wfd;
+
+import static com.google.common.truth.Truth.assertThat;
+
+import static org.mockito.ArgumentMatchers.anyInt;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.when;
+
+import android.content.Context;
+import android.content.pm.PackageManager;
+import android.media.MediaRouter;
+
+import com.android.settings.R;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.robolectric.RobolectricTestRunner;
+import org.robolectric.RuntimeEnvironment;
+
+@RunWith(RobolectricTestRunner.class)
+public class WifiDisplayPreferenceControllerTest {
+ private Context mContext;
+ private WifiDisplayPreferenceController mWifiDisplayPreferenceController;
+ @Mock
+ private MediaRouter mMediaRouter;
+ @Mock
+ private PackageManager mPackageManager;
+
+ @Before
+ public void setUp() {
+ MockitoAnnotations.initMocks(this);
+ mContext = spy(RuntimeEnvironment.application);
+ when(mContext.getSystemService(Context.MEDIA_ROUTER_SERVICE)).thenReturn(mMediaRouter);
+ when(mContext.getPackageManager()).thenReturn(mPackageManager);
+ when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_WIFI_DIRECT)).thenReturn(true);
+ mWifiDisplayPreferenceController = new WifiDisplayPreferenceController(mContext, "key");
+ }
+
+ @Test
+ public void getSummary_disconnected_shouldProvideDisconnectedSummary() {
+ assertThat(mWifiDisplayPreferenceController.getSummary().toString()).contains(
+ mContext.getString(R.string.disconnected));
+ }
+
+ @Test
+ public void getSummary_connected_shouldProvideConnectedSummary() {
+ final MediaRouter.RouteInfo route = mock(MediaRouter.RouteInfo.class);
+ when(mMediaRouter.getRouteCount()).thenReturn(1);
+ when(mMediaRouter.getRouteAt(0)).thenReturn(route);
+ when(route.matchesTypes(anyInt())).thenReturn(true);
+ when(route.isSelected()).thenReturn(true);
+ when(route.isConnecting()).thenReturn(false);
+
+ assertThat(mWifiDisplayPreferenceController.getSummary().toString()).contains(
+ mContext.getString(R.string.wifi_display_status_connected));
+ }
+}
diff --git a/tests/robotests/src/com/android/settings/wfd/WifiDisplaySettingsTest.java b/tests/robotests/src/com/android/settings/wfd/WifiDisplaySettingsTest.java
index a76a1df..1f4fef6 100644
--- a/tests/robotests/src/com/android/settings/wfd/WifiDisplaySettingsTest.java
+++ b/tests/robotests/src/com/android/settings/wfd/WifiDisplaySettingsTest.java
@@ -19,8 +19,6 @@
import static com.google.common.truth.Truth.assertThat;
import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.never;
-import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import android.app.Activity;
@@ -30,9 +28,6 @@
import android.media.MediaRouter;
import android.net.wifi.p2p.WifiP2pManager;
-import com.android.settings.R;
-import com.android.settings.dashboard.SummaryLoader;
-
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -46,45 +41,16 @@
@Mock
private Activity mActivity;
@Mock
- private SummaryLoader mSummaryLoader;
- @Mock
private MediaRouter mMediaRouter;
@Mock
private PackageManager mPackageManager;
- private SummaryLoader.SummaryProvider mSummaryProvider;
-
@Before
public void setUp() {
MockitoAnnotations.initMocks(this);
when(mActivity.getSystemService(Context.MEDIA_ROUTER_SERVICE)).thenReturn(mMediaRouter);
when(mActivity.getPackageManager()).thenReturn(mPackageManager);
when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_WIFI_DIRECT)).thenReturn(true);
-
- mSummaryProvider = WifiDisplaySettings.SUMMARY_PROVIDER_FACTORY
- .createSummaryProvider(mActivity, mSummaryLoader);
- }
-
- @Test
- public void listenToSummary_disconnected_shouldProvideDisconnectedSummary() {
- mSummaryProvider.setListening(true);
-
- verify(mActivity).getString(R.string.disconnected);
- verify(mActivity, never()).getString(R.string.wifi_display_status_connected);
- }
-
- @Test
- public void listenToSummary_connected_shouldProvideConnectedSummary() {
- final MediaRouter.RouteInfo route = mock(MediaRouter.RouteInfo.class);
- when(mMediaRouter.getRouteCount()).thenReturn(1);
- when(mMediaRouter.getRouteAt(0)).thenReturn(route);
- when(route.matchesTypes(MediaRouter.ROUTE_TYPE_REMOTE_DISPLAY)).thenReturn(true);
- when(route.isSelected()).thenReturn(true);
- when(route.isConnecting()).thenReturn(false);
-
- mSummaryProvider.setListening(true);
-
- verify(mActivity).getString(R.string.wifi_display_status_connected);
}
@Test
diff --git a/tests/robotests/src/com/android/settings/wifi/ConfigureWifiSettingsTest.java b/tests/robotests/src/com/android/settings/wifi/ConfigureWifiSettingsTest.java
index 2e3a111..d1d7885 100644
--- a/tests/robotests/src/com/android/settings/wifi/ConfigureWifiSettingsTest.java
+++ b/tests/robotests/src/com/android/settings/wifi/ConfigureWifiSettingsTest.java
@@ -2,14 +2,9 @@
import static com.google.common.truth.Truth.assertThat;
-import static org.mockito.Mockito.doReturn;
-import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.spy;
-import static org.mockito.Mockito.when;
import android.content.Context;
-import android.net.ConnectivityManager;
-import android.net.NetworkInfo;
import com.android.settings.testutils.XmlTestUtils;
@@ -54,41 +49,4 @@
assertThat(keys).isNotNull();
assertThat(niks).containsAllIn(keys);
}
-
- @Test
- public void testNonIndexableKeys_noConnection_blocksIP() {
- ConnectivityManager manager = mock(ConnectivityManager.class);
- when(manager.getActiveNetworkInfo()).thenReturn(null);
- doReturn(manager).when(mContext).getSystemService(Context.CONNECTIVITY_SERVICE);
-
- final List<String> niks =
- ConfigureWifiSettings.SEARCH_INDEX_DATA_PROVIDER.getNonIndexableKeys(mContext);
- assertThat(niks).contains(ConfigureWifiSettings.KEY_IP_ADDRESS);
- }
-
- @Test
- public void testNonIndexableKeys_wifiConnection_blocksIP() {
- ConnectivityManager manager = mock(ConnectivityManager.class);
- NetworkInfo info = mock(NetworkInfo.class);
- when(info.getType()).thenReturn(ConnectivityManager.TYPE_WIFI);
- when(manager.getActiveNetworkInfo()).thenReturn(info);
- doReturn(manager).when(mContext).getSystemService(Context.CONNECTIVITY_SERVICE);
-
- final List<String> niks =
- ConfigureWifiSettings.SEARCH_INDEX_DATA_PROVIDER.getNonIndexableKeys(mContext);
- assertThat(niks).contains(ConfigureWifiSettings.KEY_IP_ADDRESS);
- }
-
- @Test
- public void testNonIndexableKeys_mobileConnection_blocksIP() {
- ConnectivityManager manager = mock(ConnectivityManager.class);
- NetworkInfo info = mock(NetworkInfo.class);
- when(info.getType()).thenReturn(ConnectivityManager.TYPE_MOBILE);
- when(manager.getActiveNetworkInfo()).thenReturn(info);
- doReturn(manager).when(mContext).getSystemService(Context.CONNECTIVITY_SERVICE);
-
- final List<String> niks =
- ConfigureWifiSettings.SEARCH_INDEX_DATA_PROVIDER.getNonIndexableKeys(mContext);
- assertThat(niks).doesNotContain(ConfigureWifiSettings.KEY_IP_ADDRESS);
- }
}
diff --git a/tests/robotests/src/com/android/settings/wifi/WifiInfoPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/wifi/WifiInfoPreferenceControllerTest.java
deleted file mode 100644
index 85d7726..0000000
--- a/tests/robotests/src/com/android/settings/wifi/WifiInfoPreferenceControllerTest.java
+++ /dev/null
@@ -1,225 +0,0 @@
-/*
- * Copyright (C) 2017 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.android.settings.wifi;
-
-import static androidx.lifecycle.Lifecycle.Event.ON_PAUSE;
-import static androidx.lifecycle.Lifecycle.Event.ON_RESUME;
-
-import static com.google.common.truth.Truth.assertThat;
-
-import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.ArgumentMatchers.anyString;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
-
-import android.content.BroadcastReceiver;
-import android.content.Context;
-import android.content.IntentFilter;
-import android.content.res.Resources;
-import android.net.wifi.WifiInfo;
-import android.net.wifi.WifiManager;
-import android.provider.Settings;
-
-import androidx.lifecycle.LifecycleOwner;
-import androidx.preference.Preference;
-import androidx.preference.PreferenceScreen;
-
-import com.android.settings.R;
-import com.android.settingslib.core.lifecycle.Lifecycle;
-
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.mockito.Answers;
-import org.mockito.Mock;
-import org.mockito.MockitoAnnotations;
-import org.robolectric.RobolectricTestRunner;
-
-@RunWith(RobolectricTestRunner.class)
-public class WifiInfoPreferenceControllerTest {
-
- private static final String TEST_MAC_ADDRESS = "42:0a:23:43:ac:02";
-
- @Mock
- private Context mContext;
- @Mock(answer = Answers.RETURNS_DEEP_STUBS)
- private WifiManager mWifiManager;
- @Mock
- private PreferenceScreen mScreen;
- @Mock
- private Preference mIpPreference;
- @Mock
- private Preference mMacPreference;
- @Mock
- private WifiInfo mWifiInfo;
- @Mock
- private Resources mResources;
-
- private Lifecycle mLifecycle;
- private LifecycleOwner mLifecycleOwner;
- private WifiInfoPreferenceController mController;
-
- @Before
- public void setUp() {
- MockitoAnnotations.initMocks(this);
- mLifecycleOwner = () -> mLifecycle;
- mLifecycle = new Lifecycle(mLifecycleOwner);
- when(mContext.getSystemService(WifiManager.class))
- .thenReturn(mWifiManager);
- when(mScreen.findPreference(anyString()))
- .thenReturn(mMacPreference)
- .thenReturn(mIpPreference);
- when(mWifiManager.getConnectionInfo()).thenReturn(mWifiInfo);
- when(mWifiManager.getCurrentNetwork()).thenReturn(null);
- when(mContext.getResources()).thenReturn(mResources);
- mController = new WifiInfoPreferenceController(mContext, mLifecycle, mWifiManager);
- }
-
- @Test
- public void testIsAvailable_shouldAlwaysReturnTrue() {
- assertThat(mController.isAvailable()).isTrue();
- }
-
- @Test
- public void getPreferenceKey_shouldReturnNull() {
- assertThat(mController.getPreferenceKey()).isNull();
- }
-
- @Test
- public void runThroughLifecycle_shouldInstallListenerOnResume() {
- mLifecycle.handleLifecycleEvent(ON_RESUME);
- verify(mContext).registerReceiver(any(BroadcastReceiver.class), any(IntentFilter.class));
-
- mLifecycle.handleLifecycleEvent(ON_PAUSE);
- verify(mContext).unregisterReceiver(any(BroadcastReceiver.class));
- }
-
- @Test
- public void onResume_shouldUpdateWifiInfo() {
- when(mWifiInfo.getMacAddress()).thenReturn(TEST_MAC_ADDRESS);
-
- mController.displayPreference(mScreen);
- mController.onResume();
-
- verify(mMacPreference).setSummary(TEST_MAC_ADDRESS);
- verify(mIpPreference).setSummary(any());
- }
-
- @Test
- public void updateWifiInfo_nullWifiInfoWithMacRandomizationOff_setMacUnavailable() {
- when(mResources.getBoolean(
- com.android.internal.R.bool.config_wifi_connected_mac_randomization_supported))
- .thenReturn(false);
- mController.displayPreference(mScreen);
- when(mWifiManager.getConnectionInfo()).thenReturn(null);
-
- mController.updateWifiInfo();
-
- verify(mMacPreference).setSummary(R.string.status_unavailable);
- }
-
- @Test
- public void updateWifiInfo_nullMacWithMacRandomizationOff_setMacUnavailable() {
- when(mResources.getBoolean(
- com.android.internal.R.bool.config_wifi_connected_mac_randomization_supported))
- .thenReturn(false);
- mController.displayPreference(mScreen);
- when(mWifiInfo.getMacAddress()).thenReturn(null);
-
- mController.updateWifiInfo();
-
- verify(mMacPreference).setSummary(R.string.status_unavailable);
- }
-
- @Test
- public void updateWifiInfo_defaultMacWithMacRandomizationOff_setMacUnavailable() {
- when(mResources.getBoolean(
- com.android.internal.R.bool.config_wifi_connected_mac_randomization_supported))
- .thenReturn(false);
- mController.displayPreference(mScreen);
- when(mWifiInfo.getMacAddress()).thenReturn(WifiInfo.DEFAULT_MAC_ADDRESS);
-
- mController.updateWifiInfo();
-
- verify(mMacPreference).setSummary(R.string.status_unavailable);
- }
-
- @Test
- public void updateWifiInfo_validMacWithMacRandomizationOff_setValidMac() {
- when(mResources.getBoolean(
- com.android.internal.R.bool.config_wifi_connected_mac_randomization_supported))
- .thenReturn(false);
- mController.displayPreference(mScreen);
- when(mWifiInfo.getMacAddress()).thenReturn(TEST_MAC_ADDRESS);
-
- mController.updateWifiInfo();
-
- verify(mMacPreference).setSummary(TEST_MAC_ADDRESS);
- }
-
- @Test
- public void updateWifiInfo_nullWifiInfoWithMacRandomizationOn_setMacUnavailable() {
- when(mResources.getBoolean(
- com.android.internal.R.bool.config_wifi_connected_mac_randomization_supported))
- .thenReturn(true);
- mController.displayPreference(mScreen);
- when(mWifiManager.getConnectionInfo()).thenReturn(null);
-
- mController.updateWifiInfo();
-
- verify(mMacPreference).setSummary(R.string.status_unavailable);
- }
-
- @Test
- public void updateWifiInfo_nullMacWithMacRandomizationOn_setMacUnavailable() {
- when(mResources.getBoolean(
- com.android.internal.R.bool.config_wifi_connected_mac_randomization_supported))
- .thenReturn(true);
- mController.displayPreference(mScreen);
- when(mWifiInfo.getMacAddress()).thenReturn(null);
-
- mController.updateWifiInfo();
-
- verify(mMacPreference).setSummary(R.string.status_unavailable);
- }
-
- @Test
- public void updateWifiInfo_defaultMacWithMacRandomizationOn_setMacRandomized() {
- when(mResources.getBoolean(
- com.android.internal.R.bool.config_wifi_connected_mac_randomization_supported))
- .thenReturn(true);
- mController.displayPreference(mScreen);
- when(mWifiInfo.getMacAddress()).thenReturn(WifiInfo.DEFAULT_MAC_ADDRESS);
-
- mController.updateWifiInfo();
-
- verify(mMacPreference).setSummary(R.string.wifi_status_mac_randomized);
- }
-
- @Test
- public void updateWifiInfo_validMacWithMacRandomizationOn_setValidMac() {
- when(mResources.getBoolean(
- com.android.internal.R.bool.config_wifi_connected_mac_randomization_supported))
- .thenReturn(true);
- mController.displayPreference(mScreen);
- when(mWifiInfo.getMacAddress()).thenReturn(TEST_MAC_ADDRESS);
-
- mController.updateWifiInfo();
-
- verify(mMacPreference).setSummary(TEST_MAC_ADDRESS);
- }
-}
diff --git a/tests/robotests/src/com/android/settings/wifi/details/WifiDetailPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/wifi/details/WifiDetailPreferenceControllerTest.java
index 010fb74..7f65b06 100644
--- a/tests/robotests/src/com/android/settings/wifi/details/WifiDetailPreferenceControllerTest.java
+++ b/tests/robotests/src/com/android/settings/wifi/details/WifiDetailPreferenceControllerTest.java
@@ -1845,6 +1845,31 @@
assertThat(icon).isNotNull();
}
+ @Test
+ public void checkMacTitle_whenPrivacyRandomizedMac_shouldBeRandom() {
+ setUpForDisconnectedNetwork();
+ mockWifiConfig.macRandomizationSetting = WifiConfiguration.RANDOMIZATION_PERSISTENT;
+ when(mockWifiConfig.getRandomizedMacAddress()).thenReturn(mockMacAddress);
+ when(mockMacAddress.toString()).thenReturn(RANDOMIZED_MAC_ADDRESS);
+
+ displayAndResume();
+
+ verify(mockMacAddressPref).setTitle(R.string.wifi_advanced_randomized_mac_address_title);
+ }
+
+ @Test
+ public void checkMacTitle_whenPrivacyDeviceMac_shouldBeFactory() {
+ setUpForDisconnectedNetwork();
+ mockWifiConfig.macRandomizationSetting = WifiConfiguration.RANDOMIZATION_NONE;
+ when(mockWifiConfig.getRandomizedMacAddress()).thenReturn(mockMacAddress);
+ when(mockWifiManager.getFactoryMacAddresses())
+ .thenReturn(new String[]{FACTORY_MAC_ADDRESS});
+
+ displayAndResume();
+
+ verify(mockMacAddressPref).setTitle(R.string.wifi_advanced_factory_mac_address_title);
+ }
+
private ActionButtonsPreference createMock() {
final ActionButtonsPreference pref = mock(ActionButtonsPreference.class);
when(pref.setButton1Text(anyInt())).thenReturn(pref);
diff --git a/tests/robotests/src/com/android/settings/wifi/p2p/P2pCategoryPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/wifi/p2p/P2pCategoryPreferenceControllerTest.java
index c2d99a6..f7962eb 100644
--- a/tests/robotests/src/com/android/settings/wifi/p2p/P2pCategoryPreferenceControllerTest.java
+++ b/tests/robotests/src/com/android/settings/wifi/p2p/P2pCategoryPreferenceControllerTest.java
@@ -20,7 +20,7 @@
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.Mockito.atLeastOnce;
-import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
@@ -60,8 +60,8 @@
}
@Test
- public void isAlwaysAvailable() {
- assertThat(mController.isAvailable()).isTrue();
+ public void isAvailable_withInitialEmptyGroup_shouldBeFalse() {
+ assertThat(mController.isAvailable()).isFalse();
}
@Test
@@ -69,7 +69,7 @@
mController.removeAllChildren();
verify(mCategory).removeAll();
- verify(mCategory).setVisible(false);
+ verify(mCategory, times(2)).setVisible(false);
}
@Test
@@ -79,7 +79,7 @@
verify(mCategory).addPreference(pref);
verify(mCategory, atLeastOnce()).setVisible(true);
- verify(mCategory, never()).setVisible(false);
+ verify(mCategory).setVisible(false);
}
@Test