commit 476d79566752bfc128a7b3ae200c735d683370f7
author Amith Yamasani <yamasani@google.com> Fri Jan 21 09:28:31 2011 -0800
committer Amith Yamasani <yamasani@google.com> Fri Jan 21 11:27:29 2011 -0800
tree f9ea3a7b606f594c12ffc99e82ca23112539e70e
parent 5dc460e407b782fc8f2cbc5167bfe40eff50a74c

NPE check in VpnSettings.

Bug: 3368545

Also fix a couple of bugs in TetherSettings:

Bug: 3090156 - view was being reused without removing from old dialog
Bug: 3368493 - preference being removed a second time

Change-Id: I8fe513d41e1f3af6994783be5ead69b6bd205711

src/com/android/settings/TetherSettings.java

diff --git a/src/com/android/settings/TetherSettings.java b/src/com/android/settings/TetherSettings.java
index 81d23ab..085a089 100644
--- a/src/com/android/settings/TetherSettings.java
+++ b/src/com/android/settings/TetherSettings.java
@@ -16,7 +16,6 @@
 
 package com.android.settings;
 
-import com.android.settings.bluetooth.BluetoothSettings;
 import com.android.settings.wifi.WifiApEnabler;
 
 import android.app.Activity;
@@ -35,6 +34,10 @@
 import android.preference.CheckBoxPreference;
 import android.preference.Preference;
 import android.preference.PreferenceScreen;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.view.ViewParent;
 import android.webkit.WebView;
 
 import java.io.InputStream;
@@ -86,8 +89,10 @@
     }
 
     @Override
-    public void onActivityCreated(Bundle savedInstanceState) {
-        super.onActivityCreated(savedInstanceState);
+    public View onCreateView(LayoutInflater inflater, ViewGroup container,
+            Bundle savedInstanceState) {
+        View view = super.onCreateView(inflater, container, savedInstanceState);
+
         final Activity activity = getActivity();
         mBluetoothPan = new BluetoothPan(activity);
 
@@ -108,7 +113,6 @@
         boolean wifiAvailable = mWifiRegexs.length != 0;
         boolean bluetoothAvailable = mBluetoothRegexs.length != 0;
 
-
         if (!usbAvailable || Utils.isMonkeyRunning()) {
             getPreferenceScreen().removePreference(mUsbTether);
         }
@@ -144,6 +148,8 @@
         */
         mWifiApEnabler = new WifiApEnabler(activity, mEnableWifiAp);
         mView = new WebView(activity);
+
+        return view;
     }
 
     @Override
@@ -181,7 +187,11 @@
             }
 
             mView.loadUrl(url);
-
+            // Detach from old parent first
+            ViewParent parent = mView.getParent();
+            if (parent != null && parent instanceof ViewGroup) {
+                ((ViewGroup) parent).removeView(mView);
+            }
             return new AlertDialog.Builder(getActivity())
                 .setCancelable(true)
                 .setTitle(R.string.tethering_help_button_text)

src/com/android/settings/vpn/VpnSettings.java

diff --git a/src/com/android/settings/vpn/VpnSettings.java b/src/com/android/settings/vpn/VpnSettings.java
index bd1cc9e..03687f2 100644
--- a/src/com/android/settings/vpn/VpnSettings.java
+++ b/src/com/android/settings/vpn/VpnSettings.java
@@ -725,6 +725,8 @@
     }
 
     private void startVpnEditor(final VpnProfile profile, boolean add) {
+        if (getActivity() == null) return;
+
         Bundle args = new Bundle();
         args.putParcelable(KEY_VPN_PROFILE, profile);
         // TODO: Show different titles for add and edit.