Merge "Clean up: remove unused SuggestionFeature api."
diff --git a/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProvider.java b/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProvider.java
index 92744ae..0011177 100644
--- a/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProvider.java
+++ b/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProvider.java
@@ -23,11 +23,8 @@
import androidx.annotation.NonNull;
-import com.android.settingslib.drawer.Tile;
import com.android.settingslib.suggestions.SuggestionControllerMixinCompat;
-import java.util.List;
-
/** Interface should be implemented if you have added new suggestions */
public interface SuggestionFeatureProvider {
@@ -50,11 +47,6 @@
SharedPreferences getSharedPrefs(Context context);
/**
- * Only keep top few suggestions from exclusive suggestions.
- */
- void filterExclusiveSuggestions(List<Tile> suggestions);
-
- /**
* Dismisses a suggestion.
*/
void dismissSuggestion(Context context, SuggestionControllerMixinCompat suggestionMixin,
diff --git a/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java b/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
index 4dd0a5c..39d0299 100644
--- a/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
+++ b/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
@@ -45,7 +45,6 @@
public class SuggestionFeatureProviderImpl implements SuggestionFeatureProvider {
private static final String TAG = "SuggestionFeature";
- private static final int EXCLUSIVE_SUGGESTION_MAX_COUNT = 3;
private static final String SHARED_PREF_FILENAME = "suggestions";
@@ -98,17 +97,6 @@
}
@Override
- public void filterExclusiveSuggestions(List<Tile> suggestions) {
- if (suggestions == null) {
- return;
- }
- for (int i = suggestions.size() - 1; i >= EXCLUSIVE_SUGGESTION_MAX_COUNT; i--) {
- Log.d(TAG, "Removing exclusive suggestion");
- suggestions.remove(i);
- }
- }
-
- @Override
public void dismissSuggestion(Context context, SuggestionControllerMixinCompat mixin,
Suggestion suggestion) {
if (mixin == null || suggestion == null || context == null) {
diff --git a/tests/robotests/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImplTest.java b/tests/robotests/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImplTest.java
index 5fdf458..f9a7379 100644
--- a/tests/robotests/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImplTest.java
+++ b/tests/robotests/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImplTest.java
@@ -143,20 +143,4 @@
anyString());
verify(mSuggestionControllerMixin).dismissSuggestion(mSuggestion);
}
-
- @Test
- public void filterExclusiveSuggestions_shouldOnlyKeepFirst3() {
- final List<Tile> suggestions = new ArrayList<>();
- suggestions.add(new Tile(mActivityInfo, CategoryKey.CATEGORY_APPS));
- suggestions.add(new Tile(mActivityInfo, CategoryKey.CATEGORY_APPS));
- suggestions.add(new Tile(mActivityInfo, CategoryKey.CATEGORY_APPS));
- suggestions.add(new Tile(mActivityInfo, CategoryKey.CATEGORY_APPS));
- suggestions.add(new Tile(mActivityInfo, CategoryKey.CATEGORY_APPS));
- suggestions.add(new Tile(mActivityInfo, CategoryKey.CATEGORY_APPS));
- suggestions.add(new Tile(mActivityInfo, CategoryKey.CATEGORY_APPS));
-
- mProvider.filterExclusiveSuggestions(suggestions);
-
- assertThat(suggestions).hasSize(3);
- }
}