commit 1e607904c320893fd3bc9b77a7f12f46a4204cbe
author Mill Chen <millchen@google.com> Thu Feb 25 15:03:25 2021 +0800
committer Mill Chen <millchen@google.com> Thu Feb 25 16:32:50 2021 +0800
tree 3495b008a5aaf0681a34fe1eba6e780ba0815929
parent 8767313e05e8a449a9de5c7f858f2dfcdfb6b4ba

Update UI for factory reset flow

After applying a collapsing toolbar in the Settings app, the factory
reset screen is not displayed correctly. This is because
1) the factory reset page should not essentially have a toolbar since it
has different UI layout form other pages.
2) this page was launched previously as a SubSettings so it applied a
wrong theme.

This change is mainly updating the inheritence structure and specifying
the right theme for the factory reset page in order to have a correct
layout.

Bug: 179457252
Test: robotests and visual verified
Change-Id: I91aec65a120d5a288507d89ace7c9298acdca42b

src/com/android/settings/MainClear.java

diff --git a/src/com/android/settings/MainClear.java b/src/com/android/settings/MainClear.java
index 326aeef..a7aa8ea 100644
--- a/src/com/android/settings/MainClear.java
+++ b/src/com/android/settings/MainClear.java
@@ -59,11 +59,11 @@
 import androidx.annotation.VisibleForTesting;
 
 import com.android.settings.core.InstrumentedFragment;
-import com.android.settings.core.SubSettingLauncher;
 import com.android.settings.enterprise.ActionDisabledByAdminDialogHelper;
 import com.android.settings.password.ChooseLockSettingsHelper;
 import com.android.settings.password.ConfirmLockPattern;
 import com.android.settingslib.RestrictedLockUtilsInternal;
+import com.android.settingslib.core.instrumentation.MetricsFeatureProvider;
 import com.android.settingslib.development.DevelopmentSettingsEnabler;
 
 import com.google.android.setupcompat.template.FooterBarMixin;
@@ -187,12 +187,15 @@
         final Bundle args = new Bundle();
         args.putBoolean(ERASE_EXTERNAL_EXTRA, mExternalStorage.isChecked());
         args.putBoolean(ERASE_ESIMS_EXTRA, mEsimStorage.isChecked());
-        new SubSettingLauncher(getContext())
-                .setDestination(MainClearConfirm.class.getName())
-                .setArguments(args)
-                .setTitleRes(R.string.main_clear_confirm_title)
-                .setSourceMetricsCategory(getMetricsCategory())
-                .launch();
+        final Intent intent = new Intent();
+        intent.setClass(getContext(),
+                com.android.settings.Settings.FactoryResetConfirmActivity.class);
+        intent.putExtra(SettingsActivity.EXTRA_SHOW_FRAGMENT, MainClearConfirm.class.getName());
+        intent.putExtra(SettingsActivity.EXTRA_SHOW_FRAGMENT_ARGUMENTS, args);
+        intent.putExtra(SettingsActivity.EXTRA_SHOW_FRAGMENT_TITLE_RESID,
+                R.string.main_clear_confirm_title);
+        intent.putExtra(MetricsFeatureProvider.EXTRA_SOURCE_METRICS_CATEGORY, getMetricsCategory());
+        getContext().startActivity(intent);
     }
 
     @VisibleForTesting