commit 1bcba3d23f7a1a9e24d19f12e417c986b6f2a267
author SongFerngWang <songferngwang@google.com> Wed Jul 28 21:28:18 2021 +0800
committer SongFerng Wang <songferngwang@google.com> Wed Jul 28 14:15:31 2021 +0000
tree 436db7816a55a486bc877307cddd67b5d8c771f4
parent 1a6982f195029662afd89ebd44c8dc6c03ef1112

Fix the wrong comparison

Bug: 173387374
Test: atest NetworkSelectSettingsTest (PASS)
test on real device (PASS)

Change-Id: Ib1135b0457b4e35db67e671cad142657457d6d75

src/com/android/settings/network/telephony/NetworkSelectSettings.java

diff --git a/src/com/android/settings/network/telephony/NetworkSelectSettings.java b/src/com/android/settings/network/telephony/NetworkSelectSettings.java
index 62eb690..813cc74 100644
--- a/src/com/android/settings/network/telephony/NetworkSelectSettings.java
+++ b/src/com/android/settings/network/telephony/NetworkSelectSettings.java
@@ -327,10 +327,10 @@
             Class className = cellInfo.getClass();
 
             if (aggregatedList.stream().anyMatch(
-                    i -> {
-                        return (CellInfoUtil.getNetworkTitle(i.getCellIdentity(),
-                                CellInfoUtil.getCellIdentityMccMnc(i.getCellIdentity())) == plmn)
-                                && i.getClass().equals(className);
+                    item -> {
+                        String itemPlmn = CellInfoUtil.getNetworkTitle(item.getCellIdentity(),
+                                CellInfoUtil.getCellIdentityMccMnc(item.getCellIdentity()));
+                        return itemPlmn.equals(plmn) && item.getClass().equals(className);
                     })) {
                 continue;
             }

tests/unit/src/com/android/settings/network/telephony/NetworkSelectSettingsTest.java

diff --git a/tests/unit/src/com/android/settings/network/telephony/NetworkSelectSettingsTest.java b/tests/unit/src/com/android/settings/network/telephony/NetworkSelectSettingsTest.java
index 769cbca..47e3ad9 100644
--- a/tests/unit/src/com/android/settings/network/telephony/NetworkSelectSettingsTest.java
+++ b/tests/unit/src/com/android/settings/network/telephony/NetworkSelectSettingsTest.java
@@ -169,8 +169,8 @@
     private CellInfoLte createLteCellInfo(boolean registered, int cellId, String mcc, String mnc,
             String plmnName) {
         CellIdentityLte cil = new CellIdentityLte(
-                cellId, 5, 200, 2000, new int[]{1, 2}, 10000, mcc,
-                mnc, plmnName, plmnName,
+                cellId, 5, 200, 2000, new int[]{1, 2}, 10000, new String(mcc),
+                new String(mnc), new String(plmnName), new String(plmnName),
                 Collections.emptyList(), null);
         CellSignalStrengthLte cssl = new CellSignalStrengthLte(15, 16, 17, 18, 19, 20);
 
@@ -184,8 +184,8 @@
 
     private CellInfoGsm createGsmCellInfo(boolean registered, int cellId, String mcc, String mnc,
             String plmnName) {
-        CellIdentityGsm cig = new CellIdentityGsm(1, cellId, 40, 5, mcc,
-                mnc, plmnName, plmnName,
+        CellIdentityGsm cig = new CellIdentityGsm(1, cellId, 40, 5, new String(mcc),
+                new String(mnc), new String(plmnName), new String(plmnName),
                 Collections.emptyList());
         CellSignalStrengthGsm cssg = new CellSignalStrengthGsm(5, 6, 7);
         CellInfoGsm cellInfoGsm = new CellInfoGsm();