| commit | 12954d5060349965b188591b61b34d69481d3c1b | [log] [tgz] |
|---|---|---|
| author | Philip P. Moltmann <moltmann@google.com> | Tue Mar 24 15:55:57 2020 -0700 |
| committer | Philip P. Moltmann <moltmann@google.com> | Tue Mar 24 15:55:57 2020 -0700 |
| tree | dbe097f1e23d92fe3285767cbbe8fa37bc69d0f9 | |
| parent | 87c0179c01bb6ebff25283cbcc886532d2c7c5df [diff] |
Only check op in Settings UI noteOp should only used if the data protected by the app-op was accessed. If you only want to know the state, use checkOp. Test: TH Bug: 136595429 Change-Id: I2b53ad413c10a71feb9c94848aef2f9f38f851d8
diff --git a/src/com/android/settings/applications/appinfo/WriteSettingsDetails.java b/src/com/android/settings/applications/appinfo/WriteSettingsDetails.java index f8c7ac5..26adb44 100644 --- a/src/com/android/settings/applications/appinfo/WriteSettingsDetails.java +++ b/src/com/android/settings/applications/appinfo/WriteSettingsDetails.java
@@ -108,7 +108,7 @@ } private boolean canWriteSettings(String pkgName) { - int result = mAppOpsManager.noteOpNoThrow(AppOpsManager.OP_WRITE_SETTINGS, + int result = mAppOpsManager.checkOpNoThrow(AppOpsManager.OP_WRITE_SETTINGS, mPackageInfo.applicationInfo.uid, pkgName); if (result == AppOpsManager.MODE_ALLOWED) { return true;