commit 0cff0e4a5169d3a41fdd324cfa2385df2ff3d33e
author Fabrice Di Meglio <fdimeglio@google.com> Tue Feb 04 23:59:10 2014 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Tue Feb 04 23:59:11 2014 +0000
tree cb625e352215744a09da381456f597ed46dbf6a1
parent 90e9e6cd30920174d43f09b48ab59a9d7c9be722
parent 74abdfd3e69a8633149617097f6acca7a0f833da

Merge "Fix bug #12893337 Crash while set up SIM card lock"

res/xml/security_settings_misc.xml

diff --git a/res/xml/security_settings_misc.xml b/res/xml/security_settings_misc.xml
index dbbeb1d..faab1ea 100644
--- a/res/xml/security_settings_misc.xml
+++ b/res/xml/security_settings_misc.xml
@@ -21,10 +21,8 @@
             android:persistent="false">
 
         <Preference android:title="@string/sim_lock_settings_category"
-                android:persistent="false">
-            <intent android:action="android.intent.action.MAIN"
-                     android:targetPackage="com.android.settings"
-                     android:targetClass="com.android.settings.IccLockSettings"/>
+                android:persistent="false"
+                android:fragment="com.android.settings.IccLockSettings">
         </Preference>
     </PreferenceCategory>
 

src/com/android/settings/IccLockSettings.java

diff --git a/src/com/android/settings/IccLockSettings.java b/src/com/android/settings/IccLockSettings.java
index cb39020..4edaee4 100644
--- a/src/com/android/settings/IccLockSettings.java
+++ b/src/com/android/settings/IccLockSettings.java
@@ -127,11 +127,11 @@
     };
 
     // For top-level settings screen to query
-    static boolean isIccLockEnabled() {
-        return PhoneFactory.getDefaultPhone().getIccCard().getIccLockEnabled();
+    boolean isIccLockEnabled() {
+        return mPhone.getIccCard().getIccLockEnabled();
     }
 
-    static String getSummary(Context context) {
+    String getSummary(Context context) {
         Resources res = context.getResources();
         String summary = isIccLockEnabled()
                 ? res.getString(R.string.sim_lock_on)
@@ -181,7 +181,9 @@
         // Don't need any changes to be remembered
         getPreferenceScreen().setPersistent(false);
 
+        PhoneFactory.makeDefaultPhone(getActivity());
         mPhone = PhoneFactory.getDefaultPhone();
+
         mRes = getResources();
         updatePreferences();
     }