commit 0b8bf4ea866a9d1b9524a14c84c4260e30ee6d34
author László Dávid <laszlo.david@gmail.com> Wed Oct 24 23:31:47 2012 +0200
committer László Dávid <laszlo.david@gmail.com> Wed Oct 24 23:31:47 2012 +0200
tree 6772064aa68156d93887c725ea5cc17a8d79aad9
parent 78f5c4d5372e38b5a5d1e2f3e3b732951a76f007

Call to equals() comparing different types

I have found this bug with the FindBugs tool

Change-Id: I7f157063b0a549cb4344c048ddb612a14a915a25
Signed-off-by: László Dávid <laszlo.david@gmail.com>

src/com/android/settings/DataUsageSummary.java

diff --git a/src/com/android/settings/DataUsageSummary.java b/src/com/android/settings/DataUsageSummary.java
index 5e20a6e..edccf53 100644
--- a/src/com/android/settings/DataUsageSummary.java
+++ b/src/com/android/settings/DataUsageSummary.java
@@ -1171,8 +1171,8 @@
         final String rangePhrase = formatDateRange(context, start, end);
 
         final int summaryRes;
-        if (TAB_MOBILE.equals(mCurrentTab) || TAB_3G.equals(mCurrentApp)
-                || TAB_4G.equals(mCurrentApp)) {
+        if (TAB_MOBILE.equals(mCurrentTab) || TAB_3G.equals(mCurrentTab)
+                || TAB_4G.equals(mCurrentTab)) {
             summaryRes = R.string.data_usage_total_during_range_mobile;
         } else {
             summaryRes = R.string.data_usage_total_during_range;