commit 08190bbb75ca9f5affb9d7b6474a87bc41256900
author Fabrice Di Meglio <fdimeglio@google.com> Fri May 16 10:32:29 2014 -0700
committer Fabrice Di Meglio <fdimeglio@google.com> Fri May 16 10:32:29 2014 -0700
tree 5a64c3e74ac50bd9ef54931baf7205eb703844e2
parent 3f7e0571d3baaa9dd2ad887067fb8d86f597f71b

Fix bug #15016050 Stability: ISE in Settings: Cannot add twice the same OnSwitchChangeListener

- add/remove the OnSwitchChangeListener into onResume/onPause

Change-Id: Idb1ac3997a2dbc0ca387ed67bbbbcc1a431d8642

src/com/android/settings/DevelopmentSettings.java

diff --git a/src/com/android/settings/DevelopmentSettings.java b/src/com/android/settings/DevelopmentSettings.java
index d21e4ab..cc7a116 100644
--- a/src/com/android/settings/DevelopmentSettings.java
+++ b/src/com/android/settings/DevelopmentSettings.java
@@ -387,19 +387,6 @@
             mEnabledSwitch.setEnabled(false);
             return;
         }
-        mSwitchBar.addOnSwitchChangeListener(this);
-    }
-
-    @Override
-    public void onStart() {
-        super.onStart();
-        mSwitchBar.show();
-    }
-
-    @Override
-    public void onStop() {
-        super.onStop();
-        mSwitchBar.hide();
     }
 
     private boolean removePreferenceForProduction(Preference preference) {
@@ -464,6 +451,17 @@
             mEnabledSwitch.setChecked(mLastEnabledState);
             setPrefsEnabledState(mLastEnabledState);
         }
+
+        mSwitchBar.addOnSwitchChangeListener(this);
+        mSwitchBar.show();
+    }
+
+    @Override
+    public void onPause() {
+        super.onPause();
+
+        mSwitchBar.removeOnSwitchChangeListener(this);
+        mSwitchBar.hide();
     }
 
     void updateCheckBox(CheckBoxPreference checkBox, boolean value) {