commit 02c22131e93e1a506141b1890c7134909ded876f
author Amith Yamasani <yamasani@google.com> Thu Apr 26 16:27:43 2012 -0700
committer Amith Yamasani <yamasani@google.com> Thu Apr 26 16:27:43 2012 -0700
tree 08f13a3dd2c2427d1a4253b5ea90508023f8659d
parent bd4bac327b27ab42ba3bdc87d8655c9c21bfda5d

Make Manage Apps remember which tab was shown.

This fixes the forgetfulness on orientation change. The code was
already in, but there was a typo in the key string that saved the tab.

Bug: 6000318
Change-Id: If29f42b83aa0ec9f05061b8690e0bdbe8c4a2812

src/com/android/settings/applications/ManageApplications.java

diff --git a/src/com/android/settings/applications/ManageApplications.java b/src/com/android/settings/applications/ManageApplications.java
index 769dc04..fbaabf4 100644
--- a/src/com/android/settings/applications/ManageApplications.java
+++ b/src/com/android/settings/applications/ManageApplications.java
@@ -116,12 +116,18 @@
 public class ManageApplications extends Fragment implements
         OnItemClickListener,
         TabHost.TabContentFactory, TabHost.OnTabChangeListener {
+
     static final String TAG = "ManageApplications";
     static final boolean DEBUG = false;
-    
+
+    private static final String EXTRA_FILTER_APPS = "filterApps";
+    private static final String EXTRA_SORT_ORDER = "sortOrder";
+    private static final String EXTRA_SHOW_BACKGROUND = "showBackground";
+    private static final String EXTRA_DEFAULT_TAB_TAG = "defaultTabTag";
+
     // attributes used as keys when passing values to InstalledAppDetails activity
     public static final String APP_CHG = "chg";
-    
+
     // constant value that can be used to check return code from sub activity.
     private static final int INSTALLED_APP_DETAILS = 1;
 
@@ -525,11 +531,11 @@
         }
         
         if (savedInstanceState != null) {
-            mSortOrder = savedInstanceState.getInt("sortOrder", mSortOrder);
-            mFilterApps = savedInstanceState.getInt("filterApps", mFilterApps);
-            String tmp = savedInstanceState.getString("defaultTabTag");
+            mSortOrder = savedInstanceState.getInt(EXTRA_SORT_ORDER, mSortOrder);
+            mFilterApps = savedInstanceState.getInt(EXTRA_FILTER_APPS, mFilterApps);
+            String tmp = savedInstanceState.getString(EXTRA_DEFAULT_TAB_TAG);
             if (tmp != null) defaultTabTag = tmp;
-            mShowBackground = savedInstanceState.getBoolean("showBackground", false);
+            mShowBackground = savedInstanceState.getBoolean(EXTRA_SHOW_BACKGROUND, false);
         }
         
         mDefaultTab = defaultTabTag;
@@ -621,12 +627,12 @@
     @Override
     public void onSaveInstanceState(Bundle outState) {
         super.onSaveInstanceState(outState);
-        outState.putInt("sortOrder", mSortOrder);
-        outState.putInt("filterApps", mFilterApps);
+        outState.putInt(EXTRA_SORT_ORDER, mSortOrder);
+        outState.putInt(EXTRA_FILTER_APPS, mFilterApps);
         if (mDefaultTab != null) {
-            outState.putString("defautTabTag", mDefaultTab);
+            outState.putString(EXTRA_DEFAULT_TAB_TAG, mDefaultTab);
         }
-        outState.putBoolean("showBackground", mShowBackground);
+        outState.putBoolean(EXTRA_SHOW_BACKGROUND, mShowBackground);
     }
 
     @Override