commit 3444245b0dce738ebbde7da9aedcb1bb581d272b
author Luofan Chen <clfbbn@gmail.com> Tue Jul 11 01:43:37 2023 +0800
committer micky387 <mickaelsaibi@free.fr> Wed Jan 15 15:48:35 2025 -0500
tree b642cba4902498d58a49961ce53015688bc38d28
parent 5b5326c26b3d196ecc3547e78f5f98c068451e64

ChargingControl: Drop default values for initially zero variables

Java generally sets the default values for fields to zero or null.

Change-Id: I7a993dfc70476ed5beb649cae42de2b125b897b9

src/org/omnirom/omnilib/internal/health/ChargingControlController.java

diff --git a/src/org/omnirom/omnilib/internal/health/ChargingControlController.java b/src/org/omnirom/omnilib/internal/health/ChargingControlController.java
index ec7558d..83f1d5a 100644
--- a/src/org/omnirom/omnilib/internal/health/ChargingControlController.java
+++ b/src/org/omnirom/omnilib/internal/health/ChargingControlController.java
@@ -65,22 +65,22 @@
 public class ChargingControlController extends OmniRomHealthFeature {
     private final IChargingControl mChargingControl;
     private final ContentResolver mContentResolver;
-    private ChargingControlNotification mChargingNotification = null;
+    private ChargingControlNotification mChargingNotification;
     private OmniRomHealthBatteryBroadcastReceiver mBattReceiver;
 
     // Defaults
     private boolean mDefaultEnabled = false;
-    private int mDefaultMode = 0;
-    private int mDefaultLimit = 0;
-    private int mDefaultStartTime = 0;
-    private int mDefaultTargetTime = 0;
+    private int mDefaultMode;
+    private int mDefaultLimit;
+    private int mDefaultStartTime;
+    private int mDefaultTargetTime;
 
     // User configs
-    private boolean mConfigEnabled = false;
+    private boolean mConfigEnabled;
+    private int mConfigStartTime;
+    private int mConfigTargetTime;
     private int mConfigMode = MODE_NONE;
     private int mConfigLimit = 100;
-    private int mConfigStartTime = 0;
-    private int mConfigTargetTime = 0;
 
     // Settings uris
     private final Uri MODE_URI = Settings.System.getUriFor(
@@ -95,18 +95,18 @@
             OmniSettings.OMNI_CHARGING_CONTROL_TARGET_TIME);
 
     // Internal state
-    private float mBatteryPct = 0;
-    private boolean mIsPowerConnected = false;
-    private int mChargingStopReason = 0;
-    private long mEstimatedFullTime = 0;
-    private long mSavedAlarmTime = 0;
-    private long mSavedTargetTime = 0;
-    private boolean mIsControlCancelledOnce = false;
-    private boolean mIsChargingToggleSupported = false;
-    private boolean mIsChargingBypassSupported = false;
-    private boolean mIsChargingDeadlineSupported = false;
-    private int mChargingTimeMargin = 0;
-    private int mChargingLimitMargin = 0;
+    private float mBatteryPct;
+    private long mEstimatedFullTime;
+    private long mSavedAlarmTime;
+    private long mSavedTargetTime;
+    private boolean mIsPowerConnected;
+    private boolean mIsControlCancelledOnce;
+    private boolean mIsChargingToggleSupported;
+    private boolean mIsChargingBypassSupported;
+    private boolean mIsChargingDeadlineSupported;
+    private int mChargingStopReason;
+    private int mChargingTimeMargin;
+    private int mChargingLimitMargin;
 
     private static final DateTimeFormatter mFormatter = DateTimeFormatter.ofLocalizedTime(SHORT);
     private static final SimpleDateFormat mDateFormatter = new SimpleDateFormat("hh:mm:ss a");