commit da8b67be0cc0629ab5777cf8aaed393d9f8e2e6c
author Taesu Lee <taesu82.lee@samsung.com> Wed Feb 08 14:43:18 2017 +0900
committer Taesu Lee <taesu82.lee@samsung.com> Tue Jun 25 12:31:39 2019 +0900
tree 456957f43ab161a034e62fc5a13e5939d2322b15
parent 5500d335554440ef16bdf9b7151157a9eb42da28

Replace no error code '0' for SMS with '-1'

Use '-1' for no error instead of '0' since the '0' has been one of the
valid error codes in 3GPP2.

Test: Manual

Change-Id: I02ba391a5cd178491868565c10bb3a35ba88e19a
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>

src/com/android/messaging/receiver/SendStatusReceiver.java

diff --git a/src/com/android/messaging/receiver/SendStatusReceiver.java b/src/com/android/messaging/receiver/SendStatusReceiver.java
index 3af65f2..c1b2bca 100644
--- a/src/com/android/messaging/receiver/SendStatusReceiver.java
+++ b/src/com/android/messaging/receiver/SendStatusReceiver.java
@@ -52,7 +52,7 @@
     public static final String EXTRA_PART_ID = "partId";
     public static final String EXTRA_SUB_ID = "subId";
 
-    public static final int NO_ERROR_CODE = 0;
+    public static final int NO_ERROR_CODE = -1;
     public static final int NO_PART_ID = -1;
 
     @Override

src/com/android/messaging/receiver/SmsReceiver.java

diff --git a/src/com/android/messaging/receiver/SmsReceiver.java b/src/com/android/messaging/receiver/SmsReceiver.java
index b54359f..f1f9bcd 100644
--- a/src/com/android/messaging/receiver/SmsReceiver.java
+++ b/src/com/android/messaging/receiver/SmsReceiver.java
@@ -186,7 +186,8 @@
             return;
         }
 
-        final int errorCode = intent.getIntExtra(EXTRA_ERROR_CODE, 0);
+        final int errorCode =
+                intent.getIntExtra(EXTRA_ERROR_CODE, SendStatusReceiver.NO_ERROR_CODE);
         // Always convert negative subIds into -1
         int subId = PhoneUtils.getDefault().getEffectiveIncomingSubIdFromSystem(
                 intent, EXTRA_SUB_ID);