commit f46e3956ddba136c44df97aa1997aa67b0387018
author Hyunyoung Song <hyunyoungs@google.com> Fri Jun 14 22:08:48 2019 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Fri Jun 14 22:08:48 2019 +0000
tree d369995239fb40915c8d9d39fd7195f6b00d60df
parent ce04131f1ad1d9510cb09f91d5093b9220e36995
parent 2a70b3d6aa5fb1e046424d917f214f576a33fa38

Merge "Fix HOME/RECENTS/BACK duplicated, missing logging" into ub-launcher3-qt-dev

src/com/android/launcher3/Launcher.java

diff --git a/src/com/android/launcher3/Launcher.java b/src/com/android/launcher3/Launcher.java
index 4e905c7..80ea78f 100644
--- a/src/com/android/launcher3/Launcher.java
+++ b/src/com/android/launcher3/Launcher.java
@@ -1353,19 +1353,6 @@
 
         if (isActionMain) {
             if (!internalStateHandled) {
-                // Note: There should be at most one log per method call. This is enforced
-                // implicitly by using if-else statements.
-                UserEventDispatcher ued = getUserEventDispatcher();
-                AbstractFloatingView topOpenView = AbstractFloatingView.getTopOpenView(this);
-                if (topOpenView != null) {
-                    topOpenView.logActionCommand(Action.Command.HOME_INTENT);
-                } else if (alreadyOnHome) {
-                    Target target = newContainerTarget(mStateManager.getState().containerType);
-                    target.pageIndex = mWorkspace.getCurrentPage();
-                    ued.logActionCommand(Action.Command.HOME_INTENT, target,
-                            newContainerTarget(ContainerType.WORKSPACE));
-                }
-
                 // In all these cases, only animate if we're already on home
                 AbstractFloatingView.closeAllOpenViews(this, isStarted());
 
@@ -1385,6 +1372,13 @@
                 }
             }
 
+            // Handle HOME_INTENT
+            UserEventDispatcher ued = getUserEventDispatcher();
+            Target target = newContainerTarget(mStateManager.getState().containerType);
+            target.pageIndex = mWorkspace.getCurrentPage();
+            ued.logActionCommand(Action.Command.HOME_INTENT, target,
+                    newContainerTarget(ContainerType.WORKSPACE));
+
             final View v = getWindow().peekDecorView();
             if (v != null && v.getWindowToken() != null) {
                 UiThreadHelper.hideKeyboardAsync(this, v.getWindowToken());

src/com/android/launcher3/LauncherState.java

diff --git a/src/com/android/launcher3/LauncherState.java b/src/com/android/launcher3/LauncherState.java
index c63f976..1480648 100644
--- a/src/com/android/launcher3/LauncherState.java
+++ b/src/com/android/launcher3/LauncherState.java
@@ -268,8 +268,6 @@
         if (this != NORMAL) {
             LauncherStateManager lsm = launcher.getStateManager();
             LauncherState lastState = lsm.getLastState();
-            launcher.getUserEventDispatcher().logActionCommand(Action.Command.BACK,
-                    containerType, lastState.containerType);
             lsm.goToState(lastState);
         }
     }