Fixing bug with workspace drop animation
Change-Id: I4f7682e588730905170fd534a415688ebbf64eea
diff --git a/src/com/android/launcher2/CellLayout.java b/src/com/android/launcher2/CellLayout.java
index 2359e32..1173e52 100644
--- a/src/com/android/launcher2/CellLayout.java
+++ b/src/com/android/launcher2/CellLayout.java
@@ -963,14 +963,10 @@
if (lp.animateDrop) {
lp.animateDrop = false;
- // This call needs to be posted since it results in a requestLayout()
- // which shouldn't be called from within a layout pass (can cause a bad
- // state of the tree).
- post(new Runnable() {
- public void run() {
- ((Workspace) mParent).animateViewIntoPosition(child);
- }
- });
+ // This call does not result in a requestLayout(), but at one point did.
+ // We need to be cautious about any method calls within the layout pass
+ // to insure we don't leave the view tree in a bad state.
+ ((Workspace) mParent).animateViewIntoPosition(child);
}
}
}
@@ -1392,7 +1388,7 @@
lp.isDragging = false;
lp.dropped = true;
lp.animateDrop = animate;
- child.setVisibility(View.VISIBLE);
+ child.setVisibility(View.INVISIBLE);
child.requestLayout();
}
}