Fix work tab accessbility issues.
The issue is that the accessibility scanner says tap target is 46dp rather than 48dp because of the 1dp padding that is added
to the viewgroup. Rather, we should delegate that 1dp to the insets of the drawable instead.
bug: 379222957
Test manually, photos:
beforeAccessibilityscanner: https://drive.google.com/file/d/1-XssMfXstpKQk5Ve7l5UCPFORtCkYluH/view?usp=sharing
before:https://drive.google.com/file/d/1rip4gIKpoOw-cCNroEjrpcJ9TMSthHhB/view?usp=sharing
after: https://drive.google.com/file/d/1dOh4yxEAPBG_pGn92yUGizTCLTTW1w2K/view?usp=sharing
Flag: NONE bug fix changing dp
Change-Id: I5ac69e5d92bbbbc3617e30801316eb04d65ace7a
diff --git a/res/drawable/all_apps_tabs_background_selected.xml b/res/drawable/all_apps_tabs_background_selected.xml
index 47f95dd..6560632 100644
--- a/res/drawable/all_apps_tabs_background_selected.xml
+++ b/res/drawable/all_apps_tabs_background_selected.xml
@@ -15,10 +15,10 @@
-->
<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
<item
- android:bottom="@dimen/all_apps_tabs_focus_width"
- android:end="@dimen/all_apps_tabs_focus_width"
- android:start="@dimen/all_apps_tabs_focus_width"
- android:top="@dimen/all_apps_tabs_focus_width">
+ android:bottom="@dimen/all_apps_tabs_focus_vertical_inset"
+ android:end="@dimen/all_apps_tabs_focus_horizontal_inset"
+ android:start="@dimen/all_apps_tabs_focus_horizontal_inset"
+ android:top="@dimen/all_apps_tabs_focus_vertical_inset">
<shape android:shape="rectangle">
<corners android:radius="@dimen/all_apps_header_pill_corner_radius" />
<solid android:color="?attr/materialColorPrimary" />
diff --git a/res/drawable/all_apps_tabs_background_unselected.xml b/res/drawable/all_apps_tabs_background_unselected.xml
index ab592a8..ce7b334 100644
--- a/res/drawable/all_apps_tabs_background_unselected.xml
+++ b/res/drawable/all_apps_tabs_background_unselected.xml
@@ -15,10 +15,10 @@
-->
<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
<item
- android:bottom="@dimen/all_apps_tabs_focus_width"
- android:end="@dimen/all_apps_tabs_focus_width"
- android:start="@dimen/all_apps_tabs_focus_width"
- android:top="@dimen/all_apps_tabs_focus_width">
+ android:bottom="@dimen/all_apps_tabs_focus_vertical_inset"
+ android:end="@dimen/all_apps_tabs_focus_horizontal_inset"
+ android:start="@dimen/all_apps_tabs_focus_horizontal_inset"
+ android:top="@dimen/all_apps_tabs_focus_vertical_inset">
<shape android:shape="rectangle">
<corners android:radius="@dimen/all_apps_header_pill_corner_radius" />
<solid android:color="?attr/materialColorSurfaceBright" />
diff --git a/res/layout/all_apps_personal_work_tabs.xml b/res/layout/all_apps_personal_work_tabs.xml
index ecc5a14..b6a8ed8 100644
--- a/res/layout/all_apps_personal_work_tabs.xml
+++ b/res/layout/all_apps_personal_work_tabs.xml
@@ -21,8 +21,6 @@
android:layout_width="match_parent"
android:layout_height="@dimen/all_apps_header_pill_height"
android:layout_gravity="center_horizontal"
- android:paddingTop="@dimen/all_apps_tabs_vertical_padding_focus"
- android:paddingBottom="@dimen/all_apps_tabs_vertical_padding_focus"
android:layout_marginTop="@dimen/all_apps_tabs_margin_top"
android:orientation="horizontal"
style="@style/TextHeadline"
diff --git a/res/values/dimens.xml b/res/values/dimens.xml
index c69778a..c31b4ee 100644
--- a/res/values/dimens.xml
+++ b/res/values/dimens.xml
@@ -125,9 +125,8 @@
<dimen name="all_apps_work_profile_tab_footer_top_padding">16dp</dimen>
<dimen name="all_apps_work_profile_tab_footer_bottom_padding">20dp</dimen>
<dimen name="all_apps_tabs_button_horizontal_padding">4dp</dimen>
- <dimen name="all_apps_tabs_vertical_padding">6dp</dimen>
- <dimen name="all_apps_tabs_vertical_padding_focus">1dp</dimen>
- <dimen name="all_apps_tabs_focus_width">5dp</dimen>
+ <dimen name="all_apps_tabs_focus_horizontal_inset">5dp</dimen>
+ <dimen name="all_apps_tabs_focus_vertical_inset">6dp</dimen>
<dimen name="all_apps_tabs_focus_border">3dp</dimen>
<dimen name="all_apps_tabs_focus_padding">2dp</dimen>
<dimen name="all_apps_tabs_margin_top">8dp</dimen>