commit d073ab0b3922eb0320a6bc2141cd4a57593a0cac
author Charlie Anderson <charlander@google.com> Wed May 08 16:45:11 2024 -0400
committer Charlie Anderson <charlander@google.com> Mon May 13 13:55:15 2024 -0400
tree f99b56b85330b7560d683266e2e40ce292247480
parent 42af1f072547b729eae73a694b6f6a834bdc3a46

Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon.

Bug: 326607598
Test: manually tested B&R
Flag: N/A
Change-Id: I8aac643ec5ca3162cd62bf1051cc751800c626dd

src/com/android/launcher3/icons/IconCache.java

diff --git a/src/com/android/launcher3/icons/IconCache.java b/src/com/android/launcher3/icons/IconCache.java
index 329f717..04d8ac0 100644
--- a/src/com/android/launcher3/icons/IconCache.java
+++ b/src/com/android/launcher3/icons/IconCache.java
@@ -373,8 +373,13 @@
                     infoInOut.user, activityInfoProvider, mLauncherActivityInfoCachingLogic,
                     usePkgIcon, useLowResIcon);
             applyPackageEntry(packageEntry, infoInOut, entry);
-        } else {
+        } else if (useLowResIcon || !entry.bitmap.isNullOrLowRes()
+                || infoInOut.bitmap.isNullOrLowRes()) {
+            // Only use cache entry if it will not downgrade the current bitmap in infoInOut
             applyCacheEntry(entry, infoInOut);
+        } else {
+            Log.d(TAG, "getTitleAndIcon: Cache entry bitmap was a downgrade of existing bitmap"
+                    + " in ItemInfo. Skipping.");
         }
     }