| commit | ae0e957eea75d24bc1c9447105601296688c73e0 | [log] [tgz] |
|---|---|---|
| author | Brandon Dayauon <brdayauon@google.com> | Mon May 20 15:11:42 2024 -0700 |
| committer | Brandon Dayauon <brdayauon@google.com> | Mon May 20 16:24:14 2024 -0700 |
| tree | f25adecc3f94584949b131f04e9a72249ad229c9 | |
| parent | 726f3b448033fe84792c161467e96141a4abb727 [diff] |
Update private space divider thickness and padding per spec. Thickness (height) is 2dp. Padding above and below the divider is 32dp. bug: 340307977 test manually: before: https://drive.google.com/file/d/1H364XUILz3gTLOENQL5zQBOELcza7YBk/view?usp=sharing after: https://drive.google.com/file/d/1HCsnj2s9TwlzIjKL1aHbBqO15nkPoOLj/view?usp=sharing after vertical padding: https://drive.google.com/file/d/1HS1SFVj9RfvuxHPGyk0PH5dGQum3spqe/view?usp=sharing Flag: None Change-Id: I64e9a228e9095449c4ef5f7680d92d234ab96f9f
diff --git a/res/drawable/private_space_app_divider.xml b/res/drawable/private_space_app_divider.xml index 7d069ef..1ea12b3 100644 --- a/res/drawable/private_space_app_divider.xml +++ b/res/drawable/private_space_app_divider.xml
@@ -17,5 +17,5 @@ <shape xmlns:android="http://schemas.android.com/apk/res/android" android:shape="rectangle"> <solid android:color="?attr/materialColorOutlineVariant"/> - <size android:height="1dp" /> + <size android:height="@dimen/all_apps_divider_height" /> </shape> \ No newline at end of file
diff --git a/res/layout/private_space_divider.xml b/res/layout/private_space_divider.xml index fff8629..f72e139 100644 --- a/res/layout/private_space_divider.xml +++ b/res/layout/private_space_divider.xml
@@ -18,8 +18,8 @@ android:importantForAccessibility="no" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingLeft="@dimen/ps_app_divider_padding" - android:paddingRight="@dimen/ps_app_divider_padding" + android:paddingHorizontal="@dimen/ps_app_divider_horizontal_padding" + android:paddingVertical="@dimen/ps_app_divider_vertical_padding" android:src="@drawable/private_space_app_divider" android:scaleType="fitXY" android:focusable="false" /> \ No newline at end of file
diff --git a/res/values/dimens.xml b/res/values/dimens.xml index b4f8a47..e31a35f 100644 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml
@@ -526,7 +526,8 @@ <dimen name="ps_button_height">40dp</dimen> <dimen name="ps_button_width">40dp</dimen> <dimen name="ps_lock_button_width">89dp</dimen> - <dimen name="ps_app_divider_padding">16dp</dimen> + <dimen name="ps_app_divider_horizontal_padding">16dp</dimen> + <dimen name="ps_app_divider_vertical_padding">32dp</dimen> <dimen name="ps_extra_bottom_padding">16dp</dimen> <dimen name="ps_lock_corner_radius">20dp</dimen> <dimen name="ps_lock_icon_size">20dp</dimen>