commit 3ce144b41b872be9fac8446b3b1cb4245c1e6842
author Tony <twickham@google.com> Wed Mar 01 16:51:15 2017 -0800
committer Tony <twickham@google.com> Wed Mar 01 17:14:28 2017 -0800
tree 7349e38090292574f4417dbcd8ea135060b3de52
parent cf18c3c2d14b54896e51fec829ae2d89642a59eb

Add null check when populating popup

It was crashing when there were notifications
but no shortcuts.

Change-Id: I92e961e6186ef24736777855e114bd3245f7ac91

src/com/android/launcher3/popup/PopupContainerWithArrow.java

diff --git a/src/com/android/launcher3/popup/PopupContainerWithArrow.java b/src/com/android/launcher3/popup/PopupContainerWithArrow.java
index 15dde43..0b0f88a 100644
--- a/src/com/android/launcher3/popup/PopupContainerWithArrow.java
+++ b/src/com/android/launcher3/popup/PopupContainerWithArrow.java
@@ -70,6 +70,8 @@
 import com.android.launcher3.shortcuts.ShortcutsItemView;
 import com.android.launcher3.util.PackageUserKey;
 
+import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 
@@ -182,14 +184,12 @@
             orientAboutIcon(originalIcon, arrowHeight + arrowVerticalOffset);
         }
 
-        List<DeepShortcutView> shortcutViews = mShortcutsItemView.getDeepShortcutViews(reverseOrder);
-        for (int i = 0; i < itemsToPopulate.length; i++) {
-            switch (itemsToPopulate[i]) {
-                case NOTIFICATION:
-                    IconPalette iconPalette = originalIcon.getIconPalette();
-                    mNotificationItemView.applyColors(iconPalette);
-                    break;
-            }
+        List<DeepShortcutView> shortcutViews = mShortcutsItemView == null
+                ? Collections.EMPTY_LIST
+                : mShortcutsItemView.getDeepShortcutViews(reverseOrder);
+        if (mNotificationItemView != null) {
+            IconPalette iconPalette = originalIcon.getIconPalette();
+            mNotificationItemView.applyColors(iconPalette);
         }
 
         // Add the arrow.