commit 327acfea13d924293b88c7d204fde4a25748108d
author Adam Cohen <adamcohen@google.com> Fri Jun 06 11:52:52 2014 -0700
committer Adam Cohen <adamcohen@google.com> Fri Jun 06 14:28:10 2014 -0700
tree f845540751bcb2d49b0f657d44e892c104d53258
parent 5fbdd06489f2d2e3ae166a5705269e05f7dcdfdb

Fix for regression which made issue 14491953 occur more easily

Change-Id: I27711aad8aae2824a54a043f686918d342ffc5bb

src/com/android/launcher3/Launcher.java

diff --git a/src/com/android/launcher3/Launcher.java b/src/com/android/launcher3/Launcher.java
index 0044d7a..9ebb997 100644
--- a/src/com/android/launcher3/Launcher.java
+++ b/src/com/android/launcher3/Launcher.java
@@ -2937,6 +2937,8 @@
                 } else {
                     return false;
                 }
+            } else {
+                return false;
             }
         }
 
@@ -2958,7 +2960,6 @@
                 // User long pressed on empty space
                 mWorkspace.performHapticFeedback(HapticFeedbackConstants.LONG_PRESS,
                         HapticFeedbackConstants.FLAG_IGNORE_VIEW_SETTING);
-                // Disabling reordering until we sort out some issues.
                 if (mWorkspace.isInOverviewMode()) {
                     mWorkspace.startReordering(v);
                 } else {

src/com/android/launcher3/PagedView.java

diff --git a/src/com/android/launcher3/PagedView.java b/src/com/android/launcher3/PagedView.java
index 8d5d8dd..9763126 100644
--- a/src/com/android/launcher3/PagedView.java
+++ b/src/com/android/launcher3/PagedView.java
@@ -2482,7 +2482,7 @@
     public boolean startReordering(View v) {
         int dragViewIndex = indexOfChild(v);
 
-        if (mTouchState != TOUCH_STATE_REST) return false;
+        if (mTouchState != TOUCH_STATE_REST || dragViewIndex == -1) return false;
 
         mTempVisiblePagesRange[0] = 0;
         mTempVisiblePagesRange[1] = getPageCount() - 1;