| commit | 2552cc78ede7bbb2bbefa2b105a2fb0565864949 | [log] [tgz] |
|---|---|---|
| author | Orhan Uysal <uysalorhan@google.com> | Thu May 16 09:04:01 2024 +0000 |
| committer | Orhan Uysal <uysalorhan@google.com> | Thu May 16 09:07:48 2024 +0000 |
| tree | 88e510c2e51a74ee601d7b3e699cddede636af9e | |
| parent | 8b0d1fb614630c3ec75a1f6e58e3251be00e3de0 [diff] |
Set the listeners to null on unregister In some occasions, launcher leaks through DesktopVisibilityController and SplitFromDesktopController. It seems that we don't set the listeners to null after we unregister which might be the reason why they hold on to the launcher activity. Bug: 332339792 Test: m Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode TEAMFOOD Change-Id: If52ae87cec959264109e59b1144679183c8fedcc
diff --git a/quickstep/src/com/android/launcher3/statehandlers/DesktopVisibilityController.java b/quickstep/src/com/android/launcher3/statehandlers/DesktopVisibilityController.java index 9eabb55..55d3456 100644 --- a/quickstep/src/com/android/launcher3/statehandlers/DesktopVisibilityController.java +++ b/quickstep/src/com/android/launcher3/statehandlers/DesktopVisibilityController.java
@@ -111,6 +111,7 @@ */ public void unregisterSystemUiListener() { SystemUiProxy.INSTANCE.get(mLauncher).setDesktopTaskListener(null); + mDesktopTaskListener = null; } /**
diff --git a/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java b/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java index df1879e..7e7c794 100644 --- a/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java +++ b/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java
@@ -983,6 +983,7 @@ void onDestroy() { SystemUiProxy.INSTANCE.get(mLauncher).unregisterSplitSelectListener( mSplitSelectListener); + mSplitSelectListener = null; } /**