commit 21d8230b9095c435f9baf1509993216da710c60c
author Vinit Nayak <peanutbutter@google.com> Thu Oct 20 16:58:11 2022 -0700
committer Vinit Nayak <peanutbutter@google.com> Thu Oct 27 22:03:00 2022 +0000
tree 79085355f0b48075aea757d7a88fa6d65ccb08cd
parent 0c1714bb4527619ade4fca7239945148c7f8913e

Prevent rotating TaskMenuViewWithArrow for large screen

* Only attempt to rotate TaskMenuView on
fake rotation

Fixes: 254198019
Test: Rotation on large screen w/ TaskMenu open doesn't
crash

Change-Id: If8ae8c018e9cc8cb80a2ec3313f5e8d0fda2e148

quickstep/src/com/android/quickstep/views/RecentsView.java

diff --git a/quickstep/src/com/android/quickstep/views/RecentsView.java b/quickstep/src/com/android/quickstep/views/RecentsView.java
index ce96b71..b28e048 100644
--- a/quickstep/src/com/android/quickstep/views/RecentsView.java
+++ b/quickstep/src/com/android/quickstep/views/RecentsView.java
@@ -122,6 +122,7 @@
 import androidx.annotation.UiThread;
 import androidx.core.graphics.ColorUtils;
 
+import com.android.launcher3.AbstractFloatingView;
 import com.android.launcher3.BaseActivity;
 import com.android.launcher3.BaseActivity.MultiWindowModeChangedListener;
 import com.android.launcher3.DeviceProfile;
@@ -2241,8 +2242,14 @@
         for (int i = 0; i < getTaskViewCount(); i++) {
             requireTaskViewAt(i).setOrientationState(mOrientationState);
         }
+        boolean shouldRotateMenuForFakeRotation =
+                !mOrientationState.isRecentsActivityRotationAllowed();
+        if (!shouldRotateMenuForFakeRotation) {
+            return;
+        }
         TaskMenuView tv = (TaskMenuView) getTopOpenViewWithType(mActivity, TYPE_TASK_MENU);
         if (tv != null) {
+            // Rotation is supported on phone (details at b/254198019#comment4)
             tv.onRotationChanged();
         }
     }