commit 14c73cc1200ff509ff12ad04157f31348f4c6736
author Sunny Goyal <sunnygoyal@google.com> Mon May 09 15:33:41 2016 -0700
committer Sunny Goyal <sunnygoyal@google.com> Mon May 09 15:33:52 2016 -0700
tree dd763c19de77ec35b5eb1939ccd807bbc87dff58
parent 34a2d31f3208c64f6ebf403f8a0cb6ea96461747

Using a separate thread for logging

Change-Id: I85a900bd70e01a7df2c2d8bd09c82cebdec2d3be

src/com/android/launcher3/logging/FileLog.java

diff --git a/src/com/android/launcher3/logging/FileLog.java b/src/com/android/launcher3/logging/FileLog.java
index f822695..68d9b8c 100644
--- a/src/com/android/launcher3/logging/FileLog.java
+++ b/src/com/android/launcher3/logging/FileLog.java
@@ -1,6 +1,7 @@
 package com.android.launcher3.logging;
 
 import android.os.Handler;
+import android.os.HandlerThread;
 import android.os.Message;
 import android.util.Log;
 import android.util.Pair;
@@ -23,6 +24,9 @@
 /**
  * Wrapper around {@link Log} to allow writing to a file.
  * This class can safely be called from main thread.
+ *
+ * Note: This should only be used for logging errors which have a persistent effect on user's data,
+ * but whose effect may not be visible immediately.
  */
 public final class FileLog {
 
@@ -77,8 +81,9 @@
     private static Handler getHandler() {
         synchronized (DATE_FORMAT) {
             if (sHandler == null) {
-                // We can use any non-ui looper, but why create another just for logging!
-                sHandler = new Handler(LauncherModel.getWorkerLooper(), new LogWriterCallback());
+                HandlerThread thread = new HandlerThread("file-logger");
+                thread.start();
+                sHandler = new Handler(thread.getLooper(), new LogWriterCallback());
             }
         }
         return sHandler;