commit e6060526c0976bafc1b2a1f70435a2a75b9491df
author wangqi <wangqi@google.com> Thu Apr 05 11:47:15 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Thu Apr 05 11:59:02 2018 -0700
tree 482d578f8c6b970bf22cbe725452f6aa3ebc5c23
parent f3a18d60d965e515086915604a74721ac8a888af

Fix leak of InCallActivity's DecorView and stuck on disconnection bug.

This is caused by not dismissing error dialog when recreating InCallActivity.
The dialog will be shown again after recreating.

Bug: 71376489,77152802
Test: manual
PiperOrigin-RevId: 191775030
Change-Id: I07ef5041979c0bbb2d44df9e41b55f0ac41e9339

java/com/android/incallui/InCallActivity.java

diff --git a/java/com/android/incallui/InCallActivity.java b/java/com/android/incallui/InCallActivity.java
index fadc406..0bc8e0a 100644
--- a/java/com/android/incallui/InCallActivity.java
+++ b/java/com/android/incallui/InCallActivity.java
@@ -563,9 +563,9 @@
     InCallPresenter.getInstance().onActivityStopped();
     if (!isRecreating) {
       InCallPresenter.getInstance().onUiShowing(false);
-      if (errorDialog != null) {
-        errorDialog.dismiss();
-      }
+    }
+    if (errorDialog != null) {
+      errorDialog.dismiss();
     }
 
     if (isFinishing()) {