commit ab0b8567b62b88082a3213a6b085302dc216cfeb
author wangqi <wangqi@google.com> Wed Sep 20 14:06:34 2017 -0700
committer Eric Erfanian <erfanian@google.com> Fri Sep 22 15:57:07 2017 +0000
tree 8605293914e2db39c31838cba02153f90dba5a10
parent f7d8f63913c8d1e83ee379cbf60077f02c978cad

Refactor CallList to call onUpdateCall and notifyGenericListeners directly.

Bug: 62426694
Test: none
PiperOrigin-RevId: 169447674
Change-Id: I3014b289c26d24ac571421bc54fcacc303278b41

java/com/android/incallui/call/CallList.java

diff --git a/java/com/android/incallui/call/CallList.java b/java/com/android/incallui/call/CallList.java
index c4b29d9..1f2c4c6 100644
--- a/java/com/android/incallui/call/CallList.java
+++ b/java/com/android/incallui/call/CallList.java
@@ -127,8 +127,7 @@
     manager.registerStateChangedListener(call);
 
     Trace.beginSection("checkSpam");
-    final DialerCallListenerImpl dialerCallListener = new DialerCallListenerImpl(call);
-    call.addListener(dialerCallListener);
+    call.addListener(new DialerCallListenerImpl(call));
     LogUtil.d("CallList.onCallAdded", "callState=" + call.getState());
     if (Spam.get(context).isSpamEnabled()) {
       String number = TelecomCallUtil.getNumber(telecomCall);
@@ -167,11 +166,12 @@
                             call.getTimeAddedMs());
                   }
                   call.setSpam(isSpam);
-                  dialerCallListener.onDialerCallUpdate();
+                  onUpdateCall(call);
+                  notifyGenericListeners();
                 }
               });
 
-      updateUserMarkedSpamStatus(call, context, number, dialerCallListener);
+      updateUserMarkedSpamStatus(call, context, number);
     }
     Trace.endSection();
 
@@ -185,7 +185,8 @@
           public void onCheckComplete(Integer id) {
             if (id != null && id != FilteredNumberAsyncQueryHandler.INVALID_ID) {
               call.setBlockedStatus(true);
-              dialerCallListener.onDialerCallUpdate();
+              onUpdateCall(call);
+              notifyGenericListeners();
             }
           }
         },
@@ -197,7 +198,8 @@
         || call.getState() == DialerCall.State.CALL_WAITING) {
       onIncoming(call);
     } else {
-      dialerCallListener.onDialerCallUpdate();
+      onUpdateCall(call);
+      notifyGenericListeners();
     }
 
     if (call.getState() != State.INCOMING) {
@@ -244,11 +246,8 @@
     return mCallByTelecomCall.get(telecomCall);
   }
 
-  public void updateUserMarkedSpamStatus(
-      final DialerCall call,
-      final Context context,
-      String number,
-      final DialerCallListenerImpl dialerCallListener) {
+  private void updateUserMarkedSpamStatus(
+      final DialerCall call, final Context context, String number) {
 
     Spam.get(context)
         .checkUserMarkedNonSpamStatus(