No longer close cursors manually after onLoadFinished is called.
Documentation clearly states that cursor loaders will close all cursors for
you. This CL removes all calls to cursor.close() after onLoaderFinished is
called.
Bug: 66902052
Test: n/a
PiperOrigin-RevId: 171087171
Change-Id: If771fbea52e03ffdd3652af2699c393cc7424de3
diff --git a/java/com/android/dialer/searchfragment/list/SearchCursorManager.java b/java/com/android/dialer/searchfragment/list/SearchCursorManager.java
index c6aca8e..364e97b 100644
--- a/java/com/android/dialer/searchfragment/list/SearchCursorManager.java
+++ b/java/com/android/dialer/searchfragment/list/SearchCursorManager.java
@@ -101,10 +101,6 @@
return false;
}
- if (contactsCursor != null && !contactsCursor.isClosed()) {
- contactsCursor.close();
- }
-
if (cursor != null) {
contactsCursor = cursor;
} else {
@@ -119,10 +115,6 @@
return false;
}
- if (nearbyPlacesCursor != null && !nearbyPlacesCursor.isClosed()) {
- nearbyPlacesCursor.close();
- }
-
if (cursor != null) {
nearbyPlacesCursor = cursor;
} else {
@@ -146,10 +138,6 @@
return false;
}
- if (corpDirectoryCursor != null && !corpDirectoryCursor.isClosed()) {
- corpDirectoryCursor.close();
- }
-
if (cursor != null) {
corpDirectoryCursor = cursor;
} else {
@@ -286,20 +274,9 @@
/** removes all cursors. */
void clear() {
- if (contactsCursor != null) {
- contactsCursor.close();
- contactsCursor = null;
- }
-
- if (nearbyPlacesCursor != null) {
- nearbyPlacesCursor.close();
- nearbyPlacesCursor = null;
- }
-
- if (corpDirectoryCursor != null) {
- corpDirectoryCursor.close();
- corpDirectoryCursor = null;
- }
+ contactsCursor = null;
+ nearbyPlacesCursor = null;
+ corpDirectoryCursor = null;
}
/**