Rename check method to isBlockedNumber.
+ Clearer name about functionality, and async nature.
+ Change it to return "false" if it fails and is trying to block an
invalid number, rather than returning "true". This matches a more
standard success/fail return paradigm.
+ Update logic for showing "invalid" message based on return value.
+ Simplify parameter set which it takes in; always take nubmer and
countryIso, because they can be used to calculate the normalized #.
Bug: 25343277
Change-Id: If6fb28a6395e207047f4b27bfac37f5c70a9bac3
diff --git a/src/com/android/dialer/CallDetailActivity.java b/src/com/android/dialer/CallDetailActivity.java
index 4e7e7b3..ab63ddc 100644
--- a/src/com/android/dialer/CallDetailActivity.java
+++ b/src/com/android/dialer/CallDetailActivity.java
@@ -394,7 +394,7 @@
return;
}
- boolean failed = mFilteredNumberAsyncQueryHandler.startBlockedQuery(
+ final boolean success = mFilteredNumberAsyncQueryHandler.isBlockedNumber(
new OnCheckBlockedListener() {
@Override
public void onCheckComplete(Integer id) {
@@ -403,9 +403,9 @@
updateContactPhoto();
updateBlockActionItem();
}
- }, null, mNumber, mDetails.countryIso);
+ }, mNumber, mDetails.countryIso);
- if (failed) {
+ if (!success) {
updateContactPhoto();
updateBlockActionItem();
}