Remove unnecessary call to StatusBarNotifier.updateNotification().
The call for incoming call is covered in StatusBarNotifier.onStateChange(). The two calls in InCallActivity is not useful (maybe is before notification becoming foreground).
Test: manual
PiperOrigin-RevId: 190845157
Change-Id: I0f84f15cfda5294566fa8976e09aac5163f85aa9
diff --git a/java/com/android/incallui/InCallActivity.java b/java/com/android/incallui/InCallActivity.java
index 8144ddb..9d08dc4 100644
--- a/java/com/android/incallui/InCallActivity.java
+++ b/java/com/android/incallui/InCallActivity.java
@@ -476,7 +476,6 @@
if (!InCallPresenter.getInstance().isReadyForTearDown()) {
updateTaskDescription();
- InCallPresenter.getInstance().updateNotification();
}
// If there is a pending request to show or hide the dialpad, handle that now.
@@ -534,8 +533,6 @@
dialpadFragment.onDialerKeyUp(null);
}
- InCallPresenter.getInstance().updateNotification();
-
InCallPresenter.getInstance().getPseudoScreenState().removeListener(this);
Trace.endSection();
}
diff --git a/java/com/android/incallui/InCallPresenter.java b/java/com/android/incallui/InCallPresenter.java
index a4b90f1..2e98a96 100644
--- a/java/com/android/incallui/InCallPresenter.java
+++ b/java/com/android/incallui/InCallPresenter.java
@@ -1050,14 +1050,6 @@
"updateIsChangingConfigurations = " + isChangingConfigurations);
}
- void updateNotification() {
- // We need to update the notification bar when we leave the UI because that
- // could trigger it to show again.
- if (statusBarNotifier != null) {
- statusBarNotifier.updateNotification();
- }
- }
-
/** Called when the activity goes in/out of the foreground. */
public void onUiShowing(boolean showing) {
if (proximitySensor != null) {
@@ -1316,11 +1308,6 @@
// know that start-up is complete.
//
// [ AND NOW YOU'RE IN THE CALL. voila! ]
- //
- // Our app is started using a fullScreen notification. We need to do this whenever
- // we get an incoming call. Depending on the current context of the device, either a
- // incoming call HUN or the actual InCallActivity will be shown.
- final boolean startIncomingCallSequence = (InCallState.INCOMING == newState);
// A dialog to show on top of the InCallUI to select a PhoneAccount
final boolean showAccountPicker = (InCallState.WAITING_FOR_ACCOUNT == newState);
@@ -1387,10 +1374,6 @@
if (showCallUi || showAccountPicker) {
LogUtil.i("InCallPresenter.startOrFinishUi", "Start in call UI");
showInCall(false /* showDialpad */, !showAccountPicker /* newOutgoingCall */);
- } else if (startIncomingCallSequence) {
- LogUtil.i("InCallPresenter.startOrFinishUi", "Start Full Screen in call UI");
-
- statusBarNotifier.updateNotification();
} else if (newState == InCallState.NO_CALLS) {
// The new state is the no calls state. Tear everything down.
attemptFinishActivity();