commit f6828029b127f60d758bf30052989d64f50cfa86
author Daisuke Miyakawa <dmiyakawa@google.com> Mon Jul 25 12:20:28 2011 -0700
committer Daisuke Miyakawa <dmiyakawa@google.com> Wed Jul 27 10:14:49 2011 -0700
tree e21c5b85ba8a3f6ca74cec13285368159a506dcc
parent 0b477b197f4735f80d07af6f610f5029745dc01e

Implement smoother swipe animation for Phone UI

Phone UI conditionally shows split ActionBar on the bottom,
which makes swipe animation less smooth. This change makes it
smoother by reducing layout re-calculation.

- stop changing menu state on onPageSelected but do so on
  onPageScrollStateChange.
- use android:windowActionBarOverlay to suppress recalculation
  during menu show-up
- add marginTop to every fragment for Phone so that fragments
  won't overlap with ActionBar
- add paddingBottom for CallLog and Favorites so that those
  fragments won't overlap with split ActionBar

FUTURE TODO:

We need custom assets for android:actionBarStyle
- android:background
- android:backgroundStacked
- android:backgroundSplit

Bug: 5022052
Change-Id: I3bd48cf9d8aaa398806531823fca63de328b807a

res/values/styles.xml

diff --git a/res/values/styles.xml b/res/values/styles.xml
index f32ae4c..e98175d 100644
--- a/res/values/styles.xml
+++ b/res/values/styles.xml
@@ -14,7 +14,9 @@
      limitations under the License.
 -->
 <resources>
-    <style name="DialtactsTheme" parent="android:Theme.Holo.SplitActionBarWhenNarrow">
+    <style name="DialtactsTheme"
+           parent="android:Theme.Holo.SolidActionBar.SplitActionBarWhenNarrow">
+        <item name="android:windowActionBarOverlay">true</item>
         <item name="android:windowContentOverlay">@null</item>
         <item name="android:windowBackground">@android:color/black</item>
         <item name="activated_background">@drawable/list_item_activated_background</item>
@@ -51,6 +53,8 @@
         <item name="call_log_voicemail_status_height">40dip</item>
         <item name="call_log_voicemail_status_background_color">#FFFFE0</item>
         <item name="call_log_voicemail_status_text_color">#000000</item>
+        <!-- Favorites -->
+        <item name="favorites_padding_bottom">?android:attr/actionBarSize</item>
     </style>
 
     <style name="CallDetailActivityTheme" parent="android:Theme.Holo.SplitActionBarWhenNarrow">
@@ -161,6 +165,10 @@
         <attr name="call_log_voicemail_status_text_color" format="color" />
     </declare-styleable>
 
+    <declare-styleable name="Favorites">
+        <attr name="favorites_padding_bottom" format="dimension" />
+    </declare-styleable>
+
     <style name="PeopleTheme" parent="@android:style/Theme.Holo.Light.SolidActionBar.Inverse.SplitActionBarWhenNarrow">
         <item name="android:actionBarStyle">@style/ContactsActionBarStyle</item>
         <item name="list_item_height">?android:attr/listPreferredItemHeight</item>
@@ -188,6 +196,8 @@
         <item name="list_item_header_underline_height">1px</item>
         <item name="list_item_header_underline_color">@color/people_app_theme_color</item>
         <item name="contact_filter_popup_width">320dip</item>
+        <!-- Favorites -->
+        <item name="favorites_padding_bottom">0dip</item>
     </style>
 
     <style name="ContactsActionBarStyle" parent="@android:style/Widget.Holo.Light.ActionBar.Solid.Inverse">