commit e90783822d17ef7696d8ec09ebb3ddd6d1768986
author Chiao Cheng <chiaocheng@google.com> Mon Jun 17 16:35:10 2013 -0700
committer Chiao Cheng <chiaocheng@google.com> Mon Jun 17 16:35:10 2013 -0700
tree d524b50f2e879e7ab5c266286c62ddf94c7c8b66
parent a364d1739d7c315ccc7db02915657250970de1cb

Fix scrollbar position for RTL.

Bug: 9338977
Change-Id: I65884152051ccb10a3362afd325b9ce77e400f20

src/com/android/contacts/activities/PeopleActivity.java

diff --git a/src/com/android/contacts/activities/PeopleActivity.java b/src/com/android/contacts/activities/PeopleActivity.java
index 639cc3a..80d5885 100644
--- a/src/com/android/contacts/activities/PeopleActivity.java
+++ b/src/com/android/contacts/activities/PeopleActivity.java
@@ -994,26 +994,31 @@
         mAllFragment.setFilter(mContactListFilterController.getFilter());
 
         final boolean useTwoPane = PhoneCapabilityTester.isUsingTwoPanes(this);
-        final Locale locale = Locale.getDefault();
-        final int layoutDirection = TextUtils.getLayoutDirectionFromLocale(locale);
-        final boolean isLayoutRtl = (layoutDirection == View.LAYOUT_DIRECTION_RTL);
-        final int position;
-        if (useTwoPane)  {
-            position = isLayoutRtl ? View.SCROLLBAR_POSITION_RIGHT : View.SCROLLBAR_POSITION_LEFT;
-        } else {
-            position = isLayoutRtl ? View.SCROLLBAR_POSITION_LEFT: View.SCROLLBAR_POSITION_RIGHT;
-        }
-        mAllFragment.setVerticalScrollbarPosition(position);
+
+        mAllFragment.setVerticalScrollbarPosition(getScrollBarPosition(useTwoPane));
         mAllFragment.setSelectionVisible(useTwoPane);
         mAllFragment.setQuickContactEnabled(!useTwoPane);
     }
 
+    private int getScrollBarPosition(boolean useTwoPane) {
+        final boolean isLayoutRtl = isRTL();
+        final int position;
+        if (useTwoPane) {
+            position = isLayoutRtl ? View.SCROLLBAR_POSITION_RIGHT : View.SCROLLBAR_POSITION_LEFT;
+        } else {
+            position = isLayoutRtl ? View.SCROLLBAR_POSITION_LEFT : View.SCROLLBAR_POSITION_RIGHT;
+        }
+        return position;
+    }
+
+    private boolean isRTL() {
+        final Locale locale = Locale.getDefault();
+        return TextUtils.getLayoutDirectionFromLocale(locale) == View.LAYOUT_DIRECTION_RTL;
+    }
+
     private void configureGroupListFragment() {
         final boolean useTwoPane = PhoneCapabilityTester.isUsingTwoPanes(this);
-        mGroupsFragment.setVerticalScrollbarPosition(
-                useTwoPane
-                        ? View.SCROLLBAR_POSITION_LEFT
-                        : View.SCROLLBAR_POSITION_RIGHT);
+        mGroupsFragment.setVerticalScrollbarPosition(getScrollBarPosition(useTwoPane));
         mGroupsFragment.setSelectionVisible(useTwoPane);
     }
 

src/com/android/contacts/group/GroupBrowseListFragment.java

diff --git a/src/com/android/contacts/group/GroupBrowseListFragment.java b/src/com/android/contacts/group/GroupBrowseListFragment.java
index d6ca3d7..39313c3 100644
--- a/src/com/android/contacts/group/GroupBrowseListFragment.java
+++ b/src/com/android/contacts/group/GroupBrowseListFragment.java
@@ -148,10 +148,8 @@
     }
 
     public void setVerticalScrollbarPosition(int position) {
-        if (mVerticalScrollbarPosition != position) {
-            mVerticalScrollbarPosition = position;
-            configureVerticalScrollbar();
-        }
+        mVerticalScrollbarPosition = position;
+        configureVerticalScrollbar();
     }
 
     private void configureVerticalScrollbar() {