Do not show geocode for voicemail number.
As I moved the geocoding to the content provider, we lost the fact that
the voicemail number should not be geocoded, because the voicemail
number can change over time and the provider does not know what it is.
Instead, this change adds an explicit check in the UI code.
Note that this was caught by a unit test, but unfortunately I did not
notice I broke it when I moved the geocoding to the content provider.
Bug: 5111400
Change-Id: Ia14d8ac1a22b52e36bdac784fad5fea706865cb7
diff --git a/src/com/android/contacts/PhoneCallDetailsHelper.java b/src/com/android/contacts/PhoneCallDetailsHelper.java
index e970fcc..e79bdce 100644
--- a/src/com/android/contacts/PhoneCallDetailsHelper.java
+++ b/src/com/android/contacts/PhoneCallDetailsHelper.java
@@ -107,7 +107,8 @@
mPhoneNumberHelper.getDisplayNumber(details.number, details.formattedNumber);
if (TextUtils.isEmpty(details.name)) {
nameText = displayNumber;
- if (TextUtils.isEmpty(details.geocode)) {
+ if (TextUtils.isEmpty(details.geocode)
+ || mPhoneNumberHelper.isVoicemailNumber(details.number)) {
numberText = mResources.getString(R.string.call_log_empty_gecode);
} else {
numberText = details.geocode;