commit d72bf8a27d12efd492df7333f1f8590a9eb6f097
author Flavio Lerda <flerda@google.com> Tue Jul 05 16:00:09 2011 +0100
committer Flavio Lerda <flerda@google.com> Tue Jul 05 16:00:09 2011 +0100
tree c34feecd0e8328c042f9cc9343dd13c3eb85baa4
parent 963f219df44f5577aa973dca931fcd6fb60921eb

Cache values extracted from resources.

Change-Id: I672710e691eaee135a0d688ef5ef80abed1ed27a

src/com/android/contacts/CallDetailActivity.java

diff --git a/src/com/android/contacts/CallDetailActivity.java b/src/com/android/contacts/CallDetailActivity.java
index c45d2d2..43b3bee 100644
--- a/src/com/android/contacts/CallDetailActivity.java
+++ b/src/com/android/contacts/CallDetailActivity.java
@@ -115,7 +115,7 @@
         mResources = getResources();
 
         mPhoneCallDetailsViews = new PhoneCallDetailsViews(getWindow().getDecorView());
-        mPhoneCallDetailsHelper = new PhoneCallDetailsHelper();
+        mPhoneCallDetailsHelper = new PhoneCallDetailsHelper(getResources());
         mCallActionView = findViewById(R.id.call);
         mContactPhotoView = (ImageView) findViewById(R.id.contact_photo);
         mContactBackgroundView = (ImageView) findViewById(R.id.contact_background);
@@ -257,8 +257,8 @@
                     ViewAdapter adapter = new ViewAdapter(this, actions);
                     setListAdapter(adapter);
                 }
-                mPhoneCallDetailsHelper.setPhoneCallDetails(mPhoneCallDetailsViews, getResources(),
-                        date, callType, nameText, numberText, numberType, numberLabel);
+                mPhoneCallDetailsHelper.setPhoneCallDetails(mPhoneCallDetailsViews, date, callType,
+                        nameText, numberText, numberType, numberLabel);
 
                 loadContactPhotos(photoId);
             } else {

src/com/android/contacts/PhoneCallDetailsHelper.java

diff --git a/src/com/android/contacts/PhoneCallDetailsHelper.java b/src/com/android/contacts/PhoneCallDetailsHelper.java
index 84a498a..6542f7d 100644
--- a/src/com/android/contacts/PhoneCallDetailsHelper.java
+++ b/src/com/android/contacts/PhoneCallDetailsHelper.java
@@ -32,10 +32,28 @@
  * Helper class to fill in the views in {@link PhoneCallDetailsViews}.
  */
 public class PhoneCallDetailsHelper {
+    private final Resources mResources;
+    private final String mTypeIncomingText;
+    private final String mTypeOutgoingText;
+    private final String mTypeMissedText;
+
+    /**
+     * Creates a new instance of the helper.
+     * <p>
+     * Generally you should have a single instance of this helper in any context.
+     *
+     * @param resources used to look up strings
+     */
+    public PhoneCallDetailsHelper(Resources resources) {
+        mResources = resources;
+        mTypeIncomingText = mResources.getString(R.string.type_incoming);
+        mTypeOutgoingText = mResources.getString(R.string.type_outgoing);
+        mTypeMissedText = mResources.getString(R.string.type_missed);
+    }
+
     /**
      * Fills the call details views with content.
      *
-     * @param resources used to look up strings
      * @param date the date of the call, in milliseconds since the epoch
      * @param callType the type of call, as defined in the call log table
      * @param name the name of the contact, if available
@@ -43,21 +61,21 @@
      * @param numberType the type of phone, e.g., {@link Phone#TYPE_HOME}, 0 if not available
      * @param numberLabel the custom label associated with the phone number in the contact
      */
-    public void setPhoneCallDetails(PhoneCallDetailsViews views, Resources resources, long date,
+    public void setPhoneCallDetails(PhoneCallDetailsViews views, long date,
             int callType, CharSequence name, CharSequence number, int numberType,
             CharSequence numberLabel) {
         CharSequence callTypeText = "";
         switch (callType) {
             case Calls.INCOMING_TYPE:
-                callTypeText = resources.getString(R.string.type_incoming);
+                callTypeText = mTypeIncomingText;
                 break;
 
             case Calls.OUTGOING_TYPE:
-                callTypeText = resources.getString(R.string.type_outgoing);
+                callTypeText = mTypeOutgoingText;
                 break;
 
             case Calls.MISSED_TYPE:
-                callTypeText = resources.getString(R.string.type_missed);
+                callTypeText = mTypeMissedText;
                 break;
         }
 
@@ -74,7 +92,7 @@
         CharSequence numberFormattedLabel = null;
         // Only show a label if the number is shown and it is not a SIP address.
         if (!TextUtils.isEmpty(number) && !PhoneNumberUtils.isUriNumber(number.toString())) {
-            numberFormattedLabel = Phone.getTypeLabel(resources, numberType, numberLabel);
+            numberFormattedLabel = Phone.getTypeLabel(mResources, numberType, numberLabel);
         }
 
         CharSequence nameText;