Pixel perfect tweaks for tablet
- Fix contact list item height
- Shift the Gtalk presence icon down
- Fix padding with name/company in contact details
- Remove the blue underline view in the group header
and use an asset on the existing container instead
Bug: 5543418
Change-Id: I635ff78e479b575055506fda0c19e8a4685f0c1e
diff --git a/res/layout-sw580dp/detail_header_contact_with_updates.xml b/res/layout-sw580dp/detail_header_contact_with_updates.xml
index fa6f301..43cf4c0 100644
--- a/res/layout-sw580dp/detail_header_contact_with_updates.xml
+++ b/res/layout-sw580dp/detail_header_contact_with_updates.xml
@@ -56,6 +56,7 @@
android:layout_width="0dip"
android:layout_height="wrap_content"
android:layout_weight="1"
+ android:paddingLeft="8dip"
android:paddingRight="24dip"
android:textAppearance="?android:attr/textAppearanceLarge"
android:textSize="@dimen/detail_header_name_text_size" />
@@ -69,6 +70,7 @@
android:id="@+id/company"
android:layout_width="match_parent"
android:layout_height="wrap_content"
+ android:paddingLeft="8dip"
android:textAppearance="?android:attr/textAppearanceMedium"
android:textColor="?android:attr/textColorSecondary" />
diff --git a/res/layout-sw580dp/detail_header_contact_without_updates.xml b/res/layout-sw580dp/detail_header_contact_without_updates.xml
index a55764d..9261f11 100644
--- a/res/layout-sw580dp/detail_header_contact_without_updates.xml
+++ b/res/layout-sw580dp/detail_header_contact_without_updates.xml
@@ -24,7 +24,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="vertical"
- android:paddingBottom="8dip">
+ android:paddingBottom="16dip">
<!-- Ensure that the contact photo for a contact WITHOUT social updates is the same width and
height as a contact WITH social updates (where the photo is 2/3 of the screen width). -->
@@ -70,6 +70,7 @@
android:layout_width="0dip"
android:layout_height="wrap_content"
android:layout_weight="1"
+ android:paddingLeft="8dip"
android:paddingRight="24dip"
android:textAppearance="?android:attr/textAppearanceLarge"
android:textSize="@dimen/detail_header_name_text_size" />
@@ -83,6 +84,7 @@
android:id="@+id/company"
android:layout_width="match_parent"
android:layout_height="wrap_content"
+ android:paddingLeft="8dip"
android:textAppearance="?android:attr/textAppearanceMedium"
android:textColor="?android:attr/textColorSecondary" />
diff --git a/res/layout-sw680dp-w1000dp/contact_detail_list_item.xml b/res/layout-sw680dp-w1000dp/contact_detail_list_item.xml
index ccecc35..98ffce6 100644
--- a/res/layout-sw680dp-w1000dp/contact_detail_list_item.xml
+++ b/res/layout-sw680dp-w1000dp/contact_detail_list_item.xml
@@ -65,6 +65,7 @@
android:id="@+id/presence_icon"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
+ android:layout_marginTop="1dip"
android:layout_marginRight="4dip"
android:layout_gravity="center_vertical"
android:scaleType="centerInside" />
diff --git a/res/layout-sw680dp-w1000dp/detail_header_contact_with_updates.xml b/res/layout-sw680dp-w1000dp/detail_header_contact_with_updates.xml
index b9a9dbd..dfba659 100644
--- a/res/layout-sw680dp-w1000dp/detail_header_contact_with_updates.xml
+++ b/res/layout-sw680dp-w1000dp/detail_header_contact_with_updates.xml
@@ -24,6 +24,7 @@
xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="wrap_content"
+ android:paddingBottom="8dip"
android:orientation="horizontal">
<ImageView
diff --git a/res/layout-sw680dp-w1000dp/detail_header_contact_without_updates.xml b/res/layout-sw680dp-w1000dp/detail_header_contact_without_updates.xml
index 6ef4651..f9dcf3d 100644
--- a/res/layout-sw680dp-w1000dp/detail_header_contact_without_updates.xml
+++ b/res/layout-sw680dp-w1000dp/detail_header_contact_without_updates.xml
@@ -23,6 +23,8 @@
xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="wrap_content"
+ android:paddingLeft="8dip"
+ android:paddingBottom="16dip"
android:orientation="vertical">
<LinearLayout
@@ -48,6 +50,7 @@
android:id="@+id/company"
android:layout_width="match_parent"
android:layout_height="wrap_content"
+ android:paddingTop="16dip"
android:textAppearance="?android:attr/textAppearanceMedium"
android:textColor="?android:attr/textColorSecondary" />
diff --git a/res/layout/contact_detail_list_item.xml b/res/layout/contact_detail_list_item.xml
index a410dc9..44f5a53 100644
--- a/res/layout/contact_detail_list_item.xml
+++ b/res/layout/contact_detail_list_item.xml
@@ -60,6 +60,7 @@
android:id="@+id/presence_icon"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
+ android:layout_marginTop="1dip"
android:layout_marginRight="4dip"
android:layout_gravity="center_vertical"
android:gravity="center"
diff --git a/res/layout/group_browse_list_account_header.xml b/res/layout/group_browse_list_account_header.xml
index 36c6d7a..709c276 100644
--- a/res/layout/group_browse_list_account_header.xml
+++ b/res/layout/group_browse_list_account_header.xml
@@ -30,8 +30,9 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:minHeight="?attr/list_item_header_height"
- android:paddingLeft="?attr/list_item_padding_left"
- android:paddingRight="?attr/list_item_padding_right"
+ android:layout_marginLeft="?attr/list_item_padding_left"
+ android:layout_marginRight="?attr/list_item_padding_right"
+ android:background="@drawable/list_section_divider_holo_custom"
android:orientation="horizontal">
<TextView
@@ -54,16 +55,10 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center_vertical"
- android:textAppearance="?android:attr/textAppearanceSmall"
android:textColor="@color/contact_count_text_color"
android:textSize="12sp"
android:singleLine="true"
android:ellipsize="middle" />
</LinearLayout>
- <View
- android:layout_width="match_parent"
- android:layout_height="1dip"
- android:background="@color/people_app_theme_color" />
-
</LinearLayout>
diff --git a/res/values-sw680dp/styles.xml b/res/values-sw680dp/styles.xml
index 0d750d7..b7a7700 100644
--- a/res/values-sw680dp/styles.xml
+++ b/res/values-sw680dp/styles.xml
@@ -22,7 +22,7 @@
<item name="android:textColorPrimary">@color/primary_text_color</item>
<item name="android:textColorSecondary">@color/secondary_text_color</item>
<item name="android:listViewStyle">@style/ListViewStyle</item>
- <item name="list_item_height">66dip</item>
+ <item name="list_item_height">?android:attr/listPreferredItemHeight</item>
<item name="activated_background">@drawable/list_item_activated_background</item>
<item name="section_header_background">@drawable/list_title_holo</item>
<item name="list_item_divider">?android:attr/listDivider</item>