commit b5f5e8b73e52aff611da1142040ea9b423ccb070
author John Shao <johnshao@google.com> Mon Sep 26 11:19:55 2016 -0700
committer John Shao <johnshao@google.com> Mon Sep 26 11:24:23 2016 -0700
tree a9963658f147c0cbab1ce12e8dbc3c6ad58ff316
parent 996e80f8b429311b0d8099e47716e304bec95d13

Reorder permissions in android manifest

Samsung and possibly other OEMs use the order that
the permission appears in the manifest to determine
what order the permissions are requested. Move contacts
permissions to the top so we always show that request first.

Test: Manual
  - revoke permission on samsung s7 and nexus 5x and see that
    contacts permission is requested first noi

Bug:30576744
Change-Id: I52b1c29527e4048558f381a3e0c5e1f023858caa

AndroidManifest.xml

diff --git a/AndroidManifest.xml b/AndroidManifest.xml
index 2a12215..ff3346f 100644
--- a/AndroidManifest.xml
+++ b/AndroidManifest.xml
@@ -23,13 +23,15 @@
 
     <original-package android:name="com.android.contacts" />
 
-    <uses-permission android:name="android.permission.CALL_PHONE" />
+    <!-- Contacts permission listed first because order determines
+         order that permissions are requested with some OEMs -->
     <uses-permission android:name="android.permission.READ_CONTACTS" />
     <uses-permission android:name="android.permission.WRITE_CONTACTS" />
-    <uses-permission android:name="android.permission.MANAGE_ACCOUNTS" />
     <uses-permission android:name="android.permission.GET_ACCOUNTS" />
     <uses-permission android:name="android.permission.GET_ACCOUNTS_PRIVILEGED" />
+    <uses-permission android:name="android.permission.MANAGE_ACCOUNTS" />
     <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
+    <uses-permission android:name="android.permission.CALL_PHONE" />
     <uses-permission android:name="android.permission.READ_PROFILE" />
     <uses-permission android:name="android.permission.WRITE_PROFILE" />
     <uses-permission android:name="android.permission.INTERNET" />