commit 7cd9af38ceb0e6ab3a61f1068e87f18d6b628d9f
author Wenyi Wang <wenyiw@google.com> Sun Jul 17 16:00:43 2016 -0700
committer Wenyi Wang <wenyiw@google.com> Sun Jul 17 21:52:36 2016 -0700
tree fa44d4e7d5d7a88759392535c624b6fb03952fe8
parent 9294263258a44d6ee42ac1dba964eb3765d2f494

Avoid changing list view padding to zero

When we set top padding, we also set other paddings to zero,
which caused the layout of list view on tablets to be wrong.

Bug 30180750
Bug 29190106

Change-Id: Ief1519e20df403d83b0682081b0160144890383b

src/com/android/contacts/list/MultiSelectContactsListFragment.java

diff --git a/src/com/android/contacts/list/MultiSelectContactsListFragment.java b/src/com/android/contacts/list/MultiSelectContactsListFragment.java
index 1e3c191..bad44eb 100644
--- a/src/com/android/contacts/list/MultiSelectContactsListFragment.java
+++ b/src/com/android/contacts/list/MultiSelectContactsListFragment.java
@@ -351,7 +351,7 @@
     private void bindListHeaderCommon(View listView, View accountFilterContainer) {
         // Show header and remove top padding of the list
         accountFilterContainer.setVisibility(View.VISIBLE);
-        listView.setPadding(0, 0, 0, 0);
+        setListViewPaddingTop(listView, /* paddingTop */ 0);
     }
 
     /**
@@ -360,8 +360,14 @@
     protected void hideHeaderAndAddPadding(Context context, View listView,
             View accountFilterContainer) {
         accountFilterContainer.setVisibility(View.GONE);
-        listView.setPadding(0, context.getResources().getDimensionPixelSize(
-                R.dimen.contact_browser_list_item_padding_top_or_bottom), 0, 0);
+        setListViewPaddingTop(listView,
+                /* paddingTop */ context.getResources().getDimensionPixelSize(
+                        R.dimen.contact_browser_list_item_padding_top_or_bottom));
+    }
+
+    private void setListViewPaddingTop(View listView, int paddingTop) {
+        listView.setPadding(listView.getPaddingLeft(), paddingTop, listView.getPaddingRight(),
+                listView.getPaddingBottom());
     }
 
 }