commit 7394c4375bb7e0b279d813e7a73ffcb10e5825c2
author Wenyi Wang <wenyiw@google.com> Tue Oct 13 21:03:36 2015 -0700
committer Wenyi Wang <wenyiw@google.com> Wed Oct 14 11:39:33 2015 -0700
tree 6fe6a541af81bcf7d1ca3a2231881515f16dba82
parent ba6c41ca6da97f56f608a9ef92617f2401f8371e

Avoid saving contact when user doesn't intend to do so.

We will not save contact when user:
	1. picks a photo;
	2. presses "Recent" button;
	3. presses "Home" button;

Bug: 24898586
Change-Id: I40339de573ac069abffada1a6329009c3b97076c

src/com/android/contacts/editor/CompactContactEditorFragment.java

diff --git a/src/com/android/contacts/editor/CompactContactEditorFragment.java b/src/com/android/contacts/editor/CompactContactEditorFragment.java
index 058a66c..6e4c4be 100644
--- a/src/com/android/contacts/editor/CompactContactEditorFragment.java
+++ b/src/com/android/contacts/editor/CompactContactEditorFragment.java
@@ -82,16 +82,6 @@
     }
 
     @Override
-    public void onStop() {
-        super.onStop();
-
-        // If anything was left unsaved, save it now
-        if (!getActivity().isChangingConfigurations() && mStatus == Status.EDITING) {
-            save(SaveMode.RELOAD);
-        }
-    }
-
-    @Override
     public boolean onOptionsItemSelected(MenuItem item) {
         if (item.getItemId() == android.R.id.home) {
             return revert();

src/com/android/contacts/editor/ContactEditorBaseFragment.java

diff --git a/src/com/android/contacts/editor/ContactEditorBaseFragment.java b/src/com/android/contacts/editor/ContactEditorBaseFragment.java
index 1e18e2c..481383e 100644
--- a/src/com/android/contacts/editor/ContactEditorBaseFragment.java
+++ b/src/com/android/contacts/editor/ContactEditorBaseFragment.java
@@ -643,13 +643,7 @@
     @Override
     public void onStop() {
         super.onStop();
-
         UiClosables.closeQuietly(mAggregationSuggestionPopup);
-
-        // If anything was left unsaved, save it now but keep the editor open.
-        if (!getActivity().isChangingConfigurations() && mStatus == Status.EDITING) {
-            save(SaveMode.RELOAD);
-        }
     }
 
     @Override