Further clean-up of PhoneFavoriteFragment.
Moving common dependencies from Contacts to ContactsCommon.
Bug: 6993891
Change-Id: I7530d13771b65f17dafa3f4f8283965622b1c71e
diff --git a/res-common/values/colors.xml b/res-common/values/colors.xml
index 13eadd3..48ef4ec 100644
--- a/res-common/values/colors.xml
+++ b/res-common/values/colors.xml
@@ -25,4 +25,12 @@
<!-- Color of image view placeholder. -->
<color name="image_placeholder">#DDDDDD</color>
+ <!-- Secondary text color in the Phone app -->
+ <color name="dialtacts_secondary_text_color">#888888</color>
+
+ <!-- Color of the semi-transparent shadow box on contact tiles -->
+ <color name="contact_tile_shadow_box_color">#7F000000</color>
+
+ <!-- Color of the status message for starred contacts in the People app -->
+ <color name="people_contact_tile_status_color">#CCCCCC</color>
</resources>
diff --git a/res-common/values/dimens.xml b/res-common/values/dimens.xml
index c17234c..97e6fe7 100644
--- a/res-common/values/dimens.xml
+++ b/res-common/values/dimens.xml
@@ -24,4 +24,20 @@
Right now the drawable has implicit 32dip minimal height, which is confusing.
This value is for making the hidden configuration explicit in xml. -->
<dimen name="list_section_divider_min_height">32dip</dimen>
+
+ <!-- Vertical and horizontal padding in between contact tiles -->
+ <dimen name="contact_tile_divider_padding">1dip</dimen>
+
+ <!-- Left and right padding for a contact detail item -->
+ <dimen name="detail_item_side_margin">16dip</dimen>
+
+ <!-- ContactTile Layouts -->
+ <!--
+ Use sp instead of dip so that the shadowbox heights can all scale uniformly
+ when the font size is scaled for accessibility purposes
+ -->
+ <dimen name="contact_tile_shadowbox_height">48sp</dimen>
+
+ <!-- Top padding of the ListView in the contact tile list -->
+ <dimen name="contact_tile_list_padding_top">0dip</dimen>
</resources>
diff --git a/res-common/values/strings.xml b/res-common/values/strings.xml
index 87ea719..cc85566 100644
--- a/res-common/values/strings.xml
+++ b/res-common/values/strings.xml
@@ -177,4 +177,21 @@
<!-- Shown as the display name for a person when the name is missing or unknown. [CHAR LIMIT=18]-->
<string name="missing_name">(No name)</string>
+
+ <!-- The text displayed on the divider for the Favorites tab in Phone app indicating that items below it are frequently called as opposed to starred contacts [CHAR LIMIT = 39] -->
+ <string name="favoritesFrequentCalled">Frequently called</string>
+
+ <!-- The text displayed on the divider for the Favorites tab in People app indicating that items below it are frequently contacted [CHAR LIMIT = 39] -->
+ <string name="favoritesFrequentContacted">Frequently contacted</string>
+
+ <!-- String describing a contact picture that introduces users to the contact detail screen.
+
+ Used by AccessibilityService to announce the purpose of the button.
+
+ [CHAR LIMIT=NONE]
+ -->
+ <string name="description_view_contact_detail" msgid="2795575601596468581">View contact</string>
+
+ <!-- Contact list filter selection indicating that the list shows all contacts with phone numbers [CHAR LIMIT=64] -->
+ <string name="list_filter_phones">All contacts with phone numbers</string>
</resources>
diff --git a/res-common/values/styles.xml b/res-common/values/styles.xml
index 45137e7..7522f99 100644
--- a/res-common/values/styles.xml
+++ b/res-common/values/styles.xml
@@ -19,4 +19,25 @@
<style name="DirectoryHeader">
<item name="android:background">@android:color/transparent</item>
</style>
+
+ <!-- TextView style with blue underline. It is most suitable for headers.
+
+This is similar to ?android:attr/listSeparatorTextView but uses different
+background and text color. See also android:style/Widget.Holo.TextView.ListSeparator
+(which is private, so we cannot specify it as a parent style). -->
+ <style name="ContactListSeparatorTextViewStyle">
+ <item name="android:layout_width">match_parent</item>
+ <item name="android:layout_height">wrap_content</item>
+ <!-- See comments for @dimen/list_section_divider_min_height -->
+ <item name="android:minHeight">@dimen/list_section_divider_min_height</item>
+ <item name="android:background">@drawable/list_section_divider_holo_custom</item>
+ <item name="android:textAppearance">?android:attr/textAppearanceSmall</item>
+ <item name="android:textStyle">bold</item>
+ <item name="android:textColor">@color/people_app_theme_color</item>
+ <item name="android:gravity">center_vertical</item>
+ <item name="android:paddingLeft">8dip</item>
+ <item name="android:ellipsize">end</item>
+ <item name="android:singleLine">true</item>
+ <item name="android:textAllCaps">true</item>
+ </style>
</resources>