commit 547c91765f432ce34da0044e55f1cc0a5da2398e
author Daisuke Miyakawa <dmiyakawa@google.com> Fri Mar 09 10:27:11 2012 -0800
committer Daisuke Miyakawa <dmiyakawa@google.com> Tue Mar 13 12:11:46 2012 -0700
tree 7c30545d20d7a4ba5411111a2d45a1ebbb414bf4
parent 3c25167fcae33853e6bd7567b3d883c6adb4a7c2

Move fake menu buttons to DialtactsActivity

Currenty fake menu buttons are in DialpadFragment, which requires the app
to render split ActionBars during users drag events. Because of that
we have a rendering problem around horizontal swipes (bug 6126934: Lots
of stutter in animations between Dialer tabs).

This change moves those buttons to DialtactsActivity and delay menu
creation until really necessary.

This change also introduces some verbose logs, to detect possible new
problems or bug 6041917.

Bug: 6041917
Bug: 6126934
Change-Id: Ic2d8d82461e6d1916f2309b775f47c47d310ad1a

res/layout/dialpad_fragment.xml

diff --git a/res/layout/dialpad_fragment.xml b/res/layout/dialpad_fragment.xml
index a95e4cb..796eb28 100644
--- a/res/layout/dialpad_fragment.xml
+++ b/res/layout/dialpad_fragment.xml
@@ -64,27 +64,18 @@
        android:layout_height="@dimen/dialpad_vertical_margin"
        android:background="#66000000"/>
 
-    <LinearLayout
+    <!-- left and right paddings will be modified by the code. See DialpadFragment. -->
+    <FrameLayout
         android:id="@+id/dialButtonContainer"
         android:layout_width="match_parent"
         android:layout_height="0px"
         android:layout_weight="@integer/dialpad_layout_weight_additional_buttons"
         android:layout_gravity="center_horizontal"
         android:background="@drawable/dialpad_background">
-        <ImageButton
-            android:id="@+id/searchButton"
-            android:layout_width="wrap_content"
-            android:layout_height="?android:attr/actionBarSize"
-            android:layout_gravity="bottom|center_horizontal"
-            android:state_enabled="false"
-            android:background="?android:attr/selectableItemBackground"
-            android:contentDescription="@string/description_search_button"
-            android:src="@drawable/ic_dial_action_search"/>
 
         <ImageButton
             android:id="@+id/dialButton"
-            android:layout_width="0px"
-            android:layout_weight="1"
+            android:layout_width="match_parent"
             android:layout_height="match_parent"
             android:layout_gravity="center"
             android:state_enabled="false"
@@ -92,16 +83,7 @@
             android:contentDescription="@string/description_dial_button"
             android:src="@drawable/ic_dial_action_call" />
 
-        <ImageButton
-            android:id="@+id/overflow_menu"
-            android:layout_width="wrap_content"
-            android:layout_height="?android:attr/actionBarSize"
-            android:layout_gravity="bottom|center_horizontal"
-            android:src="@drawable/ic_menu_overflow"
-            android:contentDescription="@string/action_menu_overflow_description"
-            android:nextFocusLeft="@id/digits"
-            android:background="?android:attr/selectableItemBackground"/>
-    </LinearLayout>
+    </FrameLayout>
 
     <!-- "Dialpad chooser" UI, shown only when the user brings up the
          Dialer while a call is already in progress.