commit 4a268d3dc9eb0fa067b1e408199ec7c969f34a25
author Walter Jang <wjang@google.com> Mon Mar 16 18:18:59 2015 -0700
committer Walter Jang <wjang@google.com> Tue Mar 17 13:47:08 2015 -0700
tree 0c40e12e3dbd8188c30a1d13bd7bbd4e3b7dd710
parent ff16eea0e4d18cf2964667ce8e597780797e2b69

Add gradient behind photo icon is contact photo is set

Bug 19732687

Change-Id: Iad82b23aedf25e3e9a9ced8d2cd30190b69240de

res/layout/compact_photo_editor_view.xml

diff --git a/res/layout/compact_photo_editor_view.xml b/res/layout/compact_photo_editor_view.xml
index f3e7f7b..33449a8 100644
--- a/res/layout/compact_photo_editor_view.xml
+++ b/res/layout/compact_photo_editor_view.xml
@@ -28,6 +28,12 @@
             android:layout_height="match_parent"
             android:scaleType="centerCrop"/>
 
+    <View
+            android:id="@+id/photo_icon_overlay"
+            android:layout_height="56dp"
+            android:layout_width="match_parent"
+            android:layout_alignParentBottom="true" />
+
     <ImageView
             android:id="@+id/photo_icon"
             android:layout_width="24dp"

src/com/android/contacts/editor/CompactPhotoEditorView.java

diff --git a/src/com/android/contacts/editor/CompactPhotoEditorView.java b/src/com/android/contacts/editor/CompactPhotoEditorView.java
index ef96854..7483af6 100644
--- a/src/com/android/contacts/editor/CompactPhotoEditorView.java
+++ b/src/com/android/contacts/editor/CompactPhotoEditorView.java
@@ -34,6 +34,7 @@
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.graphics.BitmapFactory;
+import android.graphics.drawable.GradientDrawable;
 import android.net.Uri;
 import android.provider.ContactsContract;
 import android.provider.ContactsContract.CommonDataKinds.Photo;
@@ -66,6 +67,7 @@
     private MaterialPalette mMaterialPalette;
 
     private QuickContactImageView mPhotoImageView;
+    private View mPhotoIconOverlay;
 
     public CompactPhotoEditorView(Context context) {
         this(context, null);
@@ -90,6 +92,7 @@
         mContactPhotoManager = ContactPhotoManager.getInstance(getContext());
 
         mPhotoImageView = (QuickContactImageView) findViewById(R.id.photo);
+        mPhotoIconOverlay = findViewById(R.id.photo_icon_overlay);
         findViewById(R.id.photo_touch_intercept_overlay).setOnClickListener(this);
     }
 
@@ -132,7 +135,12 @@
             }
         }
 
-        if (!mIsPhotoSet) {
+        if (mIsPhotoSet) {
+            // Add background color behind the white photo icon so that it's visible even
+            // if the contact photo is white.
+            mPhotoIconOverlay.setBackground(new GradientDrawable(
+                    GradientDrawable.Orientation.TOP_BOTTOM, new int[]{0, 0x88000000}));
+        } else {
             setDefaultPhotoTint();
         }