commit 44b90b09a61c53cd61b6f8ff0889f85b7d3490bb
author Makoto Onuki <omakoto@google.com> Fri Aug 26 14:21:07 2011 -0700
committer Makoto Onuki <omakoto@google.com> Fri Aug 26 14:31:05 2011 -0700
tree eb39d324f4fbd8d899d4509f6892cf4868b02640
parent 1c89efe5953c7d7d251cb615b0077216dfffbd3c

Fix group list scroll position resetting issue

- Clear mSelectionToScreenRequested once requestSelectionToScreen() is called.
- Do requestSelectionToScreen() only when selection is visible (i.e. on tablet)
- Also removed unnecessary ListView.save/restoreState.  There was no code between
  these.

Bug 5221320

Change-Id: Ie3dd466b4f3f84562ffec4c72a8026f5833a0b5d

src/com/android/contacts/group/GroupBrowseListFragment.java

diff --git a/src/com/android/contacts/group/GroupBrowseListFragment.java b/src/com/android/contacts/group/GroupBrowseListFragment.java
index 2b9c594..82539e8 100644
--- a/src/com/android/contacts/group/GroupBrowseListFragment.java
+++ b/src/com/android/contacts/group/GroupBrowseListFragment.java
@@ -220,12 +220,9 @@
         }
         mAdapter.setCursor(mGroupListCursor);
 
-        Parcelable listState = mListView.onSaveInstanceState();
         if (mSelectionToScreenRequested) {
+            mSelectionToScreenRequested = false;
             requestSelectionToScreen();
-        } else {
-            // Restore the scroll position.
-            mListView.onRestoreInstanceState(listState);
         }
 
         mSelectedGroupUri = mAdapter.getSelectedGroup();
@@ -262,6 +259,9 @@
     }
 
     protected void requestSelectionToScreen() {
+        if (!mSelectionVisible) {
+            return; // If selection isn't visible we don't care.
+        }
         int selectedPosition = mAdapter.getSelectedGroupPosition();
         if (selectedPosition != -1) {
             mListView.requestPositionToScreen(selectedPosition,