commit 3add20ef94d988706ecd0708ab8ae235d60b5b87
author Dmitri Plotnikov <dplotnikov@google.com> Mon Jan 24 13:25:05 2011 -0800
committer Android (Google) Code Review <android-gerrit@google.com> Mon Jan 24 13:25:05 2011 -0800
tree 3aaca9841c0c3c39c335b177be4ff3a603ea8138
parent 95beed7d7ec229d916ce03b1136af958a1b5c6be
parent c69a9ccb6c6440127f75b51aca123afa6946474a

Merge "Making Event and Group selectors look like spinners" into honeycomb

src/com/android/contacts/list/ContactListAdapter.java

diff --git a/src/com/android/contacts/list/ContactListAdapter.java b/src/com/android/contacts/list/ContactListAdapter.java
index 2183622..a6db641 100644
--- a/src/com/android/contacts/list/ContactListAdapter.java
+++ b/src/com/android/contacts/list/ContactListAdapter.java
@@ -234,9 +234,14 @@
     }
 
     protected void bindSectionHeaderAndDivider(ContactListItemView view, int position) {
-        Placement placement = getItemPlacementInSection(position);
-        view.setSectionHeader(placement.firstInSection ? placement.sectionHeader : null);
-        view.setDividerVisible(!placement.lastInSection);
+        if (isSectionHeaderDisplayEnabled()) {
+            Placement placement = getItemPlacementInSection(position);
+            view.setSectionHeader(placement.firstInSection ? placement.sectionHeader : null);
+            view.setDividerVisible(!placement.lastInSection);
+        } else {
+            view.setSectionHeader(null);
+            view.setDividerVisible(true);
+        }
     }
 
     protected void bindPhoto(final ContactListItemView view, int partitionIndex, Cursor cursor) {

src/com/android/contacts/list/PhoneNumberListAdapter.java

diff --git a/src/com/android/contacts/list/PhoneNumberListAdapter.java b/src/com/android/contacts/list/PhoneNumberListAdapter.java
index ffd5ab9..48a6042 100644
--- a/src/com/android/contacts/list/PhoneNumberListAdapter.java
+++ b/src/com/android/contacts/list/PhoneNumberListAdapter.java
@@ -174,19 +174,12 @@
     }
 
     protected void bindSectionHeaderAndDivider(final ContactListItemView view, int position) {
-        final int section = getSectionForPosition(position);
-        if (getPositionForSection(section) == position) {
-            String title = (String)getSections()[section];
-            view.setSectionHeader(title);
+        if (isSectionHeaderDisplayEnabled()) {
+            Placement placement = getItemPlacementInSection(position);
+            view.setSectionHeader(placement.firstInSection ? placement.sectionHeader : null);
+            view.setDividerVisible(!placement.lastInSection);
         } else {
-            view.setDividerVisible(false);
             view.setSectionHeader(null);
-        }
-
-        // move the divider for the last item in a section
-        if (getPositionForSection(section + 1) - 1 == position) {
-            view.setDividerVisible(false);
-        } else {
             view.setDividerVisible(true);
         }
     }
@@ -205,10 +198,4 @@
 
         getPhotoLoader().loadPhoto(view.getPhotoView(), photoId);
     }
-//
-//    protected void bindSearchSnippet(final ContactListItemView view, Cursor cursor) {
-//        view.showSnippet(cursor, SUMMARY_SNIPPET_MIMETYPE_COLUMN_INDEX,
-//                SUMMARY_SNIPPET_DATA1_COLUMN_INDEX, SUMMARY_SNIPPET_DATA4_COLUMN_INDEX);
-//    }
-
 }

src/com/android/contacts/list/PhoneNumberPickerFragment.java

diff --git a/src/com/android/contacts/list/PhoneNumberPickerFragment.java b/src/com/android/contacts/list/PhoneNumberPickerFragment.java
index a84f4ff..071a370 100644
--- a/src/com/android/contacts/list/PhoneNumberPickerFragment.java
+++ b/src/com/android/contacts/list/PhoneNumberPickerFragment.java
@@ -36,6 +36,8 @@
     public PhoneNumberPickerFragment() {
         setQuickContactEnabled(false);
         setPhotoLoaderEnabled(true);
+        setVisibleScrollbarEnabled(true);
+        setSectionHeaderDisplayEnabled(true);
         setDirectorySearchMode(DirectoryListLoader.SEARCH_MODE_DATA_SHORTCUT);
     }
 
@@ -76,13 +78,6 @@
     }
 
     @Override
-    protected void configureAdapter() {
-        setSectionHeaderDisplayEnabled(!isSearchMode());
-        setVisibleScrollbarEnabled(!isSearchMode());
-        super.configureAdapter();
-    }
-
-    @Override
     protected View inflateView(LayoutInflater inflater, ViewGroup container) {
         return inflater.inflate(R.layout.contacts_list_content, null);
     }